From 2e906b255747c4a32e8479e5cc44a986dfd57a9e Mon Sep 17 00:00:00 2001 From: Ehsan ESTAJI <71376358+ehsanestaji@users.noreply.github.com> Date: Mon, 18 May 2026 21:03:24 +0200 Subject: [PATCH] chore: align Bioconda recipe starter --- packaging/bioconda/build.sh | 5 +++-- packaging/bioconda/meta.yaml | 4 ---- tests/python/test_release_metadata.py | 11 +++++++++++ 3 files changed, 14 insertions(+), 6 deletions(-) diff --git a/packaging/bioconda/build.sh b/packaging/bioconda/build.sh index 38b08ee..f3ba6f7 100755 --- a/packaging/bioconda/build.sh +++ b/packaging/bioconda/build.sh @@ -5,7 +5,8 @@ cargo-bundle-licenses --format yaml --output THIRDPARTY.yml cargo install -v --locked --no-track --root "${PREFIX}" --path . rm -f "${PREFIX}/.crates.toml" "${PREFIX}/.crates2.json" -install -Dm644 schema/fastaguard.schema.json \ +mkdir -p "${PREFIX}/share/${PKG_NAME}/schema" +install -m644 schema/fastaguard.schema.json \ "${PREFIX}/share/${PKG_NAME}/schema/fastaguard.schema.json" -install -Dm644 schema/finding-catalog.json \ +install -m644 schema/finding-catalog.json \ "${PREFIX}/share/${PKG_NAME}/schema/finding-catalog.json" diff --git a/packaging/bioconda/meta.yaml b/packaging/bioconda/meta.yaml index fed1d4f..64de0de 100644 --- a/packaging/bioconda/meta.yaml +++ b/packaging/bioconda/meta.yaml @@ -17,10 +17,6 @@ requirements: - {{ compiler('rust') }} - {{ compiler('c') }} - cargo-bundle-licenses - host: - - zlib - run: - - zlib test: commands: diff --git a/tests/python/test_release_metadata.py b/tests/python/test_release_metadata.py index f89e8c9..57e733a 100644 --- a/tests/python/test_release_metadata.py +++ b/tests/python/test_release_metadata.py @@ -30,6 +30,17 @@ def test_bioconda_recipe_sha256_is_real_hash(self): self.assertIsNotNone(match, recipe) self.assertNotIn("REPLACE_WITH_PUBLIC_SOURCE_ARCHIVE_SHA256", recipe) + def test_bioconda_recipe_avoids_unneeded_runtime_zlib(self): + recipe = (ROOT / "packaging" / "bioconda" / "meta.yaml").read_text() + + self.assertNotIn(" - zlib", recipe) + + def test_bioconda_build_script_uses_portable_install(self): + script = (ROOT / "packaging" / "bioconda" / "build.sh").read_text() + + self.assertIn('mkdir -p "${PREFIX}/share/${PKG_NAME}/schema"', script) + self.assertNotIn("install -D", script) + if __name__ == "__main__": unittest.main()