Skip to content

Fixer classes are wrongly scoped #24

@SystematicCZ

Description

@SystematicCZ

I have a problem with FinalClassFixer but I suspect there are more classes with issues. Essentialy not only class namespace is vendor scoped but also its config. So FinalClassInternalFixer has this as default exclude

   private const DEFAULTS = ['include' => ['internal'], 'exclude' => ['final', 'Entity', 'ECSPrefix202606\ORM\Entity', 'ECSPrefix202606\ORM\Mapping\Entity', 'ECSPrefix202606\Mapping\Entity', 'Document', 'ECSPrefix202606\ODM\Document']];

and thus FinalClassFixer tries to apply final on doctrine entities.

Reproducer here:https://github.com/SystematicCZ/ecs-bug

This is happening since version 13.1.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions