From ae88dd1c18684d000f2270e6aff3b1c3926219cf Mon Sep 17 00:00:00 2001
From: Roland Walker <walker@pobox.com>
Date: Sat, 11 Apr 2026 12:14:18 -0400
Subject: [PATCH] add SQLExecute sandbox test coverage

---
 test/pytests/test_sqlexecute.py | 38 +++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/test/pytests/test_sqlexecute.py b/test/pytests/test_sqlexecute.py
index e250b154..807dc3b7 100644
--- a/test/pytests/test_sqlexecute.py
+++ b/test/pytests/test_sqlexecute.py
@@ -813,6 +813,21 @@ def fake_connect_sandbox(self, conn):
     assert executor.connection_id is None
 
 
+def test_connect_reraises_non_sandbox_operational_error(monkeypatch) -> None:
+    executor = make_executor_for_connect_tests()
+    executor.ssl = None
+
+    def fake_connect(**_kwargs):
+        raise pymysql.OperationalError(1045, 'access denied')
+
+    monkeypatch.setattr(sqlexecute.pymysql, 'connect', fake_connect)
+
+    with pytest.raises(pymysql.OperationalError) as exc_info:
+        executor.connect()
+
+    assert exc_info.value.args == (1045, 'access denied')
+
+
 def test_connect_uses_ssh_tunnel_when_ssh_host_is_set(monkeypatch) -> None:
     executor = make_executor_for_connect_tests()
     executor.ssl = None
@@ -911,6 +926,29 @@ def start(self) -> None:
         executor.connect(ssh_host='bastion.internal')
 
 
+def test_connect_sandbox_temporarily_disables_set_character_set() -> None:
+    original_calls = []
+    connect_observed_stub = []
+
+    class FakeSandboxConnection:
+        def set_character_set(self, *args, **kwargs) -> None:
+            original_calls.append((args, kwargs))
+
+        def connect(self) -> None:
+            self.set_character_set('utf8mb4')
+            connect_observed_stub.append(original_calls == [])
+
+    conn = FakeSandboxConnection()
+    original_set_character_set = conn.set_character_set
+
+    SQLExecute._connect_sandbox(conn)
+
+    assert connect_observed_stub == [True]
+    assert conn.set_character_set == original_set_character_set
+    conn.set_character_set('latin1')
+    assert original_calls == [(('latin1',), {})]
+
+
 def test_run_returns_empty_result_for_blank_statement(monkeypatch) -> None:
     split_inputs: list[str] = []