Skip to content

Fix #245: Expanded configured log_file paths with os.path.expanduser()#254

Draft
dbcli-symphony[bot] wants to merge 1 commit into
mainfrom
symphony/dbcli-litecli-245-attempt-3
Draft

Fix #245: Expanded configured log_file paths with os.path.expanduser()#254
dbcli-symphony[bot] wants to merge 1 commit into
mainfrom
symphony/dbcli-litecli-245-attempt-3

Conversation

@dbcli-symphony
Copy link
Copy Markdown

Summary

  • Expanded configured log_file paths with os.path.expanduser() before directory creation/checking in litecli/main.py.
  • Added a regression test for log_file = ~/.cache/litecli/log with a temporary home directory in tests/test_main.py.

Issue

Fixes #245

Verification

  • python -m py_compile litecli/main.py tests/test_main.py passed.
  • ruff check litecli/main.py tests/test_main.py passed.
  • ruff format --check litecli/main.py tests/test_main.py passed.
  • git diff --check passed.
  • Could not run the focused pytest: pytest is not installed in the active Python. tox -e py also could not bootstrap because the sandbox has no network access to install uv. Remaining risk is only that the new pytest has not been executed in this environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Getting error 'Unable to open log file' when log file move to other directory other than default

0 participants