Skip to content

Deepen metric recording module#65

Merged
darthfork merged 1 commit into
mainfrom
deepen-metric-recording
May 21, 2026
Merged

Deepen metric recording module#65
darthfork merged 1 commit into
mainfrom
deepen-metric-recording

Conversation

@darthfork
Copy link
Copy Markdown
Owner

@darthfork darthfork commented May 21, 2026

Summary

  • add a metric recording Module that centralizes Prometheus collector writes for webhook dedupe, async processing, repository events, and run transitions
  • route webhook ingestion, async workers, push/pull_request handling, and run-transition recording through domain-level metric methods
  • keep existing collector definitions, metric names, label names, and label value ordering unchanged

TDD notes

  • RED: added metric recorder tests before the Module existed
  • GREEN: implemented the Prometheus metric recorder with exact existing label cardinality
  • REFACTOR: moved production collector mutations out of webhook/async/github/run-transition paths into the metric recorder

Cardinality guardrails

  • added tests for duplicate delivery metrics, repository event metrics, run metrics, and async metrics that assert the current label sets and label ordering
  • no Prometheus collector definitions in src/metrics.go were changed

@darthfork darthfork merged commit 74f36ae into main May 21, 2026
3 checks passed
@darthfork darthfork deleted the deepen-metric-recording branch May 21, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant