fixup! fixup! Fix #14826 valueflow: forward lifetimes through array and member subobjects

francois-berder · francois-berder · commit b220ddcd4eee · 2026-06-29T11:33:58.000+02:00
diff --git a/lib/valueflow.cpp b/lib/valueflow.cpp
@@ -2033,8 +2033,7 @@ static void valueFlowForwardLifetime(Token * tok, const TokenList &tokenlist, Er
                 if (val.lifetimeKind == ValueFlow::Value::LifetimeKind::Address)
                     val.lifetimeKind = ValueFlow::Value::LifetimeKind::SubObject;
             }
-            std::vector<const Token*> parents = getLhsLifetimeParents(parent->astOperand1(), settings.library);
-            for (const Token *p : parents)
+            for (const Token *p : getLhsLifetimeParents(parent->astOperand1(), settings.library))
                 valueFlowForward(nextExpression, endOfVarScope, p, values, tokenlist, errorLogger, settings);
         }
         // Constructor

Original file line number	Diff line number	Diff line change
`@@ -2033,8 +2033,7 @@ static void valueFlowForwardLifetime(Token * tok, const TokenList &tokenlist, Er`
`2033`	`2033`	`if (val.lifetimeKind == ValueFlow::Value::LifetimeKind::Address)`
`2034`	`2034`	`val.lifetimeKind = ValueFlow::Value::LifetimeKind::SubObject;`
`2035`	`2035`	`}`
`2036`		`- std::vector<const Token*> parents = getLhsLifetimeParents(parent->astOperand1(), settings.library);`
`2037`		`- for (const Token *p : parents)`
	`2036`	`+ for (const Token *p : getLhsLifetimeParents(parent->astOperand1(), settings.library))`
`2038`	`2037`	`valueFlowForward(nextExpression, endOfVarScope, p, values, tokenlist, errorLogger, settings);`
`2039`	`2038`	`}`
`2040`	`2039`	`// Constructor`