Fix #14850 (Compilation fails on oraclelinux:8 (g++ 8.5.0 released in 2021)) (#8654)

Author: danmar

lib/checks.h

@@ -29,6 +29,6 @@ namespace CheckInstances
 {
     /** List of registered check classes. This is used by Cppcheck to run checks and generate documentation */
     CPPCHECKLIB const std::list<Check *>& get();
-};
+}
 
 #endif // checksH

lib/settings.cpp

@@ -79,8 +79,8 @@ Settings::~Settings() = default;
 Settings::Settings(const Settings&) = default;
 Settings & Settings::operator=(const Settings &) = default;
 
-Settings::Settings(Settings&&) noexcept = default;
-Settings & Settings::operator=(Settings &&) noexcept = default;
+Settings::Settings(Settings&&) CPPCHECK_NOEXCEPT = default;
+Settings & Settings::operator=(Settings &&) CPPCHECK_NOEXCEPT = default;
 
 std::string Settings::loadCppcheckCfg(Settings& settings, Suppressions& suppressions, bool debug)
 {

lib/settings.h

@@ -94,6 +94,16 @@ class SimpleEnableGroup {
 };
 
 
+#if defined(__GNUC__) && !defined(__clang__) && __GNUC__ <= 9
+// Hack to workaround GCC bug.
+// Details: https://trac.cppcheck.net/ticket/14850
+// seen on g++ before 10.x
+#define  CPPCHECK_NOEXCEPT
+#else
+#define  CPPCHECK_NOEXCEPT  noexcept
+#endif
+
+
 /**
  * @brief This is just a container for general settings so that we don't need
  * to pass individual values to functions or constructors now or in the
@@ -113,8 +123,8 @@ class CPPCHECKLIB WARN_UNUSED Settings {
     Settings(const Settings&);
     Settings& operator=(const Settings&);
 
-    Settings(Settings&&) noexcept;
-    Settings& operator=(Settings&&) noexcept;
+    Settings(Settings&&) CPPCHECK_NOEXCEPT;
+    Settings& operator=(Settings&&) CPPCHECK_NOEXCEPT;
 
     static std::string loadCppcheckCfg(Settings& settings, Suppressions& suppressions, bool debug = false);