Warning written to log on every Database open regardless of status of File Log Sinks

[andrew-charles]

Every time I open a database, I get this log message, no matter what I have set for File based logging:

W Database.log.getFile().getConfig() is now null: logging is disabled. Log files required for product support are not being generated.

This message is outright wrong in this case, as it's not null, but apparently there's a bug in the code and no matter what you'll get this message:

private void warnIfNoFileLogSink() {
        final FileLogSink sink = fileLogSink;
        if ((sink != null) && (sink.getLevel() != LogLevel.NONE) && !warned.getAndSet(true)) { return; }
        ((AbstractLogSink) new ConsoleLogSink(LogLevel.WARNING, LogDomain.DATABASE)).writeLog(
            LogLevel.WARNING,
            LogDomain.DATABASE,
            "Database.log.getFile().getConfig() is now null: logging is disabled.  "
                + "Log files required for product support are not being generated.");
    }

I have several issues with this code besides this.

1. If I want to disable File based logging, I should be able to do it, and not get complaints about it. If there has to be a warning, it should be on init(), not every single time I attempt to open a DB. The older version of couchbase lite mobile (2.x) did not have this issue.
2. This code here creates an arbitrary console logger (which in android writes to Logcat), so there's no way to suppress it.

[JacobKingDev]

I'm also seeing this with both the new and legacy logging systems. I can see file logs in the directory I specified so the logging is working and this warning is erroneous.

This is absolutely chewing through my remote logging quota and polluting genuine logs with a load of noise, I'd really appreciate a fix.

[borrrden]

Absolutely, the intent was to have it only show once, or at least only when you disable it. The issue with not having the warning is that this is one of the only ways that we have to get any information for bug reports, and we can't enable it by default due to European privacy laws. Sorry that no one has been monitoring this repo, I filed CBL-7777 to track this.