Missing exit code added in unit test cases

Author: antonyagustine

test/unit/commands/app/create.test.ts

@@ -206,9 +206,10 @@ describe("app:create", () => {
           .reply(200, { organizations: mock.organizations })
       )
       .command(["app:create", "--data-dir", process.cwd()])
-      .do(({ stdout }) =>
-        expect(stdout).to.contain(messages.FILE_GENERATION_FAILURE)
-      )
+      .exit(1)
+      .do(({ stdout }) => {
+        expect(stdout).to.includes(messages.FILE_GENERATION_FAILURE);
+      })
       .it("Boilerplate clone exits with status code 1");
   });
 
@@ -236,6 +237,7 @@ describe("app:create", () => {
         api.post("/manifests", { ...manifestData, name: "test-app" }).reply(400)
       )
       .command(["app:create", "--data-dir", process.cwd()])
+      .exit(1)
       .do(({ stdout }) =>
         expect(stdout).to.contain(messages.APP_CREATION_CONSTRAINT_FAILURE)
       )
@@ -272,6 +274,7 @@ describe("app:create", () => {
         "--config",
         resolve(process.cwd(), "test", "unit", "mock", "config.json"),
       ])
+      .exit(1)
       .do(({ stdout }) =>
         expect(stdout).to.contain(messages.APP_CREATION_CONSTRAINT_FAILURE)
       )
@@ -320,6 +323,7 @@ describe("app:create", () => {
           })
       )
       .command(["app:create", "--data-dir", process.cwd()])
+      .exit(1)
       .do(({ stdout }) =>
         expect(stdout).to.contain("Dependency installation failed.!")
       )

test/unit/commands/app/update.test.ts

@@ -121,6 +121,7 @@ describe("app:update", () => {
           .reply(200, { organizations: mock.organizations })
       )
       .command(["app:update"])
+      .exit(1)
       .do(({ stdout }) => expect(stdout).to.contain(messages.MAX_RETRY_LIMIT))
       .it("should fail with manifest max retry message");
   });
@@ -150,6 +151,7 @@ describe("app:update", () => {
         "--app-manifest",
         join(process.cwd(), "test", "unit", "config", "manifest.json"),
       ])
+      .exit(1)
       .do(({ stdout }) => expect(stdout).to.contain(messages.MAX_RETRY_LIMIT))
       .it("should fail with max retry message");
   });
@@ -184,6 +186,7 @@ describe("app:update", () => {
         "--app-manifest",
         join(process.cwd(), "test", "unit", "config", "manifest.json"),
       ])
+      .exit(1)
       .do(({ stdout }) =>
         expect(stdout).to.contain(messages.APP_VERSION_MISS_MATCH)
       )
@@ -225,6 +228,7 @@ describe("app:update", () => {
         "--app-manifest",
         join(process.cwd(), "test", "unit", "config", "manifest.json"),
       ])
+      .exit(1)
       .do(({ stdout }) => expect(stdout).to.contain(messages.INVALID_APP_ID))
       .it("update app should fail with 400 status code");
   });
@@ -264,6 +268,7 @@ describe("app:update", () => {
         "--app-manifest",
         join(process.cwd(), "test", "unit", "config", "manifest.json"),
       ])
+      .exit(1)
       .do(({ stdout }) => expect(stdout).to.contain(messages.APP_INVALID_ORG))
       .it("update app should fail with 403 status code");
   });