[pull] canary from vercel:canary#1054
Merged
Merged
Conversation
Adapters implementing `modifyConfig` may need to know the absolute project directory to perform path resolution or apply directory-specific configuration logic. Without this value, adapters had no reliable way to determine where the application lives on disk. onBuildComplete already received the directory as a parameter.
### What? When instant validation flags a route that can't load instantly, the overlay shows a warning. This PR (1) distinguishes nav-phase warnings from initial-render ones in the overlay text, and (2) clears the nav-phase warnings on route change so they don't accumulate after the user has moved on. ### Why? The redbox previously couldn't tell whether a route's instant warning was raised while rendering it directly or while navigating into it — the text and stack looked the same. And once one was surfaced, it stuck around even after the user navigated elsewhere, where it was no longer actionable. The two changes together make each warning describe the phase that produced it and only stay visible while it's still relevant. ### Demo - Subnav under Suspense: [cookies](https://error-messages-overhaul-ibsl.labs.vercel.dev/scenario/41-subnav-cookies) · [fetch](https://error-messages-overhaul-ibsl.labs.vercel.dev/scenario/42-subnav-fetch) ### How - New in-navigation variants of the body factory messages ("during the initial render or a navigation") let the overlay tell nav warnings apart from initial-render ones. The diagnostic clause stays aligned ("accessed outside of \`<Suspense>\`"); only the phase and consequence change. - The overlay reads the phase off the message, picks a matching headline, and on route change drops nav warnings while keeping initial-render errors in the redbox stack. - Renames the \`GuidanceVariant\` value (\`'navigation' → 'dynamic'\`) that collided with the new in-nav phase concept. --------- Co-authored-by: Cursor <cursoragent@cursor.com>
Move next.config evaluation inside the try catch where we import and transform it This ensures we print an appropriate help link if the export function throws
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )