Skip to content

Fix .env extesions in yaml#104

Merged
heliocodacy merged 1 commit intomasterfrom
add_dotenv_to_yaml
Mar 9, 2026
Merged

Fix .env extesions in yaml#104
heliocodacy merged 1 commit intomasterfrom
add_dotenv_to_yaml

Conversation

@heliocodacy
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings March 9, 2026 13:26
@codacy-production
Copy link

codacy-production bot commented Mar 9, 2026

Codacy's Analysis Summary

0 new issue (≤ 1 medium issue)
0 new security issue (≤ 0 issue)
0 complexity
0 duplications
More details

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes. Give us feedback

DMarinhoCodacy
DMarinhoCodacy previously approved these changes Mar 9, 2026
Copy link

@codacy-production codacy-production bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

While this PR correctly identifies the need to distinguish between YAML extensions and specific environment filenames, the implementation contains technical inconsistencies. The YAML language definition uses a List for extensions, whereas all other languages in this file utilize a Set. Furthermore, '.env' is redundantly listed in both collections. Although Codacy analysis reports the code is up to standards, these consistency issues and the lack of a PR description or Jira ticket should be addressed to maintain code quality and traceability.

About this PR

  • The definition for YAML uses a 'List' for the extensions parameter, which is inconsistent with the 'Set' used for all other language definitions in this file (e.g., Elixir, Kotlin, Terraform).
  • The PR lacks a description and a Jira ticket link, providing no context for why these specific changes or file additions are necessary.

Suggestions for missing tests

  • Verify that a file named 'config.yaml' is identified as YAML via the extensions list.
  • Verify that a file named '.env.production' is identified as YAML via the files set.
  • Verify that a file named '.env' is identified correctly as it appears in both extensions and files.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that a file named 'config.yaml' is identified as YAML via the extensions list.
2. Verify that a file named '.env.production' is identified as YAML via the files set.
3. Verify that a file named '.env' is identified correctly as it appears in both extensions and files.

🗒️ Improve review quality by adding custom instructions

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts how YAML-related files are recognized, specifically separating dotenv-style files (e.g., .env.production) from true YAML extensions, and updates .gitignore entries.

Changes:

  • Refactor YAML language definition to treat .env.* entries as filename matches instead of extensions.
  • Fix .vscode/ ignore pattern formatting and add an ignore entry for a Copilot/AI instructions file path.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

File Description
codacy-plugins-api/src/main/scala/com/codacy/plugins/api/languages/Language.scala Updates YAML language configuration by splitting dotenv-related matches into files.
.gitignore Fixes .vscode/ ignore rule formatting and adds an ignore rule for .github/instructions/codacy.instructions.md.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@heliocodacy heliocodacy merged commit 8dfeb32 into master Mar 9, 2026
3 checks passed
@heliocodacy heliocodacy deleted the add_dotenv_to_yaml branch March 9, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants