From a1f7d2b7d45c9481dc250434ab3f3cdfecb74ea4 Mon Sep 17 00:00:00 2001 From: Review Date: Mon, 1 Jun 2026 10:53:57 +0000 Subject: [PATCH] ci: keep Notes app compatible across the stable31/32/33 matrix Notes 'main' (v5.0.0) raised its min-version to Nextcloud 33, so 'occ app:enable notes' fails on the stable31 (Client) and stable32 (Maria) CI jobs at the 'Enable Notes' step, turning every PR red regardless of its contents. nextcloud/notes has no server-matched stable branches, so select the ref by server version: NC31/NC32 use tag v4.13.1 (supports NC 28-34), while NC33 and newer keep 'main' to exercise the latest Notes. --- .github/workflows/analysis-coverage.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/analysis-coverage.yml b/.github/workflows/analysis-coverage.yml index c6bf9a4c..b85708b8 100644 --- a/.github/workflows/analysis-coverage.yml +++ b/.github/workflows/analysis-coverage.yml @@ -203,7 +203,8 @@ jobs: uses: actions/checkout@v6 with: repository: nextcloud/notes - ref: "main" + # Notes main (v5.0.0) requires NC >= 33; pin older servers to the last 4.x (supports NC 28-34). + ref: "${{ (matrix.nextcloud == 'stable31' || matrix.nextcloud == 'stable32') && 'v4.13.1' || 'main' }}" path: apps/notes - name: Checkout Files Locking @@ -548,7 +549,8 @@ jobs: uses: actions/checkout@v6 with: repository: nextcloud/notes - ref: "main" + # Notes main (v5.0.0) requires NC >= 33; pin older servers to the last 4.x (supports NC 28-34). + ref: "${{ (matrix.nextcloud == 'stable31' || matrix.nextcloud == 'stable32') && 'v4.13.1' || 'main' }}" path: apps/notes - name: Checkout Files Locking