chore(shared): Remove internal tag from publicly re-exported error helpers#8598
chore(shared): Remove internal tag from publicly re-exported error helpers#8598wobsoriano wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: b6100be The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis PR removes the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
jacekradko
left a comment
There was a problem hiding this comment.
Makes sense for these not to be internal
Description
@internalJSDoc tag from error helpers in@clerk/sharedthat are explicitly re-exported for public use by SDK packages (isKnownError,isReverificationCancelledError,isMetamaskError,isUserLockedError,isEmailLinkError)@internaltagThe
@internaltag was originally applied because these helpers live in@clerk/shared, which users shouldn't import from directly. However, since they are explicitly re-exported from the SDK packages, the tag was misleading.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change