Skip to content

Commit 4fbba27

Browse files
authored
Merge pull request #74 from shivam5643/fix-workflow-2
Github workflow
2 parents 6d04042 + 2d681b2 commit 4fbba27

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

.github/workflows/reviewing_changes.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,10 @@ jobs:
1919
strategy:
2020
fail-fast: false
2121
max-parallel: 3
22+
# Node 14 not supported on macOS: No arm64 binary for Node 14.
23+
# Ubuntu + Node 14 & Windows + Node 14: Syntax error (||= operator) in transitive dependency. Latest browserstack-node-sdk pulls packages incompatible with Node 14.
2224
matrix:
23-
node: ['14', '16', '18', '20']
25+
node: ['16', '18', '20', "24"]
2426
os: [ macos-latest, windows-latest, ubuntu-latest ]
2527
name: Cucumber-js Repo ${{ matrix.node }} - ${{ matrix.os }} Sample
2628
env:
@@ -89,8 +91,8 @@ jobs:
8991
npm publish staging_package.tgz --registry http://localhost:4873/
9092
shell: bash
9193

92-
- name: Install dependencies
93-
run: npm install
94+
- name: Install dependencies (Node 16+)
95+
run: npm ci
9496

9597
- name: Run sample tests
9698
run: npm run sample-test

0 commit comments

Comments
 (0)