From eeb116ec9e1bd203eb141e358432268118fcdf73 Mon Sep 17 00:00:00 2001 From: box-sdk-build Date: Fri, 10 Apr 2026 04:15:13 -0700 Subject: [PATCH] fix: Fix error propagation in Java (box/box-codegen#936) --- .codegen.json | 2 +- docs/sdkgen/authentication.md | 5 +++-- .../sdkgen/networking/boxnetworkclient/BoxNetworkClient.java | 2 ++ .../defaultnetworkclient/DefaultNetworkClient.java | 4 +--- 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.codegen.json b/.codegen.json index 1f695ebfa..938c46fc8 100644 --- a/.codegen.json +++ b/.codegen.json @@ -1 +1 @@ -{ "engineHash": "acae1d5", "specHash": "f8e0d99", "version": "5.6.0" } +{ "engineHash": "51c2138", "specHash": "f8e0d99", "version": "5.6.0" } diff --git a/docs/sdkgen/authentication.md b/docs/sdkgen/authentication.md index a8fdf1ec0..b76335410 100644 --- a/docs/sdkgen/authentication.md +++ b/docs/sdkgen/authentication.md @@ -215,8 +215,9 @@ browser or web view) in order to obtain an auth code. ```java -BoxOAuth oauth = new OAuthConfig("CLIENT_ID", "CLIENT_SECRET"); -String authorizationUrl = auoauthth.getAuthorizeUrl(); +OAuthConfig oauthConfig = new OAuthConfig("CLIENT_ID", "CLIENT_SECRET"); +BoxOAuth oauth = new BoxOAuth(oauthConfig); +String authorizationUrl = oauth.getAuthorizeUrl(); ``` After a user logs in and grants your application access to their Box account, diff --git a/src/main/java/com/box/sdkgen/networking/boxnetworkclient/BoxNetworkClient.java b/src/main/java/com/box/sdkgen/networking/boxnetworkclient/BoxNetworkClient.java index a63c8b1d2..80a4c0ff6 100644 --- a/src/main/java/com/box/sdkgen/networking/boxnetworkclient/BoxNetworkClient.java +++ b/src/main/java/com/box/sdkgen/networking/boxnetworkclient/BoxNetworkClient.java @@ -196,6 +196,8 @@ public FetchResponse fetch(FetchOptions options) { exceptionThrown = e; numberOfRetriesOnException++; attemptForRetry = numberOfRetriesOnException; + fetchResponse = new FetchResponse.Builder(0, new TreeMap<>()).build(); + rawResponseBody = null; if (response != null) { response.close(); } diff --git a/src/main/java/com/box/sdkgen/networking/defaultnetworkclient/DefaultNetworkClient.java b/src/main/java/com/box/sdkgen/networking/defaultnetworkclient/DefaultNetworkClient.java index 28ea71f70..f8bba1237 100644 --- a/src/main/java/com/box/sdkgen/networking/defaultnetworkclient/DefaultNetworkClient.java +++ b/src/main/java/com/box/sdkgen/networking/defaultnetworkclient/DefaultNetworkClient.java @@ -113,12 +113,10 @@ public FetchResponse fetch(FetchOptions options) { exceptionThrown = e; numberOfRetriesOnException++; attemptForRetry = numberOfRetriesOnException; + fetchResponse = new FetchResponse.Builder(0, new TreeMap<>()).build(); if (response != null) { response.close(); } - - fetchResponse = - new FetchResponse.Builder(0, new TreeMap<>(String.CASE_INSENSITIVE_ORDER)).build(); } shouldRetry =