Warning on NetworkSettings normalizer

[rodrigoaguilera]

I am getting

<warning>PHP Warning:  foreach() argument must be of type array|object, null given in /vendor/beluga-php/docker-php-api/src/Normalizer/NetworkSettingsNormalizer.php on line 73</warning>

Calling containerInspect() for a container that has ports exposed on the image but no binding so the output of CLI docker inspect is

...
"NetworkSettings": {
            "Bridge": "",
            "SandboxID": "2b1a12bda80af0896525136538f1495c0097ae592134a387fa0ea3173804c1d3",
            "HairpinMode": false,
            "LinkLocalIPv6Address": "",
            "LinkLocalIPv6PrefixLen": 0,
            "Ports": {
                "9000/tcp": null
            },
...

I guess the daemon used to return an array for the port bindings instead of null.
I am using Docker Server Version: 20.10.5.

[rodrigoaguilera]

I think the code generated doesn't take into account that the items inside a PortMap are nullable
https://github.com/beluga-php/docker-php-api/blob/main/spec/v1.41.json#L11916

[flavioheleno]

Hi @rodrigoaguilera, could you kindly provide a simple script to reproduce the issue?

[rodrigoaguilera]

Sure.
Run this in directory where you have the php docker client installed with composer:

docker run --rm --detach --name=test wodby/drupal-php:8.0-4.27.3
php -r "include 'vendor/autoload.php'; \Docker\Docker::create()->containerInspect('test');"

That drupal-php image exposes the port 9000

[flavioheleno]

Got to reproduce the issue here. You are right, the generator does not properly handle PortMap being nullable (likely to happen somewhere else too).

I've fiddled with the configuration options and even bumping JanePHP to 7.x, but without any success.

The fix is rather simple if we do it in the generated code, but that would be non-practical moving forward without a "patching" process in place to keep track of those changes.

I'll do some more digging and figure out why the generated code isn't right and maybe propose a fix to JanePHP if that's the case.

[Rid]

I have reported this here: janephp/janephp#559

[flavioheleno]

Sorry for the very late response to this, but I'm trying to fix is in JanePHP (janephp/janephp#597) :)

PS: Dealing with Jane code base is not at all easy. phew!