From bb1003ecb45e171ecdbdfb01c9a91b969139c44a Mon Sep 17 00:00:00 2001 From: Vlada Dusek Date: Wed, 22 Apr 2026 09:44:32 +0200 Subject: [PATCH] fix: remove dead duplicate urlparse in async create_keys_public_url The first urlparse call was unconditionally overwritten by a second call with public=True. Drop it so async mirrors the sync version and so nobody gets tripped up by the non-public URL being silently shadowed. Co-Authored-By: Claude Opus 4.7 (1M context) --- src/apify_client/_resource_clients/key_value_store.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/apify_client/_resource_clients/key_value_store.py b/src/apify_client/_resource_clients/key_value_store.py index 144af733..2c099bca 100644 --- a/src/apify_client/_resource_clients/key_value_store.py +++ b/src/apify_client/_resource_clients/key_value_store.py @@ -906,8 +906,6 @@ async def create_keys_public_url( """ metadata = await self.get(timeout=timeout) - keys_public_url = urlparse(self._build_url('keys')) - request_params = self._build_params( limit=limit, exclusiveStartKey=exclusive_start_key, @@ -924,6 +922,7 @@ async def create_keys_public_url( request_params['signature'] = signature keys_public_url = urlparse(self._build_url('keys', public=True)) + filtered_params = {k: v for k, v in request_params.items() if v is not None} if filtered_params: keys_public_url = keys_public_url._replace(query=urlencode(filtered_params))