HDDS-15449. Avoid leaked event-processing thread and async work outliving tests in TestReconTaskControllerImpl#10452
Merged
Merged
Conversation
…ving tests in TestReconTaskControllerImpl
Contributor
Author
|
Hi @chihsuan, You originally spotted this issue, so I’d appreciate it if you could take a look and review this patch. |
chihsuan
approved these changes
Jun 6, 2026
| } catch (Exception e) { | ||
| return false; | ||
| } | ||
| }, 100, 5000); |
Contributor
There was a problem hiding this comment.
nit: This waitFor block is duplicated verbatim in testConsumeOMEvents and testFailedTaskRetryLogic. We can consider extracting a small helper.
Not a blocker, happy to merge as is.
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing this out. I agree a helper could clean this up, but I’ll keep it as-is for this patch since the duplication is small and the current form keeps the wait condition explicit.
Contributor
Author
|
Thanks @chihsuan for the review. |
Gargi-jais11
approved these changes
Jun 8, 2026
Gargi-jais11
left a comment
Gargi-jais11
left a comment
Contributor
There was a problem hiding this comment.
Thanks @Russole for the patch. LGTM!
Contributor
Author
|
Thanks @Gargi-jais11 for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
TestReconTaskControllerImplto stop the task controller after each test.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15449
How was this patch tested?