From 2dab3dada2705fb662e00658e1425db4797ce74a Mon Sep 17 00:00:00 2001 From: Kevin Liu Date: Fri, 1 May 2026 15:02:18 -0700 Subject: [PATCH 1/2] fix 3.13 hang during test Co-authored-by: Copilot --- tests/catalog/test_hive.py | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/tests/catalog/test_hive.py b/tests/catalog/test_hive.py index a8c0c943da..efe619c456 100644 --- a/tests/catalog/test_hive.py +++ b/tests/catalog/test_hive.py @@ -226,7 +226,7 @@ def run(self) -> None: client.write(self._response) client.flush() except Exception: - pass + break @property def port(self) -> int | None: @@ -234,13 +234,10 @@ def port(self) -> int | None: return self._port def close(self) -> None: - # Close all client connections first - for client in self._clients: - try: - client.close() - except Exception: - pass self._socket.close() + self.join(timeout=5) + for client in self._clients: + client.close() @pytest.fixture(scope="session") From b56fb1df9b396a71679e471d7c52bf34db19b1cf Mon Sep 17 00:00:00 2001 From: Kevin Liu Date: Sat, 2 May 2026 10:15:08 -0700 Subject: [PATCH 2/2] add try/catch --- tests/catalog/test_hive.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/catalog/test_hive.py b/tests/catalog/test_hive.py index efe619c456..4bfe2122b7 100644 --- a/tests/catalog/test_hive.py +++ b/tests/catalog/test_hive.py @@ -234,10 +234,16 @@ def port(self) -> int | None: return self._port def close(self) -> None: - self._socket.close() + try: + self._socket.close() + except Exception: + pass self.join(timeout=5) for client in self._clients: - client.close() + try: + client.close() + except Exception: + pass @pytest.fixture(scope="session")