Skip to content

Commit ac19783

Browse files
committed
x
1 parent 7988561 commit ac19783

File tree

9 files changed

+536
-605
lines changed

9 files changed

+536
-605
lines changed

packages/angular/ssr/test/app_spec.ts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -309,17 +309,6 @@ describe('AngularServerApp', () => {
309309
expect(await conditionalResponse?.text()).toBe('');
310310
});
311311

312-
it('should return configured headers for pages with specific header settings', async () => {
313-
const response = await app.handle(new Request('http://localhost/home-ssg'));
314-
const headers = response?.headers.entries() ?? [];
315-
expect(Object.fromEntries(headers)).toEqual({
316-
'etag': '"f799132d0a09e0fef93c68a12e443527700eb59e6f67fcb7854c3a60ff082fde"',
317-
'content-length': '28',
318-
'x-some-header': 'value',
319-
'content-type': 'text/html;charset=UTF-8',
320-
});
321-
});
322-
323312
it('should return null for a non-prerendered page', async () => {
324313
const response = await app.handle(new Request('http://localhost/unknown'));
325314
expect(response).toBeNull();

packages/angular_devkit/architect/src/api_spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ describe('Architect API', () => {
4040
for (const ts of Object.getOwnPropertyNames(goldens)) {
4141
const t: Target = goldens[ts];
4242

43-
it(`works for ${JSON.stringify(t)}`, () => {
43+
it(`works for ${JSON.stringify(ts)}`, () => {
4444
// We have some invalid goldens. Remove everything after the second :.
4545
const goldenTs = ts.replace(/(\w+:\w+(:\w*)?).*/, '$1');
4646
expect(targetStringFromTarget(t)).toEqual(goldenTs);

packages/angular_devkit/build_angular/src/builders/browser/specs/tsconfig-paths_spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ describe('Browser Builder tsconfig paths', () => {
1919
});
2020
afterEach(async () => host.restore().toPromise());
2121

22-
it('works', async () => {
22+
it('should resolve basic tsconfig paths', async () => {
2323
host.replaceInFile('src/app/app.module.ts', './app.component', '@root/app/app.component');
2424
host.replaceInFile(
2525
'tsconfig.json',
@@ -37,7 +37,7 @@ describe('Browser Builder tsconfig paths', () => {
3737
await browserBuild(architect, host, target);
3838
});
3939

40-
it('works', async () => {
40+
it('should resolve complex tsconfig paths with wildcards', async () => {
4141
host.writeMultipleFiles({
4242
'src/meaning-too.ts': 'export var meaning = 42;',
4343
'src/app/shared/meaning.ts': 'export var meaning = 42;',

packages/angular_devkit/core/src/virtual-fs/path_spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,9 @@ describe('path', () => {
9696
for (const [input, result] of tests) {
9797
const normalizedInput = normalize(input);
9898

99-
it(`(${JSON.stringify(normalizedInput)}) == "${result}"`, () => {
100-
expect(split(normalizedInput)).toEqual(result as PathFragment[]);
101-
});
99+
expect(split(normalizedInput))
100+
.withContext(`Input: "${input}"`)
101+
.toEqual(result as PathFragment[]);
102102
}
103103
});
104104

0 commit comments

Comments
 (0)