fixup! feat(@schematics/angular): migrate fake async to Vitest fake timers

Author: yjaaidi

packages/schematics/angular/refactor/jasmine-vitest/transformers/fake-async-tick.ts

@@ -33,9 +33,7 @@ export function transformFakeAsyncTick(node: ts.Node, ctx: RefactorContext): ts.
   addImportSpecifierRemoval(ctx, 'tick', ANGULAR_CORE_TESTING);
 
   const durationNumericLiteral =
-    node.arguments.length > 0 && ts.isNumericLiteral(node.arguments[0])
-      ? node.arguments[0]
-      : ts.factory.createNumericLiteral(0);
+    node.arguments.length > 0 ? node.arguments[0] : ts.factory.createNumericLiteral(0);
 
   return ts.factory.createAwaitExpression(
     createViCallExpression(ctx, 'advanceTimersByTimeAsync', [durationNumericLiteral]),

packages/schematics/angular/refactor/jasmine-vitest/transformers/fake-async-tick_spec.ts

@@ -19,12 +19,24 @@ describe('transformFakeAsyncTick', () => {
         `,
       expected: `await vi.advanceTimersByTimeAsync(100);`,
     },
+    {
+      description:
+        'should replace `tick` with `vi.advanceTimersByTimeAsync` even if it using a non-literal argument',
+      input: `
+          import { tick } from '@angular/core/testing';
+
+          const duration = 100;
+          tick(duration);
+        `,
+      expected: `await vi.advanceTimersByTimeAsync(100);`,
+    },
     {
       description: 'should replace `tick()` with `vi.advanceTimersByTimeAsync(0)`',
       input: `
           import { tick } from '@angular/core/testing';
           
-          tick();
+          const duration = 0;
+          tick(duration);
         `,
       expected: `await vi.advanceTimersByTimeAsync(0);`,
     },