From 1c76e0f776f3b88f7d410b6af838d1daaeb153aa Mon Sep 17 00:00:00 2001 From: GautamMKGarg Date: Tue, 3 Mar 2026 00:29:47 +0530 Subject: [PATCH 1/4] Add property_exists check for object field access Add property_exists check before accessing field. Fixed warning in PHP. ``` PHP Warning: Undefined property: stdClass::$plugin in \wp-includes\class-wp-list-util.php on line 168 ``` --- src/wp-includes/class-wp-list-util.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/wp-includes/class-wp-list-util.php b/src/wp-includes/class-wp-list-util.php index 656035529186e..c7506d154c006 100644 --- a/src/wp-includes/class-wp-list-util.php +++ b/src/wp-includes/class-wp-list-util.php @@ -165,7 +165,9 @@ public function pluck( $field, $index_key = null ) { */ foreach ( $this->output as $key => $value ) { if ( is_object( $value ) ) { - $newlist[ $key ] = $value->$field; + if ( property_exists( $value, $field ) ){ + $newlist[ $key ] = $value->$field; + } } elseif ( is_array( $value ) ) { $newlist[ $key ] = $value[ $field ]; } else { From 9c4ece0b57c19b42a5ef4f4e917a9df78659eefd Mon Sep 17 00:00:00 2001 From: GautamMKGarg Date: Tue, 3 Mar 2026 00:55:00 +0530 Subject: [PATCH 2/4] Formatting fixed Formatting fixed. --- src/wp-includes/class-wp-list-util.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wp-includes/class-wp-list-util.php b/src/wp-includes/class-wp-list-util.php index c7506d154c006..12416735ad9e8 100644 --- a/src/wp-includes/class-wp-list-util.php +++ b/src/wp-includes/class-wp-list-util.php @@ -165,7 +165,7 @@ public function pluck( $field, $index_key = null ) { */ foreach ( $this->output as $key => $value ) { if ( is_object( $value ) ) { - if ( property_exists( $value, $field ) ){ + if ( property_exists( $value, $field ) ) { $newlist[ $key ] = $value->$field; } } elseif ( is_array( $value ) ) { From 91716f77cb3226721f508341c7cf6ab949e98d80 Mon Sep 17 00:00:00 2001 From: GautamMKGarg Date: Tue, 3 Mar 2026 13:14:03 +0530 Subject: [PATCH 3/4] Apply suggestion from @westonruter Co-authored-by: Weston Ruter --- src/wp-includes/class-wp-list-util.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/wp-includes/class-wp-list-util.php b/src/wp-includes/class-wp-list-util.php index 12416735ad9e8..966deb3dca169 100644 --- a/src/wp-includes/class-wp-list-util.php +++ b/src/wp-includes/class-wp-list-util.php @@ -165,9 +165,7 @@ public function pluck( $field, $index_key = null ) { */ foreach ( $this->output as $key => $value ) { if ( is_object( $value ) ) { - if ( property_exists( $value, $field ) ) { - $newlist[ $key ] = $value->$field; - } + $newlist[ $key ] = $value->$field ?? null; } elseif ( is_array( $value ) ) { $newlist[ $key ] = $value[ $field ]; } else { From 31a638613ca0cc79ff9beb674cc9130969d7f193 Mon Sep 17 00:00:00 2001 From: GautamMKGarg Date: Tue, 3 Mar 2026 13:14:16 +0530 Subject: [PATCH 4/4] Apply suggestion from @westonruter Co-authored-by: Weston Ruter --- src/wp-includes/class-wp-list-util.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wp-includes/class-wp-list-util.php b/src/wp-includes/class-wp-list-util.php index 966deb3dca169..cbc9685560eef 100644 --- a/src/wp-includes/class-wp-list-util.php +++ b/src/wp-includes/class-wp-list-util.php @@ -167,7 +167,7 @@ public function pluck( $field, $index_key = null ) { if ( is_object( $value ) ) { $newlist[ $key ] = $value->$field ?? null; } elseif ( is_array( $value ) ) { - $newlist[ $key ] = $value[ $field ]; + $newlist[ $key ] = $value[ $field ] ?? null; } else { _doing_it_wrong( __METHOD__,