From e17e300c19c13612172eaf27f0c40e96425c1695 Mon Sep 17 00:00:00 2001 From: Pratik Nawkar Date: Fri, 27 Feb 2026 17:14:31 +0530 Subject: [PATCH 1/4] Keep errorMessage assignment for use with wp.a11y.speak() --- src/js/_enqueues/admin/common.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/js/_enqueues/admin/common.js b/src/js/_enqueues/admin/common.js index 358948d306cf6..8a3ee7e249b6e 100644 --- a/src/js/_enqueues/admin/common.js +++ b/src/js/_enqueues/admin/common.js @@ -1352,9 +1352,11 @@ $( function() { var errorMessage = __( 'Please select at least one item to perform this action on.' ); addAdminNotice( { - id: 'no-items-selected', + id: value !== '-1' ? 'no-items-selected' : 'no-bulk-action-selected', type: 'error', - message: errorMessage, + message: value !== '-1' + ? __( 'Please select at least one item to perform this action on.' ) + : __( 'Please select a bulk action before clicking Apply.' ), dismissible: true, } ); From 80738e7640877ec54bf79e9e927970b713b5c200 Mon Sep 17 00:00:00 2001 From: Pratik Nawkar Date: Fri, 27 Feb 2026 17:35:20 +0530 Subject: [PATCH 2/4] Fix bulk action validation notice and a11y announcement --- src/js/_enqueues/admin/common.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/js/_enqueues/admin/common.js b/src/js/_enqueues/admin/common.js index 8a3ee7e249b6e..7ea10f61b06db 100644 --- a/src/js/_enqueues/admin/common.js +++ b/src/js/_enqueues/admin/common.js @@ -1350,13 +1350,13 @@ $( function() { event.stopPropagation(); $( 'html, body' ).animate( { scrollTop: 0 } ); - var errorMessage = __( 'Please select at least one item to perform this action on.' ); + var errorMessage = value !== '-1' + ? __( 'Please select at least one item to perform this action on.' ) + : __( 'Please select a bulk action before clicking Apply.' ); addAdminNotice( { id: value !== '-1' ? 'no-items-selected' : 'no-bulk-action-selected', type: 'error', - message: value !== '-1' - ? __( 'Please select at least one item to perform this action on.' ) - : __( 'Please select a bulk action before clicking Apply.' ), + message: errorMessage, dismissible: true, } ); From b16233d3410bb625a883d195607fd2bdebe45a7e Mon Sep 17 00:00:00 2001 From: Pratik Nawkar Date: Fri, 27 Feb 2026 17:55:43 +0530 Subject: [PATCH 3/4] Fix ternary operator line break for ESLint --- src/js/_enqueues/admin/common.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/js/_enqueues/admin/common.js b/src/js/_enqueues/admin/common.js index 7ea10f61b06db..a997846810caa 100644 --- a/src/js/_enqueues/admin/common.js +++ b/src/js/_enqueues/admin/common.js @@ -1350,9 +1350,9 @@ $( function() { event.stopPropagation(); $( 'html, body' ).animate( { scrollTop: 0 } ); - var errorMessage = value !== '-1' - ? __( 'Please select at least one item to perform this action on.' ) - : __( 'Please select a bulk action before clicking Apply.' ); + var errorMessage = value !== '-1' ? + __( 'Please select at least one item to perform this action on.' ) : + __( 'Please select a bulk action before clicking Apply.' ); addAdminNotice( { id: value !== '-1' ? 'no-items-selected' : 'no-bulk-action-selected', type: 'error', From fd3babbaf5ab7f901fa79e007e31c567c5b3f090 Mon Sep 17 00:00:00 2001 From: Pratik Nawkar Date: Fri, 27 Feb 2026 23:37:01 +0530 Subject: [PATCH 4/4] Simplify bulk action error message --- src/js/_enqueues/admin/common.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/_enqueues/admin/common.js b/src/js/_enqueues/admin/common.js index a997846810caa..2a7daba0d2dc4 100644 --- a/src/js/_enqueues/admin/common.js +++ b/src/js/_enqueues/admin/common.js @@ -1352,7 +1352,7 @@ $( function() { var errorMessage = value !== '-1' ? __( 'Please select at least one item to perform this action on.' ) : - __( 'Please select a bulk action before clicking Apply.' ); + __( 'Please select a bulk action to perform.' ); addAdminNotice( { id: value !== '-1' ? 'no-items-selected' : 'no-bulk-action-selected', type: 'error',