Actual selection range does not reflect visual selection in Linear View when selection ends in defined data region

[galenbwill]

(Resubmitted and revised by @galenbwill for user chris123 on public slack)

Binary Ninja Version
2.4.3044-dev

Describe the bug
The binary contains a defined string:

char encryptedFlag[0x1a] = "\xd0\xc05O\x0c\xd9#*HK\t\x0bT<\xf8\xc0\xe5\xdf\xd7y\x0f=\xdb5\xc4", 0

So a mix of \xXX and normal chars.
In this case selecting the entire string , right click, copy as, raw hex only copies: "d0c0" so it ends once it encounters the not escaped O. the first two bytes of the selection.
The exact same happens when RC4 decrypting, it only decrypts the first two bytes by selecting it all, right click, transformation, RC4.
A workaround is to temporarily undefine the variable, copy/rc4 and redefine it.

Clarification: The behavior is actually to copy the entire selection, except only the first two bytes of the last line of the selection.

Expected behavior
The entire data gets copied and either decrypted or copied as raw data. Basically the output of binascii.hexlify(bv.read(here, 0x1a)) is expected. (which in the above example would be d0c0354f0cd9232a484b090b543cf8c0e5dfd7790f3ddb35c400)

Version and Platform (required):

• Binary Ninja: Dev 2.4.3044
• OS: Windows
• Version 10

[galenbwill]

This is a consequence of an issue with selection selection range in defined data regions in Linear View: whenever the end of a selection falls within a defined data region, the end of the selection will include the first two bytes of the line at the end of the selection.

Copy As and Transform are behaving correctly: they are obeying the current selection (as can be confirmed using the current_selection variable in the python console.

The workaround is to either switch to Hex view (default shortcut: H), make the correct selection and do Copy As / Transform there, then switch back to the previous view (hit Esc).

Alternatively, undefine the data variable, make the correct selection and do Copy As / Transform, then hit undo.

[galenbwill]

Confirmed this is still an issue in 4.2 stable and 4.3.6464-dev

Also, which bytes of the string literal presentation are selected doesn't matter: regardless of the selection, only the first two bytes of the data variable's value will be copied. This applies to all Copy As and Transform actions.

As described above, the current selection is always the first two bytes of the data variable, regardless of the visual selection in the UI. Also, it doesn't matter if the string contains any \xXX bytes or just ASCII, we simply don't recognize selection of any of the characters of a rendered string as anything but the first two bytes.