From 4e823d328772f184e876fc0faa721516c4474f31 Mon Sep 17 00:00:00 2001 From: Muhammad Muneeb Mubashar Date: Mon, 9 Feb 2026 10:21:29 -0800 Subject: [PATCH 1/4] Update FindMax to use Math.max for maximum calculation Fix logic to find maximum value in the array. --- src/main/java/com/thealgorithms/maths/FindMax.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/main/java/com/thealgorithms/maths/FindMax.java b/src/main/java/com/thealgorithms/maths/FindMax.java index 0ff2bdd191ac..fe9e57b6c1b3 100644 --- a/src/main/java/com/thealgorithms/maths/FindMax.java +++ b/src/main/java/com/thealgorithms/maths/FindMax.java @@ -18,9 +18,7 @@ public static int findMax(final int[] array) { } int max = array[0]; for (int i = 1; i < n; i++) { - if (array[i] > max) { - max = array[i]; - } + max = Math.max(array[i] , array[i+1]); } return max; } From fc3fdaf1ab02c1c50c63551782039d24aef0cbe7 Mon Sep 17 00:00:00 2001 From: Muhammad Muneeb Mubashar Date: Thu, 12 Feb 2026 04:15:34 -0800 Subject: [PATCH 2/4] Fix max calculation in FindMax.java updated --- src/main/java/com/thealgorithms/maths/FindMax.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/thealgorithms/maths/FindMax.java b/src/main/java/com/thealgorithms/maths/FindMax.java index fe9e57b6c1b3..79b2288576f4 100644 --- a/src/main/java/com/thealgorithms/maths/FindMax.java +++ b/src/main/java/com/thealgorithms/maths/FindMax.java @@ -18,7 +18,7 @@ public static int findMax(final int[] array) { } int max = array[0]; for (int i = 1; i < n; i++) { - max = Math.max(array[i] , array[i+1]); + max = Math.max(array[i] , max); } return max; } From 67f743a1b9d2de1deb3ffcd245efd8b9e40cab98 Mon Sep 17 00:00:00 2001 From: Muhammad Muneeb Mubashar Date: Thu, 12 Feb 2026 04:21:58 -0800 Subject: [PATCH 3/4] Refactor FindMax class and improve findMax method Refactored the FindMax class by simplifying the constructor and optimizing the findMax method's checks and loop. --- .../java/com/thealgorithms/maths/FindMax.java | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/src/main/java/com/thealgorithms/maths/FindMax.java b/src/main/java/com/thealgorithms/maths/FindMax.java index 79b2288576f4..6d6cc3b9e0ef 100644 --- a/src/main/java/com/thealgorithms/maths/FindMax.java +++ b/src/main/java/com/thealgorithms/maths/FindMax.java @@ -1,24 +1,16 @@ package com.thealgorithms.maths; public final class FindMax { - private FindMax() { - } + private FindMax() {} - /** - * @brief finds the maximum value stored in the input array - * - * @param array the input array - * @exception IllegalArgumentException input array is empty - * @return the maximum value stored in the input array - */ public static int findMax(final int[] array) { - int n = array.length; - if (n == 0) { + if (array.length == 0) { throw new IllegalArgumentException("Array must be non-empty."); } + int max = array[0]; - for (int i = 1; i < n; i++) { - max = Math.max(array[i] , max); + for (int i = 1; i < array.length; i++) { + max = Math.max(array[i], max); } return max; } From 0b91f2ed18fd4f6d6acc9a1c47f4681e7747071a Mon Sep 17 00:00:00 2001 From: Muhammad Muneeb Mubashar Date: Thu, 12 Feb 2026 04:23:14 -0800 Subject: [PATCH 4/4] Format constructor in FindMax class --- src/main/java/com/thealgorithms/maths/FindMax.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/java/com/thealgorithms/maths/FindMax.java b/src/main/java/com/thealgorithms/maths/FindMax.java index 6d6cc3b9e0ef..ba5998b89e68 100644 --- a/src/main/java/com/thealgorithms/maths/FindMax.java +++ b/src/main/java/com/thealgorithms/maths/FindMax.java @@ -1,7 +1,8 @@ package com.thealgorithms.maths; public final class FindMax { - private FindMax() {} + private FindMax() { + } public static int findMax(final int[] array) { if (array.length == 0) {