Another attempt to prevent occurrence of the access violation exception in the CallFunction method

Author: Taritsyn

src/MsieJavaScriptEngine/JsRt/Edge/ChakraEdgeJsRtJsEngine.cs

@@ -172,7 +172,7 @@ private EdgeJsValue MapToScriptType(object value)
 			switch (typeCode)
 			{
 				case TypeCode.Boolean:
-					return EdgeJsValue.FromBoolean((bool)value);
+					return (bool)value ? EdgeJsValue.True : EdgeJsValue.False;
 
 				case TypeCode.SByte:
 				case TypeCode.Byte:
@@ -282,6 +282,50 @@ private object[] MapToHostType(EdgeJsValue[] args)
 		{
 			return args.Select(MapToHostType).ToArray();
 		}
+
+		/// <summary>
+		/// Adds a reference to the value
+		/// </summary>
+		/// <param name="value">The value</param>
+		private static void AddReferenceToValue(EdgeJsValue value)
+		{
+			if (CanHaveReferences(value))
+			{
+				value.AddRef();
+			}
+		}
+
+		/// <summary>
+		/// Removes a reference to the value
+		/// </summary>
+		/// <param name="value">The value</param>
+		private static void RemoveReferenceToValue(EdgeJsValue value)
+		{
+			if (CanHaveReferences(value))
+			{
+				value.Release();
+			}
+		}
+
+		/// <summary>
+		/// Checks whether the value can have references
+		/// </summary>
+		/// <param name="value">The value</param>
+		/// <returns>Result of check (true - may have; false - may not have)</returns>
+		private static bool CanHaveReferences(EdgeJsValue value)
+		{
+			JsValueType valueType = value.ValueType;
+
+			switch (valueType)
+			{
+				case JsValueType.Null:
+				case JsValueType.Undefined:
+				case JsValueType.Boolean:
+					return false;
+				default:
+					return true;
+			}
+		}
 #if NETSTANDARD1_3
 
 		private EdgeJsValue FromObject(object value)
@@ -945,11 +989,30 @@ public override object CallFunction(string functionName, params object[] args)
 						string.Format(CommonStrings.Runtime_FunctionNotExist, functionName));
 				}
 
-				var processedArgs = MapToScriptType(args);
-				var allProcessedArgs = new[] { globalObj }.Concat(processedArgs).ToArray();
-
+				EdgeJsValue resultValue;
 				EdgeJsValue functionValue = globalObj.GetProperty(functionId);
-				EdgeJsValue resultValue = functionValue.CallFunction(allProcessedArgs);
+
+				if (args.Length > 0)
+				{
+					EdgeJsValue[] processedArgs = MapToScriptType(args);
+
+					foreach (EdgeJsValue processedArg in processedArgs)
+					{
+						AddReferenceToValue(processedArg);
+					}
+
+					EdgeJsValue[] allProcessedArgs = new[] { globalObj }.Concat(processedArgs).ToArray();
+					resultValue = functionValue.CallFunction(allProcessedArgs);
+
+					foreach (EdgeJsValue processedArg in processedArgs)
+					{
+						RemoveReferenceToValue(processedArg);
+					}
+				}
+				else
+				{
+					resultValue = functionValue.CallFunction(globalObj);
+				}
 
 				return MapToHostType(resultValue);
 			});

src/MsieJavaScriptEngine/JsRt/Ie/ChakraIeJsRtJsEngine.cs

@@ -196,7 +196,7 @@ private IeJsValue MapToScriptType(object value)
 			switch (typeCode)
 			{
 				case TypeCode.Boolean:
-					return IeJsValue.FromBoolean((bool)value);
+					return (bool)value ? IeJsValue.True : IeJsValue.False;
 
 				case TypeCode.SByte:
 				case TypeCode.Byte:
@@ -306,6 +306,50 @@ private object[] MapToHostType(IeJsValue[] args)
 		{
 			return args.Select(MapToHostType).ToArray();
 		}
+
+		/// <summary>
+		/// Adds a reference to the value
+		/// </summary>
+		/// <param name="value">The value</param>
+		private static void AddReferenceToValue(IeJsValue value)
+		{
+			if (CanHaveReferences(value))
+			{
+				value.AddRef();
+			}
+		}
+
+		/// <summary>
+		/// Removes a reference to the value
+		/// </summary>
+		/// <param name="value">The value</param>
+		private static void RemoveReferenceToValue(IeJsValue value)
+		{
+			if (CanHaveReferences(value))
+			{
+				value.Release();
+			}
+		}
+
+		/// <summary>
+		/// Checks whether the value can have references
+		/// </summary>
+		/// <param name="value">The value</param>
+		/// <returns>Result of check (true - may have; false - may not have)</returns>
+		private static bool CanHaveReferences(IeJsValue value)
+		{
+			JsValueType valueType = value.ValueType;
+
+			switch (valueType)
+			{
+				case JsValueType.Null:
+				case JsValueType.Undefined:
+				case JsValueType.Boolean:
+					return false;
+				default:
+					return true;
+			}
+		}
 #if NETSTANDARD1_3
 
 		private IeJsValue FromObject(object value)
@@ -983,11 +1027,30 @@ public override object CallFunction(string functionName, params object[] args)
 						string.Format(CommonStrings.Runtime_FunctionNotExist, functionName));
 				}
 
-				var processedArgs = MapToScriptType(args);
-				var allProcessedArgs = new[] { globalObj }.Concat(processedArgs).ToArray();
-
+				IeJsValue resultValue;
 				IeJsValue functionValue = globalObj.GetProperty(functionId);
-				IeJsValue resultValue = functionValue.CallFunction(allProcessedArgs);
+
+				if (args.Length > 0)
+				{
+					IeJsValue[] processedArgs = MapToScriptType(args);
+
+					foreach (IeJsValue processedArg in processedArgs)
+					{
+						AddReferenceToValue(processedArg);
+					}
+
+					IeJsValue[] allProcessedArgs = new[] { globalObj }.Concat(processedArgs).ToArray();
+					resultValue = functionValue.CallFunction(allProcessedArgs);
+
+					foreach (IeJsValue processedArg in processedArgs)
+					{
+						RemoveReferenceToValue(processedArg);
+					}
+				}
+				else
+				{
+					resultValue = functionValue.CallFunction(globalObj);
+				}
 
 				return MapToHostType(resultValue);
 			});