diff --git a/component-form/component-form-core/src/main/java/org/talend/sdk/component/form/internal/converter/impl/widget/AbstractWidgetConverter.java b/component-form/component-form-core/src/main/java/org/talend/sdk/component/form/internal/converter/impl/widget/AbstractWidgetConverter.java index 793d6f1dfb168..849f81a5d806d 100644 --- a/component-form/component-form-core/src/main/java/org/talend/sdk/component/form/internal/converter/impl/widget/AbstractWidgetConverter.java +++ b/component-form/component-form-core/src/main/java/org/talend/sdk/component/form/internal/converter/impl/widget/AbstractWidgetConverter.java @@ -330,7 +330,6 @@ protected Map> createCondition(final PropertyContext< .collect(toList()); final Map> condition = values.size() == 1 ? values.iterator().next() : new UiSchema.ConditionBuilder().withOperator("or").withValues(values).build(); - final UiSchema.ConditionValuesBuilder rootBuilder; if (!shouldBe) { // no need to add the wrapper if we test true (default) return new UiSchema.ConditionBuilder() .withOperator("==") diff --git a/component-form/component-form-core/src/test/java/org/talend/sdk/component/form/api/UiSpecServiceTest.java b/component-form/component-form-core/src/test/java/org/talend/sdk/component/form/api/UiSpecServiceTest.java index 8023cdbd6b3c0..1de8ef11366b2 100644 --- a/component-form/component-form-core/src/test/java/org/talend/sdk/component/form/api/UiSpecServiceTest.java +++ b/component-form/component-form-core/src/test/java/org/talend/sdk/component/form/api/UiSpecServiceTest.java @@ -311,12 +311,6 @@ void enumAsRestrictedList() throws Exception { @Test void optionsOrder() throws Exception { final ConfigTypeNode node = load("optionsorder.json", ConfigTypeNode.class); - final SimplePropertyDefinition root = node - .getProperties() - .stream() - .filter(it -> it.getPath().equals("configuration")) - .findFirst() - .orElseThrow(() -> new IllegalArgumentException("bad config")); final Ui payload = service.convert("FileIO", "en", node, null).toCompletableFuture().get(); final List actualOrder = payload .getUiSchema() diff --git a/component-form/component-form-model/src/test/java/org/talend/sdk/component/form/model/jsonschema/PojoJsonSchemaBuilderTest.java b/component-form/component-form-model/src/test/java/org/talend/sdk/component/form/model/jsonschema/PojoJsonSchemaBuilderTest.java index 0199722125b04..0223db6be215c 100644 --- a/component-form/component-form-model/src/test/java/org/talend/sdk/component/form/model/jsonschema/PojoJsonSchemaBuilderTest.java +++ b/component-form/component-form-model/src/test/java/org/talend/sdk/component/form/model/jsonschema/PojoJsonSchemaBuilderTest.java @@ -53,15 +53,19 @@ private void assertForm1(final Map properties) { public static class Form1 { + @SuppressWarnings("java:S1068") private String name; + @SuppressWarnings("java:S1068") private int age; } public static class Form2 { + @SuppressWarnings("java:S1068") private String name; + @SuppressWarnings("java:S1068") private Form1 form1; } } diff --git a/component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/spi/record/AvroRecordTest.java b/component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/spi/record/AvroRecordTest.java index 514c2150b2538..eec1f45da7f7a 100644 --- a/component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/spi/record/AvroRecordTest.java +++ b/component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/spi/record/AvroRecordTest.java @@ -675,14 +675,12 @@ void pipelineDateTimeFields() throws Exception { final Date date = new Date(new java.text.SimpleDateFormat("yyyy-MM-dd").parse("2018-12-6").getTime()); final Date datetime = new Date(); final Date time = new Date(1000 * 60 * 60 * 15 + 1000 * 60 * 20 + 39000); // 15:20:39 - final Instant timestamp = java.sql.Timestamp.valueOf("2021-04-19 13:37:07.752345").toInstant(); builder.withDateTime("t_date", date); builder.withDateTime("t_datetime", datetime); builder.withDateTime("t_time", time); final Record rec = builder.build(); final Pipeline pipeline = Pipeline.create(); - final PCollection input = pipeline.apply(Create.of(asList(rec)).withCoder(SchemaRegistryCoder.of())); // - final PCollection output = input.apply(new RecordToRecord()); + pipeline.apply(Create.of(asList(rec)).withCoder(SchemaRegistryCoder.of())).apply(new RecordToRecord()); assertEquals(org.apache.beam.sdk.PipelineResult.State.DONE, pipeline.run().waitUntilFinish()); } @@ -721,9 +719,7 @@ void pipelineDecimalFieldsWithAvroRecord() throws Exception { // should not use ReflectData for any GenericRecord implements // ReflectData.get().addLogicalTypeConversion(new Conversions.DecimalConversion()); - final PCollection input = - pipeline.apply(Create.of(asList(rec1, rec2)).withCoder(SchemaRegistryCoder.of())); // - final PCollection output = input.apply(new RecordToRecord()); + pipeline.apply(Create.of(asList(rec1, rec2)).withCoder(SchemaRegistryCoder.of())).apply(new RecordToRecord()); assertEquals(org.apache.beam.sdk.PipelineResult.State.DONE, pipeline.run().waitUntilFinish()); } @@ -751,9 +747,7 @@ void pipelineTimestampFieldsWithAvroRecord() throws Exception { final Pipeline pipeline = Pipeline.create(); - final PCollection input = - pipeline.apply(Create.of(asList(rec1, rec2)).withCoder(SchemaRegistryCoder.of())); // - final PCollection output = input.apply(new RecordToRecord()); + pipeline.apply(Create.of(asList(rec1, rec2)).withCoder(SchemaRegistryCoder.of())).apply(new RecordToRecord()); assertEquals(org.apache.beam.sdk.PipelineResult.State.DONE, pipeline.run().waitUntilFinish()); } diff --git a/component-runtime-beam/src/test/java/org/talend/test/wrapped/JdbcSource.java b/component-runtime-beam/src/test/java/org/talend/test/wrapped/JdbcSource.java index 1ed95f030d1e1..948c8943894fb 100644 --- a/component-runtime-beam/src/test/java/org/talend/test/wrapped/JdbcSource.java +++ b/component-runtime-beam/src/test/java/org/talend/test/wrapped/JdbcSource.java @@ -81,6 +81,7 @@ public static class WorkAroundCoder extends Coder { private static final long serialVersionUID = 1L; + @SuppressWarnings("java:S1068") private transient PCollection collection; private Coder delegate; diff --git a/component-runtime-impl/src/test/java/org/talend/sdk/component/runtime/record/RecordBuilderImplTest.java b/component-runtime-impl/src/test/java/org/talend/sdk/component/runtime/record/RecordBuilderImplTest.java index f8b35e2f5c40d..400662d4dec30 100644 --- a/component-runtime-impl/src/test/java/org/talend/sdk/component/runtime/record/RecordBuilderImplTest.java +++ b/component-runtime-impl/src/test/java/org/talend/sdk/component/runtime/record/RecordBuilderImplTest.java @@ -68,11 +68,6 @@ void providedSchemaGetSchema() { .build()) .build(); assertEquals(schema, new RecordImpl.BuilderImpl(schema).withString("name", "ok").build().getSchema()); - - Schema.EntriesOrder e = Schema.EntriesOrder.of(new RecordImpl.BuilderImpl().getCurrentEntries() - .stream() - .map(Schema.Entry::getName) - .collect(Collectors.toList())); } @Test @@ -437,11 +432,9 @@ void timestampExceedMillisecond() { assertEquals(time.toInstant(), record.getInstant("time")); int nano = time.toInstant().getNano(); - long natime = time.toInstant().toEpochMilli();/// 1000 * 1000_000_000 +nano; long ntime = time.toInstant().getEpochSecond(); Instant back1 = Instant.ofEpochSecond(ntime, nano); - Instant back2 = Instant.ofEpochSecond(natime, nano); assertEquals(time.toInstant(), back1); } diff --git a/component-runtime-impl/src/test/java/org/talend/sdk/component/runtime/record/SchemaImplTest.java b/component-runtime-impl/src/test/java/org/talend/sdk/component/runtime/record/SchemaImplTest.java index f9e314dfe06b0..23d6182a6f9a1 100644 --- a/component-runtime-impl/src/test/java/org/talend/sdk/component/runtime/record/SchemaImplTest.java +++ b/component-runtime-impl/src/test/java/org/talend/sdk/component/runtime/record/SchemaImplTest.java @@ -460,7 +460,6 @@ void emptyRecord() { final Schema emptySchema = new BuilderImpl() // .withType(Type.RECORD) // .build(); - List ordered = emptySchema.getEntriesOrdered(); RecordBuilderFactory factory = new RecordBuilderFactoryImpl("test"); Record record = factory.newRecordBuilder(emptySchema).build(); Assertions.assertNotNull(record); diff --git a/component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/ComponentManager.java b/component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/ComponentManager.java index 70a32144b8ab0..918722384d090 100644 --- a/component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/ComponentManager.java +++ b/component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/ComponentManager.java @@ -295,7 +295,7 @@ public void run() { } static { - ComponentManager manager = SingletonHolder.buildNewComponentManager(); + ComponentManager manager = SingletonHolder.buildNewComponentManager(); // NOSONAR } } diff --git a/component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/builtinparams/StreamingLongParamBuilder.java b/component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/builtinparams/StreamingLongParamBuilder.java index 5fd298231546a..76c81e18b9dbe 100644 --- a/component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/builtinparams/StreamingLongParamBuilder.java +++ b/component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/builtinparams/StreamingLongParamBuilder.java @@ -29,8 +29,6 @@ public class StreamingLongParamBuilder { private final ParameterMeta root; - private final String componentClassName; - private final String name; private final String layoutType; @@ -42,7 +40,6 @@ public class StreamingLongParamBuilder { public StreamingLongParamBuilder(final ParameterMeta root, final String componentClassName, final String parameterName, final LocalConfiguration configuration) { this.root = root; - this.componentClassName = componentClassName; this.name = parameterName; this.configuration = configuration; this.layoutType = findLayoutType(); diff --git a/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/asm/PluginGenerator.java b/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/asm/PluginGenerator.java index 09bc562aa8d4b..b09652acbe40d 100644 --- a/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/asm/PluginGenerator.java +++ b/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/asm/PluginGenerator.java @@ -33,7 +33,6 @@ import java.io.File; import java.io.FileInputStream; import java.io.FileOutputStream; -import java.io.FileReader; import java.io.IOException; import java.io.InputStream; import java.io.Serializable; @@ -97,7 +96,6 @@ public String map(final String key) { } } else { try { - final FileReader reader = new FileReader(clazz); outputStream.putNextEntry(new JarEntry('/' + clazz.getName())); outputStream.write(Files.readAllBytes(clazz.getAbsoluteFile().toPath())); outputStream.closeEntry(); diff --git a/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/checkpoint/CheckpointInputTest.java b/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/checkpoint/CheckpointInputTest.java index 2c08450f24a97..b98b368f35925 100644 --- a/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/checkpoint/CheckpointInputTest.java +++ b/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/checkpoint/CheckpointInputTest.java @@ -32,11 +32,9 @@ import java.util.function.Consumer; import java.util.function.Supplier; -import javax.json.JsonBuilderFactory; import javax.json.JsonObject; import javax.json.bind.Jsonb; import javax.json.bind.spi.JsonbProvider; -import javax.json.spi.JsonProvider; import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.BeforeEach; @@ -61,10 +59,6 @@ @Slf4j class CheckpointInputTest { - private final JsonProvider jsonp = JsonProvider.provider(); - - private final JsonBuilderFactory jsonFactory = jsonp.createBuilderFactory(emptyMap()); - private final Jsonb jsonb = JsonbProvider.provider().create().build(); private final PluginGenerator pluginGenerator = new PluginGenerator(); @@ -207,9 +201,8 @@ void studioLifecycle(@TempDir final Path temporaryFolder) { final Input input = chainedMapper.create(); // ChainedInput input.start(); // - Object rawData; int counted = 0; - while ((rawData = input.next()) != null) { + while (input.next() != null) { // data conversion of rawData to rowStruct and operate on rowStruct... if (input.isCheckpointReady()) { System.err.println(input.getCheckpoint()); @@ -241,10 +234,8 @@ void studioLifecycleWithResume(@TempDir final Path temporaryFolder) { // final Input input = chainedMapper.create(); // ChainedInput input.start((s) -> log.info("[studioLifecycleWithResume] state: {}.", s)); - Object rawData; int counted = 0; - // RowStruct rowStruct = new RowStruct(); // @Data static class RowStruct {Integer data;} - while ((rawData = input.next()) != null) { + while (input.next() != null) { // data conversion of rawData to rowStruct ... // operate on rowStruct... counted++; @@ -295,9 +286,8 @@ void resumeableInputManualUsage(@TempDir final Path temporaryFolder) throws Exce // final Input input = getInput(mgr, "resumeable-input", 1, configuration); input.start(); - Record record; int counted = 0; - while ((record = (Record) input.next()) != null) { + while (input.next() != null) { counted++; if (input.isCheckpointReady()) { assertNotNull(input.getCheckpoint()); @@ -326,9 +316,8 @@ void resumeableInputManualUsageNoCheckpoint(@TempDir final Path temporaryFolder) // final Input input = getInput(mgr, "resumeable-input", 1, configuration); input.start(); - Record record; int counted = 0; - while ((record = (Record) input.next()) != null) { + while (input.next() != null) { counted++; assertFalse(input.isCheckpointReady()); } diff --git a/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/service/InternalizationServiceTest.java b/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/service/InternalizationServiceTest.java index dd29a7d3e018e..741035c986ad1 100644 --- a/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/service/InternalizationServiceTest.java +++ b/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/service/InternalizationServiceTest.java @@ -26,7 +26,6 @@ import org.junit.jupiter.api.Test; import org.junit.jupiter.api.io.TempDir; -import org.talend.sdk.component.runtime.input.Mapper; import org.talend.sdk.component.runtime.manager.ComponentManager; import org.talend.sdk.component.runtime.manager.asm.PluginGenerator; @@ -43,8 +42,7 @@ void wrongCL(@TempDir final File temporaryFolder) { try (final ComponentManager manager = new ComponentManager(deps, "META-INF/test/dependencies", null)) { manager.addPlugin(plugin.getAbsolutePath()); try { - final Mapper mapper = - manager.findMapper("db", "input", 1, emptyMap()).orElseThrow(IllegalStateException::new); + manager.findMapper("db", "input", 1, emptyMap()).orElseThrow(IllegalStateException::new); } catch (MissingResourceException e) { fail("Bundle should have been loaded."); } diff --git a/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/service/MavenRepositoryResolverTest.java b/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/service/MavenRepositoryResolverTest.java index ae2afe9f5b90d..b7e234cab8882 100644 --- a/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/service/MavenRepositoryResolverTest.java +++ b/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/service/MavenRepositoryResolverTest.java @@ -55,8 +55,6 @@ public Path discover() { }; - private final PathHandler handler = new PathHandlerImpl(); - private final PathHandler handlerNoExistCheck = new PathHandlerImpl() { @Override @@ -270,7 +268,6 @@ void discoverFromRepositoryPropertyAndSettingsKo() { @Test void discoverFromEnvironment() throws IOException { Files.createDirectories(repository.resolve("repository")); - final String vm2 = System.getenv("M2_HOME"); final Path m2 = resolver.discover(); assertNotNull(m2); assertEquals(repository.resolve("repository"), m2); diff --git a/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/service/http/RequestParserTest.java b/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/service/http/RequestParserTest.java index f83e5bf0f130e..ca9ff86d1316d 100644 --- a/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/service/http/RequestParserTest.java +++ b/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/service/http/RequestParserTest.java @@ -15,8 +15,6 @@ */ package org.talend.sdk.component.runtime.manager.service.http; -import static org.junit.jupiter.api.Assertions.*; - import java.lang.reflect.Type; import java.util.Collection; import java.util.HashMap; @@ -95,7 +93,6 @@ public T buildNew(Class realClass) { .getDeclaredMethod("complexe", String.class, String.class, String.class, String.class, Integer.class, Map.class)); { - final Type responseType = complexe.getResponseType(); final HttpRequestCreator creator = complexe.getRequestCreator(); Assertions.assertNotNull(creator); Map queryParams = new HashMap<>(); diff --git a/component-runtime-manager/src/test/java/org/talend/test/DataInput.java b/component-runtime-manager/src/test/java/org/talend/test/DataInput.java index 3bd4329ece799..b49dee029645e 100644 --- a/component-runtime-manager/src/test/java/org/talend/test/DataInput.java +++ b/component-runtime-manager/src/test/java/org/talend/test/DataInput.java @@ -34,6 +34,7 @@ @Emitter(family = "db", name = "input") public class DataInput implements Serializable { + @SuppressWarnings("java:S1068") private final I18nService i18n; private static final Map> data = new HashMap<>(); diff --git a/component-runtime-manager/src/test/java/org/talend/test/MapperWithCheckpoint.java b/component-runtime-manager/src/test/java/org/talend/test/MapperWithCheckpoint.java index 060761ef60c17..286c939e69b43 100644 --- a/component-runtime-manager/src/test/java/org/talend/test/MapperWithCheckpoint.java +++ b/component-runtime-manager/src/test/java/org/talend/test/MapperWithCheckpoint.java @@ -91,6 +91,7 @@ public static class MapperWithCheckpointWorker implements Serializable { private int current = 0; + @SuppressWarnings("java:S1068") private boolean newBookmark = false; public MapperWithCheckpointWorker(final RecordBuilderFactory recordBuilderFactory, int partition, diff --git a/component-runtime-manager/src/test/java/org/talend/test/ResumeableInput.java b/component-runtime-manager/src/test/java/org/talend/test/ResumeableInput.java index 76e7c62e437e5..de6c6ad6e65c9 100644 --- a/component-runtime-manager/src/test/java/org/talend/test/ResumeableInput.java +++ b/component-runtime-manager/src/test/java/org/talend/test/ResumeableInput.java @@ -49,6 +49,7 @@ @Slf4j public class ResumeableInput implements Serializable { + @SuppressWarnings("java:S1068") private final Jsonb jsonb; private final RecordBuilderFactory factory; diff --git a/component-server-parent/component-server-api/src/main/java/org/talend/sdk/component/server/api/ComponentResource.java b/component-server-parent/component-server-api/src/main/java/org/talend/sdk/component/server/api/ComponentResource.java index 5c9a626c8d155..9922127b9baa2 100644 --- a/component-server-parent/component-server-api/src/main/java/org/talend/sdk/component/server/api/ComponentResource.java +++ b/component-server-parent/component-server-api/src/main/java/org/talend/sdk/component/server/api/ComponentResource.java @@ -215,8 +215,10 @@ ComponentDetailList getDetail( // @Unused, only for sample class SampleErrorForBulk { + @SuppressWarnings("java:S1068") private ErrorPayload error1; + @SuppressWarnings("java:S1068") private ErrorPayload error2; } } diff --git a/component-server-parent/component-server/src/main/java/org/talend/sdk/component/server/front/BulkReadResourceImpl.java b/component-server-parent/component-server/src/main/java/org/talend/sdk/component/server/front/BulkReadResourceImpl.java index 62462b5af9021..588bc8c648d85 100644 --- a/component-server-parent/component-server/src/main/java/org/talend/sdk/component/server/front/BulkReadResourceImpl.java +++ b/component-server-parent/component-server/src/main/java/org/talend/sdk/component/server/front/BulkReadResourceImpl.java @@ -116,6 +116,7 @@ public class BulkReadResourceImpl implements BulkReadResource { "{\"code\":\"UNAUTHORIZED\",\"description\":\"Forbidden endpoint in bulk mode.\"}")) .readObject()); + @SuppressWarnings("java:S1068") private final BulkResponses.Result forbiddenResponse = new BulkResponses.Result(Response.Status.FORBIDDEN.getStatusCode(), emptyMap(), Json.createReader(new StringReader( diff --git a/component-server-parent/component-server/src/main/java/org/talend/sdk/component/server/front/ComponentResourceImpl.java b/component-server-parent/component-server/src/main/java/org/talend/sdk/component/server/front/ComponentResourceImpl.java index 8e1990c87a52a..9aab8fc65ecfe 100644 --- a/component-server-parent/component-server/src/main/java/org/talend/sdk/component/server/front/ComponentResourceImpl.java +++ b/component-server-parent/component-server/src/main/java/org/talend/sdk/component/server/front/ComponentResourceImpl.java @@ -549,15 +549,14 @@ public Response getIconIndex(final String theme) { @Override public Map migrate(final String id, final int version, final Map config) { - final Map configuration = config.entrySet().stream().map(e -> { + config.entrySet().forEach(e -> { if (e.getValue().startsWith(BASE64_PREFIX)) { final String value = new String(Base64 .getUrlDecoder() .decode(e.getValue().substring(BASE64_PREFIX.length()).getBytes(StandardCharsets.UTF_8))); e.setValue(value); } - return e; - }).collect(toMap(Entry::getKey, Entry::getValue)); + }); if (virtualComponents.isExtensionEntity(id)) { return config; } diff --git a/component-server-parent/component-server/src/main/java/org/talend/sdk/component/server/front/EnvironmentResourceImpl.java b/component-server-parent/component-server/src/main/java/org/talend/sdk/component/server/front/EnvironmentResourceImpl.java index 50df7a436cba7..60d25d05ed0b5 100644 --- a/component-server-parent/component-server/src/main/java/org/talend/sdk/component/server/front/EnvironmentResourceImpl.java +++ b/component-server-parent/component-server/src/main/java/org/talend/sdk/component/server/front/EnvironmentResourceImpl.java @@ -18,7 +18,6 @@ import java.util.Date; import java.util.Spliterator; import java.util.Spliterators; -import java.util.concurrent.atomic.AtomicReference; import java.util.stream.StreamSupport; import javax.annotation.PostConstruct; @@ -37,8 +36,6 @@ @ApplicationScoped public class EnvironmentResourceImpl implements EnvironmentResource { - private final AtomicReference environment = new AtomicReference<>(); - @Inject @ConfigProperty(name = "git.build.version") private String version; diff --git a/component-server-parent/component-server/src/test/java/org/talend/sdk/component/server/front/ConfigurationTypeResourceImplTest.java b/component-server-parent/component-server/src/test/java/org/talend/sdk/component/server/front/ConfigurationTypeResourceImplTest.java index e896a26dda780..a2575d0b2cfba 100644 --- a/component-server-parent/component-server/src/test/java/org/talend/sdk/component/server/front/ConfigurationTypeResourceImplTest.java +++ b/component-server-parent/component-server/src/test/java/org/talend/sdk/component/server/front/ConfigurationTypeResourceImplTest.java @@ -128,13 +128,6 @@ void migrateUnexpectedWithNPE() { @Test void migrateWithEncrypted() { - final JsonBuilderFactory factory = JsonProvider.provider().createBuilderFactory(emptyMap()); - final JsonObject json = factory - .createObjectBuilder() - .add("configuration.url", "vault:v1:hcccVPODe9oZpcr/sKam8GUrbacji8VkuDRGfuDt7bg7VA==") - .add("configuration.username", "username0") - .add("configuration.password", "vault:v1:hcccVPODe9oZpcr/sKam8GUrbacji8VkuDRGfuDt7bg7VA==") - .build(); final Map config = base .path("/configurationtype/migrate/amRiYy1jb21wb25lbnQjamRiYyNkYXRhc2V0I2pkYmM/-2") .request(APPLICATION_JSON_TYPE) diff --git a/component-server-parent/component-server/src/test/java/org/talend/sdk/component/server/test/jdbc/JdbcOutput.java b/component-server-parent/component-server/src/test/java/org/talend/sdk/component/server/test/jdbc/JdbcOutput.java index 285bf4ac0f20b..2af3e73c55cbc 100644 --- a/component-server-parent/component-server/src/test/java/org/talend/sdk/component/server/test/jdbc/JdbcOutput.java +++ b/component-server-parent/component-server/src/test/java/org/talend/sdk/component/server/test/jdbc/JdbcOutput.java @@ -35,6 +35,7 @@ @FixedSchema(value = "jdbc_discover_schema", flows = { "reject" }) public class JdbcOutput implements Serializable { + @SuppressWarnings("java:S1068") private final ConfigWrapper dataset; public JdbcOutput(@Option("configuration") final ConfigWrapper dataset) { diff --git a/component-starter-server/src/main/java/org/talend/sdk/component/starter/server/front/ApiDemoEndpoints.java b/component-starter-server/src/main/java/org/talend/sdk/component/starter/server/front/ApiDemoEndpoints.java index 0a789fcf3cf76..22eee58850939 100644 --- a/component-starter-server/src/main/java/org/talend/sdk/component/starter/server/front/ApiDemoEndpoints.java +++ b/component-starter-server/src/main/java/org/talend/sdk/component/starter/server/front/ApiDemoEndpoints.java @@ -88,6 +88,7 @@ public class ApiDemoEndpoints { public static final String VALUE_ACCESS_CONTROL_ALLOW_METHODS = "GET, POST, DELETE, PUT, PATCH, OPTIONS"; + @SuppressWarnings("java:S1068") private final byte[] ENVIRONMENT; private final Object ACTION_INDEX; @@ -100,6 +101,7 @@ public class ApiDemoEndpoints { private final Object COMPONENT_DEPENDENCIES; + @SuppressWarnings("java:S1068") private final Object COMPONENT_DEPENDENCY; private final Object COMPONENT_ICON; diff --git a/component-starter-server/src/main/java/org/talend/sdk/component/starter/server/service/openapi/OpenAPIGenerator.java b/component-starter-server/src/main/java/org/talend/sdk/component/starter/server/service/openapi/OpenAPIGenerator.java index fc4e634b24a0e..2a41dd6b7b745 100644 --- a/component-starter-server/src/main/java/org/talend/sdk/component/starter/server/service/openapi/OpenAPIGenerator.java +++ b/component-starter-server/src/main/java/org/talend/sdk/component/starter/server/service/openapi/OpenAPIGenerator.java @@ -99,8 +99,6 @@ public Collection generate(final String family, fin final ApiModel api = getApiModel(apiType, openapi); log.warn("[generate] {}", api.getInfo()); - final String defaultUrl = api.getDefaultUrl(); - final String pck = '/' + basePackage.replace('.', '/') + '/'; final String javaBase = build.getMainJavaDirectory() + pck; final String resourcesBase = build.getMainResourcesDirectory() + pck; diff --git a/component-starter-server/src/test/java/org/talend/sdk/component/starter/server/front/apidemo/component/source/MockTableSource.java b/component-starter-server/src/test/java/org/talend/sdk/component/starter/server/front/apidemo/component/source/MockTableSource.java index c86e43a1df874..069ae760c5012 100644 --- a/component-starter-server/src/test/java/org/talend/sdk/component/starter/server/front/apidemo/component/source/MockTableSource.java +++ b/component-starter-server/src/test/java/org/talend/sdk/component/starter/server/front/apidemo/component/source/MockTableSource.java @@ -37,6 +37,7 @@ public class MockTableSource implements Serializable { private final TableDataSet ds; + @SuppressWarnings("java:S1068") private final Messages i18n; private BufferizedProducerSupport bufferedReader; diff --git a/component-starter-server/src/test/resources/generated/ComponentGeneratorTest/genericStreamMapper/MycompSource.java b/component-starter-server/src/test/resources/generated/ComponentGeneratorTest/genericStreamMapper/MycompSource.java index 6e5df1dc649be..238e445db9429 100644 --- a/component-starter-server/src/test/resources/generated/ComponentGeneratorTest/genericStreamMapper/MycompSource.java +++ b/component-starter-server/src/test/resources/generated/ComponentGeneratorTest/genericStreamMapper/MycompSource.java @@ -11,6 +11,7 @@ @Documentation("TODO fill the documentation for this source") public class MycompSource implements Serializable { + @SuppressWarnings("java:S1068") private final MycompSourceConfiguration configuration; private final TestService service; diff --git a/component-studio/component-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/OutputsHandler.java b/component-studio/component-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/OutputsHandler.java index 5d9a30e1c07d4..ec495906e032e 100644 --- a/component-studio/component-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/OutputsHandler.java +++ b/component-studio/component-runtime-di/src/main/java/org/talend/sdk/component/runtime/di/OutputsHandler.java @@ -17,9 +17,7 @@ import java.util.Map; -import javax.json.JsonBuilderFactory; import javax.json.bind.Jsonb; -import javax.json.spi.JsonProvider; import org.talend.sdk.component.api.record.Record; import org.talend.sdk.component.api.record.Schema; @@ -28,16 +26,10 @@ public class OutputsHandler extends BaseIOHandler { - private final JsonProvider jsonProvider; - - private final JsonBuilderFactory jsonBuilderFactory; - private final MappingMetaRegistry registry = new MappingMetaRegistry(); public OutputsHandler(final Jsonb jsonb, final Map, Object> servicesMapper) { super(jsonb, servicesMapper); - this.jsonProvider = (JsonProvider) servicesMapper.get(JsonProvider.class); - this.jsonBuilderFactory = (JsonBuilderFactory) servicesMapper.get(JsonBuilderFactory.class); } public OutputFactory asOutputFactory() { diff --git a/component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/beam/components/DIBatchSimulationTest.java b/component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/beam/components/DIBatchSimulationTest.java index 5979bc9277130..491dbaa6c6eb7 100644 --- a/component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/beam/components/DIBatchSimulationTest.java +++ b/component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/beam/components/DIBatchSimulationTest.java @@ -34,10 +34,8 @@ import java.util.stream.IntStream; import java.util.stream.Stream; -import javax.json.JsonBuilderFactory; import javax.json.JsonObject; import javax.json.bind.Jsonb; -import javax.json.spi.JsonProvider; import org.apache.beam.sdk.coders.SerializableCoder; import org.apache.beam.sdk.transforms.Create; @@ -240,15 +238,10 @@ private void doRun(final ComponentManager manager, final Collection sour final Map, Object> servicesMapper = manager.findPlugin(mapperMapper.plugin()).get().get(ComponentManager.AllServices.class).getServices(); final Jsonb jsonbMapper = Jsonb.class.cast(servicesMapper.get(Jsonb.class)); - final JsonProvider jsonProvider = JsonProvider.class.cast(servicesMapper.get(JsonProvider.class)); - final JsonBuilderFactory jsonBuilderFactory = - JsonBuilderFactory.class.cast(servicesMapper.get(JsonBuilderFactory.class)); final RecordBuilderFactory recordBuilderMapper = RecordBuilderFactory.class.cast(servicesMapper.get(RecordBuilderFactory.class)); final RecordConverters converters = new RecordConverters(); - final RecordConverters.MappingMetaRegistry registry = new RecordConverters.MappingMetaRegistry(); - Object dataMapper; while ((dataMapper = inputMapper.next()) != null) { final String jsonValueMapper; diff --git a/component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/beam/components/DIBulkAutoChunkTest.java b/component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/beam/components/DIBulkAutoChunkTest.java index 0fc4d451efa21..454b4b8b1e8d4 100644 --- a/component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/beam/components/DIBulkAutoChunkTest.java +++ b/component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/beam/components/DIBulkAutoChunkTest.java @@ -37,9 +37,7 @@ import java.util.stream.IntStream; import java.util.stream.Stream; -import javax.json.JsonBuilderFactory; import javax.json.bind.Jsonb; -import javax.json.spi.JsonProvider; import org.junit.jupiter.api.BeforeAll; import org.junit.jupiter.api.Test; @@ -321,14 +319,9 @@ private void doRun(final ComponentManager manager, final Collection sour final Map, Object> servicesMapper = manager.findPlugin(mapperMapper.plugin()).get().get(ComponentManager.AllServices.class).getServices(); - final Jsonb jsonbMapper = Jsonb.class.cast(servicesMapper.get(Jsonb.class)); - final JsonProvider jsonProvider = JsonProvider.class.cast(servicesMapper.get(JsonProvider.class)); - final JsonBuilderFactory jsonBuilderFactory = - JsonBuilderFactory.class.cast(servicesMapper.get(JsonBuilderFactory.class)); final RecordBuilderFactory recordBuilderMapper = RecordBuilderFactory.class.cast(servicesMapper.get(RecordBuilderFactory.class)); builderFactory = recordBuilderMapper; - final RecordConverters converters = new RecordConverters(); final RecordConverters.MappingMetaRegistry registry = new RecordConverters.MappingMetaRegistry(); Object dataMapper; @@ -560,10 +553,6 @@ public void readData(final ObjectInputStream objectInputStream) { } ////////////////////////////////////////// - private static final OutputFactory NO_OUTPUT = name -> value -> { - // no-op - }; - @Data @AllArgsConstructor @NoArgsConstructor diff --git a/component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/schema/TaCoKitGuessSchemaTest.java b/component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/schema/TaCoKitGuessSchemaTest.java index c5eb29834c5b0..5362b5646596c 100644 --- a/component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/schema/TaCoKitGuessSchemaTest.java +++ b/component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/schema/TaCoKitGuessSchemaTest.java @@ -86,8 +86,6 @@ class TaCoKitGuessSchemaTest { private final Pattern schemaPattern = Pattern.compile("(\\[\\{.*\"talendType\".*\\}])"); - private final Pattern logPattern = Pattern.compile("^\\[\\s*(INFO|WARN|ERROR|DEBUG|TRACE)\\s*]"); - private final static java.io.PrintStream stdout = System.out; @BeforeAll diff --git a/component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/studio/DynamicColumnsTest.java b/component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/studio/DynamicColumnsTest.java index 63799b53e8e17..91bfb1e423927 100644 --- a/component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/studio/DynamicColumnsTest.java +++ b/component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/studio/DynamicColumnsTest.java @@ -42,9 +42,7 @@ import java.util.stream.IntStream; import java.util.stream.Stream; -import javax.json.JsonBuilderFactory; import javax.json.bind.Jsonb; -import javax.json.spi.JsonProvider; import org.junit.jupiter.api.BeforeAll; import org.junit.jupiter.api.Test; @@ -82,7 +80,6 @@ import org.talend.sdk.component.runtime.output.InputFactory; import org.talend.sdk.component.runtime.output.OutputFactory; import org.talend.sdk.component.runtime.output.Processor; -import org.talend.sdk.component.runtime.record.RecordConverters; import org.talend.sdk.component.runtime.record.RecordConverters.MappingMetaRegistry; import routines.system.Dynamic; @@ -284,14 +281,9 @@ private void doRun(final ComponentManager manager, final Collection sour final Map, Object> servicesMapper = manager.findPlugin(mapperMapper.plugin()).get().get(AllServices.class).getServices(); - final Jsonb jsonbMapper = Jsonb.class.cast(servicesMapper.get(Jsonb.class)); - final JsonProvider jsonProvider = JsonProvider.class.cast(servicesMapper.get(JsonProvider.class)); - final JsonBuilderFactory jsonBuilderFactory = - JsonBuilderFactory.class.cast(servicesMapper.get(JsonBuilderFactory.class)); final RecordBuilderFactory recordBuilderMapper = RecordBuilderFactory.class.cast(servicesMapper.get(RecordBuilderFactory.class)); builderFactory = recordBuilderMapper; - final RecordConverters converters = new RecordConverters(); final MappingMetaRegistry registry = new MappingMetaRegistry(); Object dataMapper; diff --git a/component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/studio/ParameterSetterTest.java b/component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/studio/ParameterSetterTest.java index 0921b03586420..7c2396df0973c 100644 --- a/component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/studio/ParameterSetterTest.java +++ b/component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/studio/ParameterSetterTest.java @@ -43,9 +43,6 @@ public class ParameterSetterTest { protected static RecordBuilderFactory builderFactory; - // do the same thing with studio - private static final Map globalMap = Collections.synchronizedMap(new HashMap<>()); - @BeforeAll static void forceManagerInit() { final ComponentManager manager = ComponentManager.instance(); diff --git a/component-tools/src/main/java/org/talend/sdk/component/tools/ComponentValidator.java b/component-tools/src/main/java/org/talend/sdk/component/tools/ComponentValidator.java index 2c4b797eafd06..dbd5edfc9c759 100755 --- a/component-tools/src/main/java/org/talend/sdk/component/tools/ComponentValidator.java +++ b/component-tools/src/main/java/org/talend/sdk/component/tools/ComponentValidator.java @@ -78,7 +78,7 @@ public ComponentValidator(final Configuration configuration, final File[] classe super(classes); this.configuration = configuration; this.sourceRoot = sourceRoot; - this.validator = new SvgValidator(this.configuration.isValidateLegacyIcons()); + this.validator = new SvgValidator(); try { this.log = Log.class.isInstance(log) ? Log.class.cast(log) : new ReflectiveLog(log); diff --git a/component-tools/src/main/java/org/talend/sdk/component/tools/DocBaseGenerator.java b/component-tools/src/main/java/org/talend/sdk/component/tools/DocBaseGenerator.java index 8a7a724287872..68c42391b3a4d 100644 --- a/component-tools/src/main/java/org/talend/sdk/component/tools/DocBaseGenerator.java +++ b/component-tools/src/main/java/org/talend/sdk/component/tools/DocBaseGenerator.java @@ -376,8 +376,7 @@ private Set recurseUIParam(final Collection params, final UIInfo uiInfo = new UIInfo(currentSectionName, paramLayouts); uiparams.put(path, uiInfo); if (param.getNestedParameters().size() > 0) { - Set subLayouts = - recurseUIParam(param.getNestedParameters(), uiparams, sectionType, param, paramLayouts); + recurseUIParam(param.getNestedParameters(), uiparams, sectionType, param, paramLayouts); // uiInfo.addNestedLayouts(subLayouts); } } diff --git a/component-tools/src/main/java/org/talend/sdk/component/tools/SvgValidator.java b/component-tools/src/main/java/org/talend/sdk/component/tools/SvgValidator.java index 752d9345f19ca..a61f7879c682b 100644 --- a/component-tools/src/main/java/org/talend/sdk/component/tools/SvgValidator.java +++ b/component-tools/src/main/java/org/talend/sdk/component/tools/SvgValidator.java @@ -36,12 +36,6 @@ public class SvgValidator { private final SAXSVGDocumentFactory factory = new SAXSVGDocumentFactory(XMLResourceDescriptor.getXMLParserClassName()); - private final Boolean legacy; - - public SvgValidator(final Boolean legacy) { - this.legacy = legacy; - } - public Stream validate(final Path path) { final String prefix = "[" + path.getFileName() + "] "; diff --git a/component-tools/src/main/java/org/talend/sdk/component/tools/exec/CarMain.java b/component-tools/src/main/java/org/talend/sdk/component/tools/exec/CarMain.java index b59a6744a2d32..ec9e72e04a0fd 100644 --- a/component-tools/src/main/java/org/talend/sdk/component/tools/exec/CarMain.java +++ b/component-tools/src/main/java/org/talend/sdk/component/tools/exec/CarMain.java @@ -762,8 +762,6 @@ private static HttpURLConnection prepareGet(final String serverUrl, final String System.out.println("Sending GET request to " + url.getPath()); final HttpURLConnection conn = (HttpURLConnection) url.openConnection(); conn.setDoInput(true); - final String userpass = username + ":" + password; - final String basicAuth = "Basic " + Base64.getEncoder().encodeToString(userpass.getBytes()); conn.setRequestMethod("GET"); if (auth != null) { conn.setRequestProperty("Authorization", auth); diff --git a/component-tools/src/test/java/org/talend/sdk/component/tools/SvgValidatorTest.java b/component-tools/src/test/java/org/talend/sdk/component/tools/SvgValidatorTest.java index c6bfe31c74220..2f02fb417bb4b 100644 --- a/component-tools/src/test/java/org/talend/sdk/component/tools/SvgValidatorTest.java +++ b/component-tools/src/test/java/org/talend/sdk/component/tools/SvgValidatorTest.java @@ -81,7 +81,7 @@ void noDisplayNone() { } private List doValidate(final String name, final int count, final Boolean legacyMode) { - final List errors = new SvgValidator(legacyMode).validate(icon(name)).collect(toList()); + final List errors = new SvgValidator().validate(icon(name)).collect(toList()); assertEquals(count, errors.size()); return errors; } diff --git a/component-tools/src/test/java/org/talend/sdk/component/tools/validator/ActionValidatorTest.java b/component-tools/src/test/java/org/talend/sdk/component/tools/validator/ActionValidatorTest.java index a71c2aabb961e..4615590e71fba 100644 --- a/component-tools/src/test/java/org/talend/sdk/component/tools/validator/ActionValidatorTest.java +++ b/component-tools/src/test/java/org/talend/sdk/component/tools/validator/ActionValidatorTest.java @@ -415,6 +415,7 @@ public Set getAvailableOutputs(@Option("configuration") final FakeDataSe @ConditionalOutput("outflow-1") static class AvailableOutputProcessor implements Serializable { + @SuppressWarnings("java:S1068") private ConfigurationAO config; @ElementListener diff --git a/component-tools/src/test/java/org/talend/sdk/component/tools/validator/ExceptionValidatorTest.java b/component-tools/src/test/java/org/talend/sdk/component/tools/validator/ExceptionValidatorTest.java index 17d7d17f53336..a801ed9143850 100644 --- a/component-tools/src/test/java/org/talend/sdk/component/tools/validator/ExceptionValidatorTest.java +++ b/component-tools/src/test/java/org/talend/sdk/component/tools/validator/ExceptionValidatorTest.java @@ -28,6 +28,7 @@ class ExceptionValidatorTest { + @SuppressWarnings("java:S1068") private File fileC1; @Test diff --git a/component-tools/src/test/java/org/talend/test/failure/action/dynamicvalues/MissingDynamicValues.java b/component-tools/src/test/java/org/talend/test/failure/action/dynamicvalues/MissingDynamicValues.java index 36346a4ddb0bb..c4914cfd47d4e 100644 --- a/component-tools/src/test/java/org/talend/test/failure/action/dynamicvalues/MissingDynamicValues.java +++ b/component-tools/src/test/java/org/talend/test/failure/action/dynamicvalues/MissingDynamicValues.java @@ -35,6 +35,7 @@ @Processor(family = "test", name = "my") public class MissingDynamicValues implements Serializable { + @SuppressWarnings("java:S1068") private final Foo foo; public MissingDynamicValues(final Foo foo) { diff --git a/component-tools/src/test/java/org/talend/test/failure/proposal/enumconfig/ComponentConfiguredWithEnum.java b/component-tools/src/test/java/org/talend/test/failure/proposal/enumconfig/ComponentConfiguredWithEnum.java index e0c937cb1e06c..3c3259c63b79f 100644 --- a/component-tools/src/test/java/org/talend/test/failure/proposal/enumconfig/ComponentConfiguredWithEnum.java +++ b/component-tools/src/test/java/org/talend/test/failure/proposal/enumconfig/ComponentConfiguredWithEnum.java @@ -38,6 +38,7 @@ @Processor(family = "test", name = "my") public class ComponentConfiguredWithEnum implements Serializable { + @SuppressWarnings("java:S1068") private final Foo foo; public ComponentConfiguredWithEnum(final Foo foo) { diff --git a/component-tools/src/test/java/org/talend/test/valid/checkpoint/InputCheckpoint.java b/component-tools/src/test/java/org/talend/test/valid/checkpoint/InputCheckpoint.java index cb9c8e27e1ad4..8d9775957e7b7 100644 --- a/component-tools/src/test/java/org/talend/test/valid/checkpoint/InputCheckpoint.java +++ b/component-tools/src/test/java/org/talend/test/valid/checkpoint/InputCheckpoint.java @@ -66,6 +66,7 @@ public static class MyConfiguration implements Serializable { @Checkpoint public static class CheckpointConfig implements Serializable { + @SuppressWarnings("java:S1068") private String position; } } diff --git a/component-tools/src/test/java/org/talend/test/valid/structure/MyComponentWithStructure.java b/component-tools/src/test/java/org/talend/test/valid/structure/MyComponentWithStructure.java index 075e816c5d074..e7503d91b9ddf 100644 --- a/component-tools/src/test/java/org/talend/test/valid/structure/MyComponentWithStructure.java +++ b/component-tools/src/test/java/org/talend/test/valid/structure/MyComponentWithStructure.java @@ -75,10 +75,13 @@ public static class MyDataSet implements Serializable { public class MySchema implements Serializable { + @SuppressWarnings("java:S1068") private String label; + @SuppressWarnings("java:S1068") private int length; + @SuppressWarnings("java:S1068") private int precision; } diff --git a/documentation/src/main/java/org/talend/runtime/documentation/component/source/MockTableSource.java b/documentation/src/main/java/org/talend/runtime/documentation/component/source/MockTableSource.java index fa0218f5be07d..653574de84c4b 100644 --- a/documentation/src/main/java/org/talend/runtime/documentation/component/source/MockTableSource.java +++ b/documentation/src/main/java/org/talend/runtime/documentation/component/source/MockTableSource.java @@ -37,6 +37,7 @@ public class MockTableSource implements Serializable { private final TableDataSet ds; + @SuppressWarnings("java:S1068") private final Messages i18n; private BufferizedProducerSupport bufferedReader; diff --git a/sample-parent/sample-features/loading-analysis/loading-dependencies-common/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/service/AbstractDynamicDependenciesService.java b/sample-parent/sample-features/loading-analysis/loading-dependencies-common/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/service/AbstractDynamicDependenciesService.java index 03d1681e63976..99e1fc451c915 100644 --- a/sample-parent/sample-features/loading-analysis/loading-dependencies-common/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/service/AbstractDynamicDependenciesService.java +++ b/sample-parent/sample-features/loading-analysis/loading-dependencies-common/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/service/AbstractDynamicDependenciesService.java @@ -405,6 +405,7 @@ private Stream getConnectorDependencies(final Connector connector) { return result.stream(); } + @SuppressWarnings("java:S1481") private void checkAssignmentFromDynamicDependency() { DefaultArtifact defaultArtifact = new DefaultArtifact("g:a:v"); // Do nothing, just check assignment diff --git a/sample-parent/sample/src/main/java/org/talend/sdk/component/sample/other/ComplexComponent.java b/sample-parent/sample/src/main/java/org/talend/sdk/component/sample/other/ComplexComponent.java index 3d6af83d80385..7f7b5227afac2 100644 --- a/sample-parent/sample/src/main/java/org/talend/sdk/component/sample/other/ComplexComponent.java +++ b/sample-parent/sample/src/main/java/org/talend/sdk/component/sample/other/ComplexComponent.java @@ -37,6 +37,7 @@ @Emitter(family = "complex", name = "demo") public class ComplexComponent implements Serializable { + @SuppressWarnings("java:S1068") private final ComplexDataSet dataset; public ComplexComponent(@Option("dataset") final ComplexDataSet dataset) { diff --git a/talend-component-maven-plugin/src/main/java/org/talend/sdk/component/maven/ComponentMetadataMojo.java b/talend-component-maven-plugin/src/main/java/org/talend/sdk/component/maven/ComponentMetadataMojo.java index 3913b96546dc7..7c1bd432a0fda 100644 --- a/talend-component-maven-plugin/src/main/java/org/talend/sdk/component/maven/ComponentMetadataMojo.java +++ b/talend-component-maven-plugin/src/main/java/org/talend/sdk/component/maven/ComponentMetadataMojo.java @@ -24,7 +24,6 @@ import java.io.File; import java.io.FileNotFoundException; import java.io.FileOutputStream; -import java.lang.reflect.Method; import java.util.Collection; import java.util.Locale; import java.util.stream.Stream; @@ -84,7 +83,6 @@ protected void doWork(final ComponentManager manager, final Container container, .orElse(p.getName()), p.getIcon(), emptyList(), singletonList("MAIN"))), c.getProcessors().values().stream().map(p -> { - final Method listener = p.getListener(); return new Component(p.getParent().getCategories(), p.getParent().getName(), p.getName(), p diff --git a/vault-client/src/test/java/org/talend/sdk/components/vault/client/VaultClientTest.java b/vault-client/src/test/java/org/talend/sdk/components/vault/client/VaultClientTest.java index 0e7ad456027c5..ba06146b19dd6 100644 --- a/vault-client/src/test/java/org/talend/sdk/components/vault/client/VaultClientTest.java +++ b/vault-client/src/test/java/org/talend/sdk/components/vault/client/VaultClientTest.java @@ -321,7 +321,7 @@ void executeWithBadEncrypted() { @Disabled void executeWithRealVault() { // setup.setVaultUrl("http://localhost:8200"); - final Client realClt = setup.vaultClient(setup.vaultExecutorService()); + setup.vaultClient(setup.vaultExecutorService()); // vault.setVault(setup.vaultTarget(realClt)); vault.setAuthEndpoint("/v1/auth/approle/login"); vault.setDecryptEndpoint("/v1/transit/decrypt/{x-talend-tenant-id}");