Skip to content

[Performance] Optimize header sanitization guard #7621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gonzaloriestra wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −3
Draft

[Performance] Optimize header sanitization guard #7621

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45986f7
[Performance] Optimize header sanitization guard
gonzaloriestra May 24, 2026
ba114ad
[Performance] Optimize header sanitization guard
gonzaloriestra May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/cli-kit/src/private/node/api/headers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {CLI_KIT_VERSION} from '../../../public/common/version.js'
import {firstPartyDev} from '../../../public/node/context/local.js'
import {firstPartyDev, isUnitTest, isVerbose} from '../../../public/node/context/local.js'
import {AbortError} from '../../../public/node/error.js'
import https from 'https'

Expand All @@ -26,16 +26,21 @@ export class GraphQLClientError extends RequestClientError {
}
}

const SENSITIVE_HEADERS = ['token', 'authorization', 'subject_token', 'cookie']

/**
* Removes the sensitive data from the headers and outputs them as a string.
* @param headers - HTTP headers.
* @returns A sanitized version of the headers as a string.
*/
export function sanitizedHeadersOutput(headers: Record<string, string>): string {
if (!isVerbose() && !isUnitTest()) {
return ''
}

const sanitized: Record<string, string> = {}
const keywords = ['token', 'authorization', 'subject_token', 'cookie']
Object.keys(headers).forEach((header) => {
if (keywords.find((keyword) => header.toLowerCase().includes(keyword)) === undefined) {
if (SENSITIVE_HEADERS.find((keyword) => header.toLowerCase().includes(keyword)) === undefined) {
sanitized[header] = headers[header]!
}
})
Expand Down
Loading