From c7a91c0ec6e64ee1d786fb0eceb890e6ab667d69 Mon Sep 17 00:00:00 2001 From: Ryan Bahan Date: Thu, 2 Apr 2026 17:08:23 -0600 Subject: [PATCH] Remove @opentelemetry/semantic-conventions dependency The only usage was SemanticResourceAttributes.SERVICE_NAME (the string literal 'service.name') in DefaultMeterProvider.ts. Inline the value and drop the package dependency. Co-Authored-By: Claude Opus 4.6 (1M context) --- packages/cli-kit/package.json | 1 - .../otel-js/service/DefaultOtelService/DefaultMeterProvider.ts | 3 +-- pnpm-lock.yaml | 3 --- 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/packages/cli-kit/package.json b/packages/cli-kit/package.json index 8813b2b8fd0..1df7f81a0e5 100644 --- a/packages/cli-kit/package.json +++ b/packages/cli-kit/package.json @@ -113,7 +113,6 @@ "@opentelemetry/exporter-metrics-otlp-http": "0.57.0", "@opentelemetry/resources": "1.30.0", "@opentelemetry/sdk-metrics": "1.30.0", - "@opentelemetry/semantic-conventions": "1.28.0", "@types/archiver": "5.3.2", "ajv": "8.18.0", "ansi-escapes": "6.2.1", diff --git a/packages/cli-kit/src/public/node/vendor/otel-js/service/DefaultOtelService/DefaultMeterProvider.ts b/packages/cli-kit/src/public/node/vendor/otel-js/service/DefaultOtelService/DefaultMeterProvider.ts index 1cdad01c0ea..76bd3883092 100644 --- a/packages/cli-kit/src/public/node/vendor/otel-js/service/DefaultOtelService/DefaultMeterProvider.ts +++ b/packages/cli-kit/src/public/node/vendor/otel-js/service/DefaultOtelService/DefaultMeterProvider.ts @@ -2,7 +2,6 @@ import {InstantaneousMetricReader} from '../../export/InstantaneousMetricReader. import {OTLPMetricExporter, OTLPMetricExporterOptions} from '@opentelemetry/exporter-metrics-otlp-http' import {Resource} from '@opentelemetry/resources' import {AggregationTemporality, ConsoleMetricExporter, MeterProvider} from '@opentelemetry/sdk-metrics' -import {SemanticResourceAttributes} from '@opentelemetry/semantic-conventions' export type Environment = 'production' | 'staging' | 'local' @@ -19,7 +18,7 @@ export class DefaultMeterProvider extends MeterProvider { constructor({serviceName, env, throttleLimit, useXhr, otelEndpoint}: DefaultMeterProviderOptions) { super({ resource: new Resource({ - [SemanticResourceAttributes.SERVICE_NAME]: serviceName, + ['service.name']: serviceName, }), }) diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index e37f8dfb5a4..342c198900b 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -330,9 +330,6 @@ importers: '@opentelemetry/sdk-metrics': specifier: 1.30.0 version: 1.30.0(@opentelemetry/api@1.9.0) - '@opentelemetry/semantic-conventions': - specifier: 1.28.0 - version: 1.28.0 '@shopify/toml-patch': specifier: 0.3.0 version: 0.3.0