[Security] Harden random selection in takeRandomFromArray#7623
[Security] Harden random selection in takeRandomFromArray#7623gonzaloriestra wants to merge 1 commit into
Conversation
Replaced Math.random() with crypto.randomInt() in takeRandomFromArray to ensure cryptographically secure random selection. This reduces predictability in generated names and other random selections. Added unit tests to verify the fix and handle empty array edge cases.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
1 participant
Why is this change needed?
The
takeRandomFromArrayutility was usingMath.random(), which is not cryptographically secure. While its current primary use is for generating random names for new app/theme directories, using a CSPRNG is a better default for any random selection utility in the CLI.How to test your changes?
CI
Post-release steps
None.
PR created automatically by Jules for task 8018340101932167753 started by @gonzaloriestra