From 764d38d2c42c17acbbd18a87afe89948d54e4882 Mon Sep 17 00:00:00 2001
From: adibarra <93070681+adibarra@users.noreply.github.com>
Date: Wed, 27 May 2026 19:00:16 -0500
Subject: [PATCH 1/2] feat(feedback): daily, immediate, center-of-page popup

---
 .../app/src/components/feedback-modal.tsx     |  2 +-
 packages/app/src/components/nudge-engine.tsx  | 27 ++++++++++++++++---
 packages/app/src/lib/nudges/registry.tsx      | 11 ++++----
 packages/app/src/lib/nudges/types.ts          |  2 ++
 packages/app/src/lib/visit-tracking.ts        |  3 ---
 packages/app/src/providers/visit-tracker.tsx  | 14 ++--------
 6 files changed, 34 insertions(+), 25 deletions(-)

diff --git a/packages/app/src/components/feedback-modal.tsx b/packages/app/src/components/feedback-modal.tsx
index 56a80129..990e2867 100644
--- a/packages/app/src/components/feedback-modal.tsx
+++ b/packages/app/src/components/feedback-modal.tsx
@@ -105,7 +105,7 @@ export function FeedbackForm({ onDismiss }: FeedbackFormProps) {
           Help us improve InferenceX
         </h2>
         <p id={descId} className="text-sm text-muted-foreground">
-          You're a regular! We'd love to hear what's working and what isn't.
+          We'd love to hear what's working and what isn't.
         </p>
       </div>
 
diff --git a/packages/app/src/components/nudge-engine.tsx b/packages/app/src/components/nudge-engine.tsx
index 6108311a..ef066307 100644
--- a/packages/app/src/components/nudge-engine.tsx
+++ b/packages/app/src/components/nudge-engine.tsx
@@ -355,15 +355,20 @@ function ModalRenderer({
   const { content } = def;
   const Icon = content.icon;
   const idPrefix = def.id;
+  const centered = content.centered;
 
-  return (
+  const dialog = (
     <aside
       data-testid={content.testId}
       role="dialog"
-      aria-modal="false"
+      aria-modal={centered ? 'true' : 'false'}
       aria-labelledby={`${idPrefix}-title`}
       aria-describedby={`${idPrefix}-description`}
-      className={`fixed bottom-4 right-4 z-50 w-[calc(100vw-2rem)] max-w-md rounded-lg border bg-background p-6 shadow-lg ${content.containerClassName ?? ''}`}
+      className={
+        centered
+          ? `relative z-50 w-[calc(100vw-2rem)] max-w-md rounded-lg border bg-background p-6 shadow-lg ${content.containerClassName ?? ''}`
+          : `fixed bottom-4 right-4 z-50 w-[calc(100vw-2rem)] max-w-md rounded-lg border bg-background p-6 shadow-lg ${content.containerClassName ?? ''}`
+      }
     >
       <button
         type="button"
@@ -414,6 +419,22 @@ function ModalRenderer({
       )}
     </aside>
   );
+
+  if (centered) {
+    return (
+      <div className="fixed inset-0 z-50 flex items-center justify-center p-4">
+        <button
+          type="button"
+          aria-label="Close"
+          onClick={onDismiss}
+          className="absolute inset-0 cursor-default bg-black/50"
+        />
+        {dialog}
+      </div>
+    );
+  }
+
+  return dialog;
 }
 
 function BannerRenderer({
diff --git a/packages/app/src/lib/nudges/registry.tsx b/packages/app/src/lib/nudges/registry.tsx
index ff9003ce..df636fef 100644
--- a/packages/app/src/lib/nudges/registry.tsx
+++ b/packages/app/src/lib/nudges/registry.tsx
@@ -13,15 +13,13 @@ import { GITHUB_OWNER, GITHUB_REPO } from '@semianalysisai/inferencex-constants'
 
 import { FEEDBACK_SUBMITTED_EVENT } from '@/components/feedback-modal';
 
-// Keep the ~210-line FeedbackForm out of the landing/dashboard initial JS;
-// it only renders after the eligibility event fires (see feedback-modal nudge below).
+// Keep the ~210-line FeedbackForm out of the landing/dashboard initial JS.
 const FeedbackForm = dynamic(
   () => import('@/components/feedback-modal').then((m) => m.FeedbackForm),
   { ssr: false },
 );
 import { GitHubIcon } from '@/components/ui/github-icon';
 import { STARRED_EVENT, STARRED_KEY, saveStarred } from '@/lib/star-storage';
-import { FEEDBACK_ELIGIBLE_EVENT } from '@/lib/visit-tracking';
 import type { NudgeDefinition } from './types';
 
 const GITHUB_REPO_URL = `https://github.com/${GITHUB_OWNER}/${GITHUB_REPO}`;
@@ -196,10 +194,10 @@ export const NUDGE_REGISTRY: NudgeDefinition[] = [
   {
     id: 'feedback-modal',
     type: 'modal',
-    trigger: { type: 'event', event: FEEDBACK_ELIGIBLE_EVENT, delayMs: 2000 },
+    trigger: { type: 'immediate' },
     dismissal: {
       type: 'timed',
-      durationMs: 90 * 24 * 60 * 60 * 1000,
+      durationMs: 24 * 60 * 60 * 1000,
       cooldownStartsOnShow: true,
     },
     storageKey: 'inferencex-feedback-modal-snoozed',
@@ -211,8 +209,9 @@ export const NUDGE_REGISTRY: NudgeDefinition[] = [
       icon: MessageSquareText,
       iconClassName: 'text-brand',
       title: 'Help us improve InferenceX',
-      description: "You're a regular! We'd love to hear what's working and what isn't.",
+      description: "We'd love to hear what's working and what isn't.",
       testId: 'feedback-modal',
+      centered: true,
       renderContent: ({ dismiss }) => <FeedbackForm onDismiss={dismiss} />,
     },
     analytics: {
diff --git a/packages/app/src/lib/nudges/types.ts b/packages/app/src/lib/nudges/types.ts
index 46578d4f..d73c0173 100644
--- a/packages/app/src/lib/nudges/types.ts
+++ b/packages/app/src/lib/nudges/types.ts
@@ -78,6 +78,8 @@ export interface NudgeContent {
   primaryAction?: NudgeAction;
   /** Extra CSS class on the modal container (e.g. branded border). */
   containerClassName?: string;
+  /** Render as a true center-of-page modal with a backdrop instead of a bottom-right card. */
+  centered?: boolean;
   /** Extra CSS class on the primary action button (e.g. glow effect). */
   actionClassName?: string;
   /** Badge text rendered next to the title (e.g. "New"). */
diff --git a/packages/app/src/lib/visit-tracking.ts b/packages/app/src/lib/visit-tracking.ts
index 2c47f51e..a71cef26 100644
--- a/packages/app/src/lib/visit-tracking.ts
+++ b/packages/app/src/lib/visit-tracking.ts
@@ -4,9 +4,6 @@ const FIRST_SEEN_KEY = 'inferencex-first-seen';
 const LAST_SEEN_KEY = 'inferencex-last-seen';
 const SESSION_KEY = 'inferencex-visit-counted';
 
-export const FEEDBACK_TARGET_VISIT = 2;
-export const FEEDBACK_ELIGIBLE_EVENT = 'inferencex:feedback-eligible';
-
 function todayISO(): string {
   const d = new Date();
   return `${d.getFullYear()}-${String(d.getMonth() + 1).padStart(2, '0')}-${String(d.getDate()).padStart(2, '0')}`;
diff --git a/packages/app/src/providers/visit-tracker.tsx b/packages/app/src/providers/visit-tracker.tsx
index 67b9ac23..cf9404d4 100644
--- a/packages/app/src/providers/visit-tracker.tsx
+++ b/packages/app/src/providers/visit-tracker.tsx
@@ -2,21 +2,11 @@
 
 import { useEffect } from 'react';
 
-import {
-  FEEDBACK_ELIGIBLE_EVENT,
-  FEEDBACK_TARGET_VISIT,
-  recordVisitIfNew,
-} from '@/lib/visit-tracking';
+import { recordVisitIfNew } from '@/lib/visit-tracking';
 
 export function VisitTracker() {
   useEffect(() => {
-    const count = recordVisitIfNew();
-    if (count !== FEEDBACK_TARGET_VISIT) return undefined;
-    // setTimeout(0) so the engine's listener (deeper in the tree) is attached first.
-    const t = window.setTimeout(() => {
-      window.dispatchEvent(new Event(FEEDBACK_ELIGIBLE_EVENT));
-    }, 0);
-    return () => window.clearTimeout(t);
+    recordVisitIfNew();
   }, []);
   return null;
 }

From 62d6305413a902eb1e787d93a5ccdc7120b209b0 Mon Sep 17 00:00:00 2001
From: adibarra <93070681+adibarra@users.noreply.github.com>
Date: Wed, 27 May 2026 19:30:10 -0500
Subject: [PATCH 2/2] test(cypress): seed feedback-modal as snoozed in e2e
 support file

---
 packages/app/cypress.config.ts      |  2 +-
 packages/app/cypress/support/e2e.ts | 16 ++++++++++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)
 create mode 100644 packages/app/cypress/support/e2e.ts

diff --git a/packages/app/cypress.config.ts b/packages/app/cypress.config.ts
index 6d530adf..22ab95a1 100644
--- a/packages/app/cypress.config.ts
+++ b/packages/app/cypress.config.ts
@@ -19,7 +19,7 @@ export default defineConfig({
     testIsolation: false,
     baseUrl: 'http://localhost:3000',
     specPattern: 'cypress/e2e/**/*.cy.ts',
-    supportFile: false,
+    supportFile: 'cypress/support/e2e.ts',
     setupNodeEvents(on, config) {
       on(
         'file:preprocessor',
diff --git a/packages/app/cypress/support/e2e.ts b/packages/app/cypress/support/e2e.ts
new file mode 100644
index 00000000..d8209e33
--- /dev/null
+++ b/packages/app/cypress/support/e2e.ts
@@ -0,0 +1,16 @@
+/**
+ * Global e2e setup. Loaded before every `cy.visit` via `supportFile` in
+ * `cypress.config.ts`.
+ *
+ * Snoozes the feedback-modal nudge so it doesn't render its centered modal
+ * + backdrop on top of the UI under test. Specs that want to exercise the
+ * feedback-modal flow can clear `inferencex-feedback-modal-snoozed` in their
+ * own `onBeforeLoad`.
+ */
+Cypress.on('window:before:load', (win) => {
+  try {
+    win.localStorage.setItem('inferencex-feedback-modal-snoozed', String(Date.now()));
+  } catch {
+    // localStorage unavailable — fine, the test will just see the modal.
+  }
+});