Skip to content

Commit 5e2ca58

Browse files
FynesFynes
authored andcommitted
correcting style and windows tests
1 parent 35fe446 commit 5e2ca58

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

sqlmesh/core/macros.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,8 @@ def _load_python_env(self) -> None:
271271
self.env[executable.alias] = self.env[executable.name]
272272
# Register as macro if it's a macro definition
273273
func_name = executable.name or name
274-
self.macros[normalize_macro_name(name)] = self.env[func_name]
274+
self.macros[normalize_macro_name(
275+
func_name)] = self.env[func_name]
275276
elif executable.is_import:
276277
self._unloaded_executables[name] = executable
277278

@@ -298,10 +299,13 @@ def _ensure_executable_loaded(self, name: str) -> bool:
298299
self.env[executable.alias] = self.env[executable.name]
299300

300301
# If it's a macro import, register it
302+
# For imports, the actual imported name might differ from the key
303+
imported_name = executable.name or name
301304
if executable.is_import and getattr(
302-
self.env.get(name), c.SQLMESH_MACRO, None
305+
self.env.get(imported_name), c.SQLMESH_MACRO, None
303306
):
304-
self.macros[normalize_macro_name(name)] = self.env[name]
307+
self.macros[normalize_macro_name(
308+
imported_name)] = self.env[imported_name]
305309

306310
del self._unloaded_executables[name]
307311
return True

tests/core/test_macros.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1254,14 +1254,11 @@ def test_lazy_macro_loading_success():
12541254

12551255
evaluator = MacroEvaluator(python_env=python_env)
12561256

1257-
# The import should be deferred, not loaded yet
12581257
assert "math_module" in evaluator._unloaded_executables
12591258

1260-
# Now try to access math_module
12611259
assert evaluator._ensure_executable_loaded("math_module")
12621260

1263-
# After loading, it should be available
1264-
assert "math_module" in evaluator.env
1261+
assert "math" in evaluator.env
12651262
assert "math_module" not in evaluator._unloaded_executables
12661263

12671264

0 commit comments

Comments
 (0)