Skip to content

Add PSAvoidUsingNewObject Rule #2109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DrSkillIssue wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add PSAvoidUsingNewObject Rule #2109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
51ab704
feat: PSAvoidUsingNewObject
DrSkillIssue Jun 15, 2025
4422b7e
ref: Support variable resolution in hashtables and partial completions
DrSkillIssue Jun 15, 2025
da95630
fix: Add missing Documentation
DrSkillIssue Jun 16, 2025
26c779c
ref: final restructure
DrSkillIssue Jun 17, 2025
6973dfb
Merge branch 'main' into avoid-new-object
bergmeister Dec 2, 2025
b4a36e5
Merge branch 'main' into avoid-new-object
bergmeister Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Engine/Commands/InvokeScriptAnalyzerCommand.cs
View file
Open in desktop
Copy link
Collaborator

@bergmeister bergmeister Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please tidy up diff

Original file line number Diff line number Diff line change
Expand Up @@ -340,11 +340,11 @@ protected override void BeginProcessing()
settingsObj?.CustomRulePath?.ToArray(),
this.SessionState,
combRecurseCustomRulePath);
combRulePaths = rulePaths == null
? settingsCustomRulePath
: settingsCustomRulePath == null
? rulePaths
: rulePaths.Concat(settingsCustomRulePath).ToArray();
combRulePaths = rulePaths == null
? settingsCustomRulePath
: settingsCustomRulePath == null
? rulePaths
: rulePaths.Concat(settingsCustomRulePath).ToArray();
}
catch (Exception exception)
{
Expand Down
1 change: 1 addition & 0 deletions Engine/Settings/PSGallery.psd1
View file
Open in desktop
Copy link
Collaborator

@bergmeister bergmeister Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is to replicate setting used by PSGallery to scan code when users upload new module and send email if there are violations. I don't even know whether this file is still in sync as of today but this file should only be updated by PSGallery members who know the rules used by PSGallery (and consider adding new ones).
Can you comment on whether this file is up to date and if not open separate PR to sync please @alerickson ?

Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
'PSAvoidGlobalVars',
'PSUseDeclaredVarsMoreThanAssignments',
'PSAvoidUsingInvokeExpression',
'PSAvoidUsingNewObject',
'PSAvoidUsingPlainTextForPassword',
'PSAvoidUsingComputerNameHardcoded',
'PSUsePSCredentialType',
Expand Down
3 changes: 2 additions & 1 deletion Engine/Settings/ScriptFunctions.psd1
View file
Open in desktop
Copy link
Collaborator

@bergmeister bergmeister Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what the purpose of this settings file is but until then I'd not recommend touching it please

Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@
'PSAvoidUsingPositionalParameters',
'PSAvoidGlobalVars',
'PSUseDeclaredVarsMoreThanAssignments',
'PSAvoidUsingInvokeExpression')
'PSAvoidUsingInvokeExpression',
'PSAvoidUsingNewObject')
}
Loading
Loading