Skip to content

[Items] Block items get checked improperly #70

@BlueStaggo

Description

@BlueStaggo

In 1.6.4, items get initialized before blocks and so does OSL's item registry. This leads to there being no blocks to register in VanillaBlockItems so vanilla items should instead be registered after blocks have been loaded. Block and item registries should probably get locked and unlocked at the same times given that in vanilla, blocks and items are in tandem with each other.

Additionally, the length of the block array is 4096 in versions like 1.6.4 and this array length is used in VanillaBlockItems. This leads to a bunch of non-existent blocks being registered under actual items. Fixing this should be as simple as only checking block IDs up to 255.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions