Guard CF1 sprite loading against sprite array overflow#123
Merged
segrax merged 1 commit intoMay 24, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Spritepointer an extra time without checking the fixedmSpritescapacity, allowing crafted.sptdata to write past themSpritesbuffer and corrupt adjacent object memory.Description
cOriginalMap::loadCF1Sptto stop parsing whenSpritehas reachedmSprites.size()inSource/Map/Original.cpp.++Spriteskip cannot advance past the end ofmSprites.Testing
rg) to verify locations ofMap_Load_Sprites/ CF2 hack patterns and confirmed the modified code region was updated successfully, and the commands completed with no errors.git diff) and line numbering (nl) to confirm the bounds checks were inserted at the intended locations, and those checks verified as present.Codex Task