Skip to content

Export ConfigurationParameters#86

Closed
bbenoist wants to merge 1 commit intoOneSignal:mainfrom
bbenoist:export-config
Closed

Export ConfigurationParameters#86
bbenoist wants to merge 1 commit intoOneSignal:mainfrom
bbenoist:export-config

Conversation

@bbenoist
Copy link
Copy Markdown

Description

One Line Summary

I've exported the ConfigurationParameters from the lib so that it can be reused by dependees.

Details

Motivation

I'm wrapping OneSignal in a NestJS configurable module.

For now, the only way to do it is:

export type OneSignalConfigurationParameters = Parameters<
  typeof createConfiguration
>[0];

Scope

Only TypeScript types are affected.

Other

If possible, please release a new version once this PR gets merged 🙏

Testing

Manual testing

No tests are needed for this PR since this is only a new type export.

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

@sherwinski
Copy link
Copy Markdown
Contributor

Released in https://github.com/OneSignal/onesignal-node-api/releases/tag/5.4.0-beta1 🚀 Thanks for making this suggestion and helping improve this project!

@sherwinski sherwinski closed this Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants