feat: auto format config after change with prettier + detect user prettier config

Author: rigor789

lib/controllers/migrate-controller.ts

@@ -855,7 +855,10 @@ Running this command will ${MigrateController.COMMON_MIGRATE_MESSAGE}`;
 		}
 
 		// migrate data into nativescript.config.ts
-		const success = this.$projectConfigService.setValue("", dataToMigrate);
+		const success = await this.$projectConfigService.setValue(
+			"",
+			dataToMigrate
+		);
 
 		if (!success) {
 			this.$errors.fail(
@@ -869,7 +872,7 @@ Running this command will ${MigrateController.COMMON_MIGRATE_MESSAGE}`;
 			rootPackageJsonData.nativescript &&
 			rootPackageJsonData.nativescript.id
 		) {
-			this.$projectConfigService.setValue(
+			await this.$projectConfigService.setValue(
 				"id",
 				rootPackageJsonData.nativescript.id
 			);

lib/services/marking-mode-service.ts

@@ -27,7 +27,7 @@ export class MarkingModeService implements IMarkingModeService {
 		const { skipWarnings, forceSwitch } = options;
 
 		if (forceSwitch) {
-			this.setMarkingMode(MarkingMode.None);
+			await this.setMarkingMode(MarkingMode.None);
 			return;
 		}
 
@@ -36,8 +36,8 @@ export class MarkingModeService implements IMarkingModeService {
 		}
 	}
 
-	private setMarkingMode(newMode: string) {
-		this.$projectConfigService.setValue("android.markingMode", newMode);
+	private async setMarkingMode(newMode: string) {
+		await this.$projectConfigService.setValue("android.markingMode", newMode);
 	}
 
 	private showMarkingModeFullWarning() {

lib/services/project-config-service.ts

@@ -19,6 +19,10 @@ import { IBasePluginData } from "../definitions/plugins";
 import { injector } from "../common/yok";
 import { EOL } from "os";
 import { IOptions } from "../declarations";
+import {
+	format as prettierFormat,
+	resolveConfig as resolvePrettierConfig,
+} from "prettier";
 import semver = require("semver/preload");
 
 export class ProjectConfigService implements IProjectConfigService {
@@ -161,7 +165,10 @@ export default {
 		return _.get(this.readConfig(), key);
 	}
 
-	public setValue(key: string, value: SupportedConfigValues): boolean {
+	public async setValue(
+		key: string,
+		value: SupportedConfigValues
+	): Promise<boolean> {
 		const { hasTS, configJSFilePath, configTSFilePath } = this.detectInfo();
 		const configFilePath = configTSFilePath || configJSFilePath;
 
@@ -188,7 +195,24 @@ export default {
 				configContent
 			);
 			const newContent = transformer.setValue(key, value);
-			this.$fs.writeFile(configFilePath, newContent);
+			const prettierOptions = (await resolvePrettierConfig(
+				this.projectHelper.projectDir,
+				{ editorconfig: true }
+			)) || {
+				semi: false,
+				singleQuote: true,
+			};
+			this.$logger.trace(
+				"updating config, prettier options: ",
+				prettierOptions
+			);
+			this.$fs.writeFile(
+				configFilePath,
+				prettierFormat(newContent, {
+					...prettierOptions,
+					parser: "typescript",
+				})
+			);
 		} catch (error) {
 			this.$logger.error(`Failed to update config.` + error);
 		} finally {

package-lock.json

@@ -76,6 +76,7 @@
     "pbxproj-dom": "1.2.0",
     "plist": "3.0.1",
     "plist-merge-patch": "0.1.1",
+    "prettier": "2.1.1",
     "proper-lockfile": "4.1.1",
     "proxy-lib": "0.4.0",
     "qr-image": "3.2.0",
@@ -116,6 +117,7 @@
     "@types/node": "14.0.27",
     "@types/ora": "3.2.0",
     "@types/pacote": "^11.1.0",
+    "@types/prettier": "2.1.0",
     "@types/proper-lockfile": "4.1.1",
     "@types/qr-image": "3.2.3",
     "@types/request": "2.48.5",
@@ -144,7 +146,6 @@
     "latest-version": "5.1.0",
     "lint-staged": "^10.2.13",
     "mocha": "8.1.1",
-    "prettier": "2.1.1",
     "should": "13.2.3",
     "sinon": "9.0.2",
     "source-map-support": "0.5.19",