[JitDiff X64] [MichalPetryka] Track return type for shared generics via exac ...

[MihuBot]

Job completed in 16 minutes 48 seconds (remote runner delay: 1 minute 14 seconds).
dotnet/runtime#129373

Main commit: dotnet/runtime@98bfa17
PR commit: MichalPetryka/runtime@ead748e

Diffs

Found 156 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 46540289
Total bytes of diff: 46540264
Total bytes of delta: -25 (-0.00 % of base)
Total relative delta: -0.19
    diff is an improvement.
    relative diff is an improvement.


Top file improvements (bytes):
         -25 : System.Security.Cryptography.dasm (-0.00 % of base)

1 total files with Code Size differences (1 improved, 0 regressed), 259 unchanged.

Top method regressions (bytes):
           8 (0.82 % of base) : System.Private.Xml.dasm - System.Xml.Xsl.Runtime.XmlQueryRuntime:ChangeTypeXsltArgument(System.Xml.Xsl.XmlQueryType,System.Object,System.Type):System.Object (FullOpts)

Top method improvements (bytes):
         -25 (-14.62 % of base) : System.Security.Cryptography.dasm - System.Security.Cryptography.XmlKeyHelper+ParseState:ParseDocument(System.String):System.Security.Cryptography.XmlKeyHelper+ParseState (FullOpts)
          -8 (-5.26 % of base) : System.Private.Xml.dasm - System.Xml.Xsl.Runtime.XsltLibrary:FormatMessage(System.String,System.Collections.Generic.IList`1[System.String]):System.String:this (FullOpts)

Top method regressions (percentages):
           8 (0.82 % of base) : System.Private.Xml.dasm - System.Xml.Xsl.Runtime.XmlQueryRuntime:ChangeTypeXsltArgument(System.Xml.Xsl.XmlQueryType,System.Object,System.Type):System.Object (FullOpts)

Top method improvements (percentages):
         -25 (-14.62 % of base) : System.Security.Cryptography.dasm - System.Security.Cryptography.XmlKeyHelper+ParseState:ParseDocument(System.String):System.Security.Cryptography.XmlKeyHelper+ParseState (FullOpts)
          -8 (-5.26 % of base) : System.Private.Xml.dasm - System.Xml.Xsl.Runtime.XsltLibrary:FormatMessage(System.String,System.Collections.Generic.IList`1[System.String]):System.String:this (FullOpts)

3 total methods with Code Size differences (2 improved, 1 regressed), 288707 unchanged.

--------------------------------------------------------------------------------

Artifacts:

• jit-diffs-main.zip (159 MB)
• jit-diffs-pr.zip (159 MB)
• diff-frameworks.txt (1 KB)
• ShortDiffsRegressions.md (18 KB)
• ShortDiffsImprovements.md (10 KB)

[MihuBot]

Top method regressions

8 (0.82 % of base) - System.Xml.Xsl.Runtime.XmlQueryRuntime:ChangeTypeXsltArgument(System.Xml.Xsl.XmlQueryType,System.Object,System.Type):System.Object

 ; Assembly listing for method System.Xml.Xsl.Runtime.XmlQueryRuntime:ChangeTypeXsltArgument(System.Xml.Xsl.XmlQueryType,System.Object,System.Type):System.Object (FullOpts)
 ; Emitting BLENDED_CODE for x64 + VEX + EVEX on Unix
 ; FullOpts code
 ; optimized code
 ; rbp based frame
 ; partially interruptible
 ; No PGO data
 ; 0 inlinees with PGO data; 14 single block inlinees; 0 inlinees without PGO data
 ; Final local variable assignments
 ;
-;  V00 arg0         [V00,T05] (  4,  4   )     ref  ->  rdi         class-hnd single-def <System.Xml.Xsl.XmlQueryType>
+;  V00 arg0         [V00,T06] (  4,  4   )     ref  ->  rdi         class-hnd single-def <System.Xml.Xsl.XmlQueryType>
 ;  V01 arg1         [V01,T02] ( 21, 11.50)     ref  ->  rbx         class-hnd <System.Object>
-;  V02 arg2         [V02,T04] ( 10,  5   )     ref  ->  r15         class-hnd single-def <System.Type>
+;  V02 arg2         [V02,T05] ( 10,  5   )     ref  ->  r15         class-hnd single-def <System.Type>
 ;  V03 loc0         [V03,T07] (  6,  4   )     int  ->  rax        
 ;  V04 loc1         [V04,T03] (  5,  9.50)     ref  ->  rbx         class-hnd single-def <System.Collections.Generic.IList`1[System.Xml.XPath.XPathNavigator]>
-;  V05 loc2         [V05,T06] (  3,  5   )     ref  ->  r15         class-hnd exact single-def <System.Xml.XPath.XPathNavigator[]>
+;  V05 loc2         [V05,T04] (  4,  9   )     ref  ->  r15         class-hnd exact single-def <System.Xml.XPath.XPathNavigator[]>
 ;* V06 loc3         [V06,T23] (  0,  0   )     int  ->  zero-ref   
 ;* V07 loc4         [V07,T22] (  0,  0   )     ref  ->  zero-ref    class-hnd single-def <System.Collections.Generic.IList`1[System.Xml.XPath.XPathItem]>
 ;  V08 loc5         [V08,T13] (  5,  2.50)     ref  ->  r15         class-hnd single-def <System.Xml.XPath.XPathItem>
 ;  V09 loc6         [V09,T14] (  4,  2   )     ref  ->  rax         class-hnd single-def <System.Xml.Xsl.Runtime.RtfNavigator>
 ;# V10 OutArgs      [V10    ] (  1,  1   )  struct ( 0) [rsp+0x00]  do-not-enreg[XS] addr-exposed "OutgoingArgSpace" <Empty>
 ;  V11 tmp1         [V11,T12] (  3,  3   )     ref  ->  rbx         class-hnd exact single-def "Single-def Box Helper" <System.DateTime>
 ;  V12 tmp2         [V12,T08] (  4,  4   )     ref  ->  r15         class-hnd exact single-def "NewObj constructor temp" <MS.Internal.Xml.XPath.XPathArrayIterator>
 ;  V13 tmp3         [V13,T09] (  4,  4   )     ref  ->  r15         class-hnd exact single-def "NewObj constructor temp" <MS.Internal.Xml.XPath.XPathArrayIterator>
 ;  V14 tmp4         [V14,T24] (  3,  0   )     ref  ->  r14         class-hnd exact single-def "NewArr temp" <System.String[]>
 ;  V15 tmp5         [V15,T26] (  2,  0   )     ref  ->  rbx         class-hnd exact single-def "impAppendStmt" <System.String>
 ;  V16 tmp6         [V16,T27] (  2,  0   )     ref  ->  rax         class-hnd exact single-def "Strict ordering of exceptions for Array store" <System.String>
 ;  V17 tmp7         [V17,T25] (  3,  0   )     ref  ->  r15         class-hnd exact single-def "NewObj constructor temp" <System.Xml.Xsl.XslTransformException>
 ;* V18 tmp8         [V18    ] (  0,  0   )     ref  ->  zero-ref    class-hnd exact "NewArr temp" <System.Xml.XPath.XPathNavigator[]>
-;  V19 tmp9         [V19,T10] (  4,  4   )     ref  ->  r15         class-hnd exact single-def "NewObj constructor temp" <MS.Internal.Xml.XPath.XPathArrayIterator>
-;  V20 tmp10        [V20,T15] (  2,  2   )     ref  ->  rsi         class-hnd exact single-def "Inlining Arg" <System.String>
-;  V21 tmp11        [V21    ] (  4,  4   )  struct (16) [rbp-0x28]  do-not-enreg[XSA] multireg-arg addr-exposed ld-addr-op "NewObj constructor temp" <System.Xml.Schema.XsdDateTime>
-;  V22 tmp12        [V22,T16] (  2,  2   )     ref  ->  rax         class-hnd single-def "Inlining Arg" <System.Object>
-;  V23 tmp13        [V23,T17] (  2,  2   )     ref  ->  rax         class-hnd single-def "Inlining Arg" <System.Object>
-;  V24 tmp14        [V24,T18] (  2,  2   )     ref  ->  rax         class-hnd single-def "Inlining Arg" <System.Object>
-;  V25 tmp15        [V25    ] (  4,  4   )    long  ->  [rbp-0x28]  do-not-enreg[X] addr-exposed "field V21._dt (fldOffset=0x0)" P-DEP
-;  V26 tmp16        [V26    ] (  4,  4   )     int  ->  [rbp-0x20]  do-not-enreg[X] addr-exposed "field V21._extra (fldOffset=0x8)" P-DEP
-;  V27 tmp17        [V27,T19] (  2,  2   )    long  ->  rsi         "argument with side effect"
-;  V28 tmp18        [V28,T01] (  2, 16   )     ref  ->  rdx         "argument with side effect"
+;  V19 tmp9         [V19,T01] (  2, 16   )     ref  ->  rax         class-hnd "Strict ordering of exceptions for Array store" <System.Xml.XPath.XPathNavigator>
+;  V20 tmp10        [V20,T10] (  4,  4   )     ref  ->  r15         class-hnd exact single-def "NewObj constructor temp" <MS.Internal.Xml.XPath.XPathArrayIterator>
+;  V21 tmp11        [V21,T15] (  2,  2   )     ref  ->  rsi         class-hnd exact single-def "Inlining Arg" <System.String>
+;  V22 tmp12        [V22    ] (  4,  4   )  struct (16) [rbp-0x28]  do-not-enreg[XSA] multireg-arg addr-exposed ld-addr-op "NewObj constructor temp" <System.Xml.Schema.XsdDateTime>
+;  V23 tmp13        [V23,T16] (  2,  2   )     ref  ->  rax         class-hnd single-def "Inlining Arg" <System.Object>
+;  V24 tmp14        [V24,T17] (  2,  2   )     ref  ->  rax         class-hnd single-def "Inlining Arg" <System.Object>
+;  V25 tmp15        [V25,T18] (  2,  2   )     ref  ->  rax         class-hnd single-def "Inlining Arg" <System.Object>
+;  V26 tmp16        [V26    ] (  4,  4   )    long  ->  [rbp-0x28]  do-not-enreg[X] addr-exposed "field V22._dt (fldOffset=0x0)" P-DEP
+;  V27 tmp17        [V27    ] (  4,  4   )     int  ->  [rbp-0x20]  do-not-enreg[X] addr-exposed "field V22._extra (fldOffset=0x8)" P-DEP
+;  V28 tmp18        [V28,T19] (  2,  2   )    long  ->  rsi         "argument with side effect"
 ;  V29 cse0         [V29,T20] (  3,  1.50)    long  ->  r14         "CSE #04: moderate"
-;  V30 rat0         [V30,T00] (  6, 20.50)    long  ->  r14         "Widened IV V06"
+;  V30 rat0         [V30,T00] (  7, 24.50)    long  ->  r14         "Widened IV V06"
 ;  V31 rat1         [V31,T11] (  4,  3.50)     ref  ->  rsi         "replacement local"
 ;  V32 rat2         [V32,T21] (  3,  1   )    long  ->  rdi         "CSE for expectedClsNode"
 ;
 ; Lcl frame size = 24
 
 G_M4320_IG01:
        push     rbp
        push     r15
        push     r14
        push     rbx
        sub      rsp, 24
        lea      rbp, [rsp+0x30]
        mov      rbx, rsi
        mov      r15, rdx
 						;; size=21 bbWeight=1 PerfScore 5.25
 G_M4320_IG02:
        mov      rax, qword ptr [rdi]
        mov      rax, qword ptr [rax+0x58]
        call     [rax+0x38]System.Xml.Xsl.XmlQueryType:get_TypeCode():int:this
        cmp      eax, 2
        jle      G_M4320_IG07
 						;; size=19 bbWeight=1 PerfScore 8.25
 G_M4320_IG03:
        cmp      eax, 12
        jne      SHORT G_M4320_IG06
        mov      rdi, 0xD1FFAB1E      ; 'System.DateTime'
        cmp      r15, rdi
        jne      G_M4320_IG15
        mov      rsi, rbx
        test     rsi, rsi
        je       SHORT G_M4320_IG05
 						;; size=32 bbWeight=0.50 PerfScore 2.12
 G_M4320_IG04:
        mov      rdi, 0xD1FFAB1E      ; System.String
        cmp      qword ptr [rsi], rdi
        jne      G_M4320_IG17
 						;; size=19 bbWeight=0.25 PerfScore 0.81
 G_M4320_IG05:
        vxorps   xmm0, xmm0, xmm0
        vmovups  xmmword ptr [rbp-0x28], xmm0
        lea      rdi, [rbp-0x28]
        mov      edx, 255
        mov      rax, 0xD1FFAB1E      ; code for System.Xml.Schema.XsdDateTime:.ctor(System.String,int):this
        call     [rax]System.Xml.Schema.XsdDateTime:.ctor(System.String,int):this
        mov      rdi, 0xD1FFAB1E      ; System.DateTime
        call     CORINFO_HELP_NEWSFAST
        mov      rbx, rax
        mov      rdi, qword ptr [rbp-0x28]
        mov      rsi, qword ptr [rbp-0x20]
        mov      rax, 0xD1FFAB1E      ; code for System.Xml.Schema.XsdDateTime:op_Implicit(System.Xml.Schema.XsdDateTime):System.DateTime
        call     [rax]System.Xml.Schema.XsdDateTime:op_Implicit(System.Xml.Schema.XsdDateTime):System.DateTime
        mov      qword ptr [rbx+0x08], rax
        jmp      G_M4320_IG15
 						;; size=77 bbWeight=0.50 PerfScore 7.54
 G_M4320_IG06:
        cmp      eax, 16
        jne      G_M4320_IG15
        mov      rdx, 0xD1FFAB1E      ; 'System.Double'
        cmp      r15, rdx
        je       G_M4320_IG15
        mov      rdx, 0xD1FFAB1E      ; const ptr
        mov      rdx, gword ptr [rdx]
        mov      rdi, rbx
        mov      rsi, r15
        mov      rax, 0xD1FFAB1E      ; code for System.Convert:ChangeType(System.Object,System.Type,System.IFormatProvider):System.Object
        call     [rax]System.Convert:ChangeType(System.Object,System.Type,System.IFormatProvider):System.Object
        mov      rbx, rax
        jmp      G_M4320_IG15
 						;; size=67 bbWeight=0.50 PerfScore 5.50
 G_M4320_IG07:
        cmp      eax, 1
        jne      G_M4320_IG11
        mov      rsi, 0xD1FFAB1E      ; 'System.Object'
        cmp      r15, rsi
        jne      G_M4320_IG18
        mov      rsi, rbx
        mov      rdi, 0xD1FFAB1E      ; System.Collections.Generic.IList`1[System.Xml.XPath.XPathItem]
        mov      rax, 0xD1FFAB1E      ; code for CORINFO_HELP_CHKCASTINTERFACE
        call     [rax]CORINFO_HELP_CHKCASTINTERFACE
        mov      rdi, rbx
        mov      r11, 0xD1FFAB1E      ; code for System.Collections.Generic.ICollection`1[System.__Canon]:get_Count():int:this
        call     [r11]System.Collections.Generic.ICollection`1[System.__Canon]:get_Count():int:this
        cmp      eax, 1
        je       SHORT G_M4320_IG08
        mov      rdi, 0xD1FFAB1E      ; MS.Internal.Xml.XPath.XPathArrayIterator
        call     CORINFO_HELP_NEWSFAST
        mov      r15, rax
        mov      rsi, rbx
        mov      rdi, 0xD1FFAB1E      ; System.Collections.IList
        mov      rax, 0xD1FFAB1E      ; code for CORINFO_HELP_CHKCASTINTERFACE
        call     [rax]CORINFO_HELP_CHKCASTINTERFACE
        mov      dword ptr [r15+0x08], -1
        lea      rdi, bword ptr [r15+0x10]
        mov      rsi, rax
        call     CORINFO_HELP_ASSIGN_REF
        mov      rbx, r15
        jmp      G_M4320_IG15
 						;; size=145 bbWeight=0.50 PerfScore 10.75
 G_M4320_IG08:
        mov      rdi, rbx
        mov      r11, 0xD1FFAB1E      ; code for System.Collections.Generic.IList`1[System.__Canon]:get_Item(int):System.__Canon:this
        xor      esi, esi
        call     [r11]System.Collections.Generic.IList`1[System.__Canon]:get_Item(int):System.__Canon:this
        mov      r15, rax
        mov      rdi, r15
        mov      rax, qword ptr [r15]
        mov      r14, qword ptr [rax+0x40]
        call     [r14+0x20]System.Xml.XPath.XPathItem:get_IsNode():bool:this
        test     eax, eax
        jne      SHORT G_M4320_IG09
        mov      rdi, r15
        call     [r14+0x38]System.Xml.XPath.XPathItem:get_TypedValue():System.Object:this
        mov      rbx, rax
        jmp      G_M4320_IG15
 						;; size=54 bbWeight=0.50 PerfScore 9.00
 G_M4320_IG09:
        mov      rsi, r15
        mov      rdi, 0xD1FFAB1E      ; System.Xml.Xsl.Runtime.RtfNavigator
        mov      rax, 0xD1FFAB1E      ; code for CORINFO_HELP_ISINSTANCEOFCLASS
        call     [rax]CORINFO_HELP_ISINSTANCEOFCLASS
        test     rax, rax
        jne      SHORT G_M4320_IG10
        mov      rdi, 0xD1FFAB1E      ; MS.Internal.Xml.XPath.XPathArrayIterator
        call     CORINFO_HELP_NEWSFAST
        mov      r15, rax
        mov      rsi, rbx
        mov      rdi, 0xD1FFAB1E      ; System.Collections.IList
        mov      rax, 0xD1FFAB1E      ; code for CORINFO_HELP_CHKCASTINTERFACE
        call     [rax]CORINFO_HELP_CHKCASTINTERFACE
        mov      dword ptr [r15+0x08], -1
        lea      rdi, bword ptr [r15+0x10]
        mov      rsi, rax
        call     CORINFO_HELP_ASSIGN_REF
        mov      rbx, r15
        jmp      G_M4320_IG15
 						;; size=101 bbWeight=0.50 PerfScore 7.62
 G_M4320_IG10:
        mov      rdi, rax
        mov      rax, qword ptr [rax]
        mov      rax, qword ptr [rax+0xB8]
        call     [rax+0x08]System.Xml.Xsl.Runtime.RtfNavigator:ToNavigator():System.Xml.XPath.XPathNavigator:this
        mov      rbx, rax
        jmp      G_M4320_IG15
 						;; size=24 bbWeight=0.50 PerfScore 4.75
 G_M4320_IG11:
        cmp      eax, 2
        jne      G_M4320_IG15
        mov      rsi, 0xD1FFAB1E      ; 'System.Xml.XPath.XPathNodeIterator'
        cmp      r15, rsi
        je       G_M4320_IG14
        mov      rsi, 0xD1FFAB1E      ; 'System.Xml.XPath.XPathNavigator[]'
        cmp      r15, rsi
        jne      G_M4320_IG15
        mov      rsi, rbx
        mov      rdi, 0xD1FFAB1E      ; System.Collections.Generic.IList`1[System.Xml.XPath.XPathNavigator]
        mov      rax, 0xD1FFAB1E      ; code for CORINFO_HELP_CHKCASTINTERFACE
        call     [rax]CORINFO_HELP_CHKCASTINTERFACE
        mov      rbx, rax
        mov      rdi, rbx
        mov      r11, 0xD1FFAB1E      ; code for System.Collections.Generic.ICollection`1[System.__Canon]:get_Count():int:this
        call     [r11]System.Collections.Generic.ICollection`1[System.__Canon]:get_Count():int:this
        movsxd   rsi, eax
        mov      rdi, 0xD1FFAB1E      ; System.Xml.XPath.XPathNavigator[]
        call     CORINFO_HELP_NEWARR_1_PTR
        mov      r15, rax
        xor      r14d, r14d
        mov      rdi, rbx
        mov      r11, 0xD1FFAB1E      ; function address
        call     [r11]System.Collections.Generic.ICollection`1[System.__Canon]:get_Count():int:this
        test     eax, eax
        jle      SHORT G_M4320_IG13
 						;; size=135 bbWeight=0.50 PerfScore 9.25
 G_M4320_IG12:
        mov      rdi, rbx
        mov      esi, r14d
        mov      r11, 0xD1FFAB1E      ; code for System.Collections.Generic.IList`1[System.__Canon]:get_Item(int):System.__Canon:this
        call     [r11]System.Collections.Generic.IList`1[System.__Canon]:get_Item(int):System.__Canon:this
-       mov      rdx, rax
-       mov      rsi, r14
-       mov      rdi, r15
-       mov      rax, 0xD1FFAB1E      ; code for CORINFO_HELP_ARRADDR_ST
-       call     [rax]CORINFO_HELP_ARRADDR_ST
+       cmp      r14d, dword ptr [r15+0x08]
+       jae      G_M4320_IG19
+       lea      rdi, bword ptr [r15+8*r14+0x10]
+       mov      rsi, rax
+       call     CORINFO_HELP_ASSIGN_REF
        inc      r14d
        mov      rdi, rbx
        mov      r11, 0xD1FFAB1E      ; code for System.Collections.Generic.ICollection`1[System.__Canon]:get_Count():int:this
        call     [r11]System.Collections.Generic.ICollection`1[System.__Canon]:get_Count():int:this
        cmp      eax, r14d
        jg       SHORT G_M4320_IG12
-						;; size=64 bbWeight=4 PerfScore 51.00
+						;; size=66 bbWeight=4 PerfScore 56.00
 G_M4320_IG13:
        mov      rbx, r15
        jmp      SHORT G_M4320_IG15
 						;; size=5 bbWeight=0.50 PerfScore 1.12
 G_M4320_IG14:
        mov      rdi, 0xD1FFAB1E      ; MS.Internal.Xml.XPath.XPathArrayIterator
        call     CORINFO_HELP_NEWSFAST
        mov      r15, rax
        mov      rsi, rbx
        mov      rdi, 0xD1FFAB1E      ; System.Collections.IList
        mov      rax, 0xD1FFAB1E      ; code for CORINFO_HELP_CHKCASTINTERFACE
        call     [rax]CORINFO_HELP_CHKCASTINTERFACE
        mov      dword ptr [r15+0x08], -1
        lea      rdi, bword ptr [r15+0x10]
        mov      rsi, rax
        call     CORINFO_HELP_ASSIGN_REF
        mov      rbx, r15
 						;; size=66 bbWeight=0.50 PerfScore 4.12
 G_M4320_IG15:
        mov      rax, rbx
 						;; size=3 bbWeight=1 PerfScore 0.25
 G_M4320_IG16:
        add      rsp, 24
        pop      rbx
        pop      r14
        pop      r15
        pop      rbp
        ret      
 						;; size=11 bbWeight=1 PerfScore 3.25
 G_M4320_IG17:
        mov      rsi, rbx
        mov      rax, 0xD1FFAB1E      ; code for CORINFO_HELP_CHKCASTCLASS
        call     [rax]CORINFO_HELP_CHKCASTCLASS
        int3     
 						;; size=16 bbWeight=0 PerfScore 0.00
 G_M4320_IG18:
        mov      rax, 0xD1FFAB1E      ; code for System.SR:get_Xslt_UnsupportedClrType():System.String
        call     [rax]System.SR:get_Xslt_UnsupportedClrType():System.String
        mov      rbx, rax
        mov      rdi, 0xD1FFAB1E      ; System.String[]
        mov      esi, 1
        call     CORINFO_HELP_NEWARR_1_PTR
        mov      r14, rax
        mov      rdi, r15
        mov      rax, qword ptr [r15]
        mov      rax, qword ptr [rax+0x40]
        call     [rax+0x30]System.Reflection.MemberInfo:get_Name():System.String:this
        lea      rdi, bword ptr [r14+0x10]
        mov      rsi, rax
        call     CORINFO_HELP_ASSIGN_REF
        mov      rdi, 0xD1FFAB1E      ; System.Xml.Xsl.XslTransformException
        call     CORINFO_HELP_NEWSFAST
        mov      r15, rax
        mov      rdi, r15
        mov      rsi, rbx
        mov      rdx, r14
        mov      rax, 0xD1FFAB1E      ; code for System.Xml.Xsl.XslTransformException:.ctor(System.String,System.String[]):this
        call     [rax]System.Xml.Xsl.XslTransformException:.ctor(System.String,System.String[]):this
        mov      rdi, r15
        call     CORINFO_HELP_THROW
        int3     
 						;; size=111 bbWeight=0 PerfScore 0.00
+G_M4320_IG19:
+       call     CORINFO_HELP_RNGCHKFAIL
+       int3     
+						;; size=6 bbWeight=0 PerfScore 0.00
 
-; Total bytes of code 970, prolog size 15, PerfScore 130.60, instruction count 210, allocated bytes for code 970 (MethodHash=581aef1f) for method System.Xml.Xsl.Runtime.XmlQueryRuntime:ChangeTypeXsltArgument(System.Xml.Xsl.XmlQueryType,System.Object,System.Type):System.Object (FullOpts)
+; Total bytes of code 978, prolog size 15, PerfScore 135.60, instruction count 212, allocated bytes for code 978 (MethodHash=581aef1f) for method System.Xml.Xsl.Runtime.XmlQueryRuntime:ChangeTypeXsltArgument(System.Xml.Xsl.XmlQueryType,System.Object,System.Type):System.Object (FullOpts)
 ; ============================================================

[MihuBot]

Top method improvements

-25 (-14.62 % of base) - System.Security.Cryptography.XmlKeyHelper+ParseState:ParseDocument(System.String):System.Security.Cryptography.XmlKeyHelper+ParseState

 ; Assembly listing for method System.Security.Cryptography.XmlKeyHelper+ParseState:ParseDocument(System.String):System.Security.Cryptography.XmlKeyHelper+ParseState (FullOpts)
 ; Emitting BLENDED_CODE for x64 + VEX + EVEX on Unix
 ; FullOpts code
 ; optimized code
 ; rbp based frame
 ; partially interruptible
 ; No PGO data
 ; 0 inlinees with PGO data; 11 single block inlinees; 0 inlinees without PGO data
 ; Final local variable assignments
 ;
 ;  V00 RetBuf       [V00,T01] (  6,  6   )    long  ->  rbx         single-def
-;  V01 arg0         [V01,T04] (  3,  3   )     ref  ->  rsi         class-hnd single-def <System.String>
-;* V02 loc0         [V02    ] (  0,  0   )     ref  ->  zero-ref    class-hnd <System.__Canon>
+;  V01 arg0         [V01,T03] (  3,  3   )     ref  ->  rsi         class-hnd single-def <System.String>
+;  V02 loc0         [V02,T04] (  3,  3   )     ref  ->  r15         class-hnd single-def <System.Xml.Linq.XElement>
 ;* V03 loc1         [V03    ] (  0,  0   )  struct (24) zero-ref    ld-addr-op <System.Security.Cryptography.XmlKeyHelper+ParseState>
 ;# V04 OutArgs      [V04    ] (  1,  1   )  struct ( 0) [rsp+0x00]  do-not-enreg[XS] addr-exposed "OutgoingArgSpace" <Empty>
 ;  V05 tmp1         [V05,T02] (  3,  6   )     ref  ->  rax         class-hnd single-def "Inlining Arg" <System.Xml.Linq.XDocument>
-;  V06 tmp2         [V06,T03] (  3,  6   )     ref  ->  r15         class-hnd single-def "Inlining Arg" <System.Xml.Linq.XContainer>
-;  V07 tmp3         [V07,T00] (  6, 12   )     ref  ->  r14         class-hnd exact single-def "NewObj constructor temp" <System.Xml.Linq.XContainer+<GetElements>d__39>
-;  V08 tmp4         [V08,T06] (  2,  2   )     ref  ->  r14         single-def "field V03._enumerable (fldOffset=0x0)" P-INDEP
-;* V09 tmp5         [V09    ] (  0,  0   )     ref  ->  zero-ref    single-def "field V03._enumerator (fldOffset=0x8)" P-INDEP
-;* V10 tmp6         [V10    ] (  0,  0   )     int  ->  zero-ref    "field V03._index (fldOffset=0x10)" P-INDEP
-;  V11 tmp7         [V11,T05] (  2,  4   )     ref  ->  rsi         single-def "argument with side effect"
+;  V06 tmp2         [V06,T00] (  6, 12   )     ref  ->  r14         class-hnd exact single-def "NewObj constructor temp" <System.Xml.Linq.XContainer+<GetElements>d__39>
+;  V07 tmp3         [V07,T05] (  2,  2   )     ref  ->  r14         single-def "field V03._enumerable (fldOffset=0x0)" P-INDEP
+;* V08 tmp4         [V08    ] (  0,  0   )     ref  ->  zero-ref    single-def "field V03._enumerator (fldOffset=0x8)" P-INDEP
+;* V09 tmp5         [V09    ] (  0,  0   )     int  ->  zero-ref    "field V03._index (fldOffset=0x10)" P-INDEP
 ;
 ; Lcl frame size = 8
 
 G_M7359_IG01:
        push     rbp
        push     r15
        push     r14
        push     rbx
        push     rax
        lea      rbp, [rsp+0x20]
        mov      rbx, rdi
 						;; size=15 bbWeight=1 PerfScore 5.75
 G_M7359_IG02:
        mov      rdi, rsi
        xor      esi, esi
        mov      rax, 0xD1FFAB1E      ; code for System.Xml.Linq.XDocument:Parse(System.String,int):System.Xml.Linq.XDocument
        call     [rax]System.Xml.Linq.XDocument:Parse(System.String,int):System.Xml.Linq.XDocument
        cmp      byte  ptr [rax], al
        mov      rdi, rax
        mov      rsi, 0xD1FFAB1E      ; System.Xml.Linq.XDocument:GetFirstNode[System.Xml.Linq.XElement]():System.Xml.Linq.XElement:this
        mov      rax, 0xD1FFAB1E      ; code for System.Xml.Linq.XDocument:GetFirstNode[System.__Canon]():System.__Canon:this
        call     [rax]System.Xml.Linq.XDocument:GetFirstNode[System.__Canon]():System.__Canon:this
-       mov      rsi, rax
-       mov      rdi, 0xD1FFAB1E      ; System.Xml.Linq.XContainer
-       mov      rax, 0xD1FFAB1E      ; code for CORINFO_HELP_CHKCASTCLASS
-       call     [rax]CORINFO_HELP_CHKCASTCLASS
        mov      r15, rax
        cmp      byte  ptr [r15], r15b
        mov      rdi, 0xD1FFAB1E      ; System.Xml.Linq.XContainer+<GetElements>d__39
        call     CORINFO_HELP_NEWSFAST
        mov      r14, rax
        mov      dword ptr [r14+0x30], -2
        call     System.Environment:get_CurrentManagedThreadId():int
        mov      dword ptr [r14+0x34], eax
        lea      rdi, bword ptr [r14+0x10]
        mov      rsi, r15
        call     CORINFO_HELP_ASSIGN_REF
        xor      rax, rax
        mov      gword ptr [r14+0x20], rax
        mov      gword ptr [rbx], r14
-						;; size=131 bbWeight=1 PerfScore 24.00
+						;; size=106 bbWeight=1 PerfScore 20.25
 G_M7359_IG03:
        mov      gword ptr [rbx+0x08], rax
        mov      dword ptr [rbx+0x10], -1
        mov      rax, rbx
 						;; size=14 bbWeight=1 PerfScore 2.25
 G_M7359_IG04:
        add      rsp, 8
        pop      rbx
        pop      r14
        pop      r15
        pop      rbp
        ret      
 						;; size=11 bbWeight=1 PerfScore 3.25
 
-; Total bytes of code 171, prolog size 12, PerfScore 35.25, instruction count 43, allocated bytes for code 171 (MethodHash=135be340) for method System.Security.Cryptography.XmlKeyHelper+ParseState:ParseDocument(System.String):System.Security.Cryptography.XmlKeyHelper+ParseState (FullOpts)
+; Total bytes of code 146, prolog size 12, PerfScore 31.50, instruction count 39, allocated bytes for code 146 (MethodHash=135be340) for method System.Security.Cryptography.XmlKeyHelper+ParseState:ParseDocument(System.String):System.Security.Cryptography.XmlKeyHelper+ParseState (FullOpts)
 ; ============================================================

-8 (-5.26 % of base) - System.Xml.Xsl.Runtime.XsltLibrary:FormatMessage(System.String,System.Collections.Generic.IList`1[System.String]):System.String:this

 ; Assembly listing for method System.Xml.Xsl.Runtime.XsltLibrary:FormatMessage(System.String,System.Collections.Generic.IList`1[System.String]):System.String:this (FullOpts)
 ; Emitting BLENDED_CODE for x64 + VEX + EVEX on Unix
 ; FullOpts code
 ; optimized code
 ; rbp based frame
 ; partially interruptible
 ; No PGO data
 ; Final local variable assignments
 ;
 ;* V00 this         [V00    ] (  0,  0   )     ref  ->  zero-ref    this class-hnd single-def <System.Xml.Xsl.Runtime.XsltLibrary>
 ;  V01 arg1         [V01,T05] (  3,  3   )     ref  ->  r15         class-hnd single-def <System.String>
 ;  V02 arg2         [V02,T02] (  4,  7   )     ref  ->  rbx         class-hnd single-def <System.Collections.Generic.IList`1[System.String]>
 ;  V03 loc0         [V03,T03] (  4,  7   )     ref  ->  r14         class-hnd exact single-def <System.String[]>
 ;* V04 loc1         [V04,T07] (  0,  0   )     int  ->  zero-ref   
 ;# V05 OutArgs      [V05    ] (  1,  1   )  struct ( 0) [rsp+0x00]  do-not-enreg[XS] addr-exposed "OutgoingArgSpace" <Empty>
 ;* V06 tmp1         [V06    ] (  0,  0   )     ref  ->  zero-ref    class-hnd exact "NewArr temp" <System.String[]>
-;  V07 tmp2         [V07,T06] (  2,  4   )    long  ->  rsi         "argument with side effect"
-;  V08 tmp3         [V08,T01] (  2, 16   )     ref  ->  rdx         "argument with side effect"
+;  V07 tmp2         [V07,T01] (  2, 16   )     ref  ->  rax         class-hnd exact "Strict ordering of exceptions for Array store" <System.String>
+;  V08 tmp3         [V08,T06] (  2,  4   )    long  ->  rsi         "argument with side effect"
 ;  V09 cse0         [V09,T04] (  3,  6   )     int  ->  r12         "CSE #01: aggressive"
 ;  V10 rat0         [V10,T00] (  6, 21   )    long  ->  r13         "Widened IV V04"
 ;
 ; Lcl frame size = 8
 
 G_M4053_IG01:
        push     rbp
        push     r15
        push     r14
        push     r13
        push     r12
        push     rbx
        push     rax
        lea      rbp, [rsp+0x30]
        mov      r15, rsi
        mov      rbx, rdx
 						;; size=22 bbWeight=1 PerfScore 8.00
 G_M4053_IG02:
        mov      rdi, rbx
        mov      r11, 0xD1FFAB1E      ; code for System.Collections.Generic.ICollection`1[System.__Canon]:get_Count():int:this
        call     [r11]System.Collections.Generic.ICollection`1[System.__Canon]:get_Count():int:this
        movsxd   rsi, eax
        mov      rdi, 0xD1FFAB1E      ; System.String[]
        call     CORINFO_HELP_NEWARR_1_PTR
        mov      r14, rax
        xor      r13d, r13d
        mov      r12d, dword ptr [r14+0x08]
        test     r12d, r12d
        jle      SHORT G_M4053_IG04
 						;; size=49 bbWeight=1 PerfScore 8.75
 G_M4053_IG03:
        mov      rdi, rbx
        mov      esi, r13d
        mov      r11, 0xD1FFAB1E      ; code for System.Collections.Generic.IList`1[System.__Canon]:get_Item(int):System.__Canon:this
        call     [r11]System.Collections.Generic.IList`1[System.__Canon]:get_Item(int):System.__Canon:this
-       mov      rdx, rax
-       mov      rsi, r13
-       mov      rdi, r14
-       mov      rax, 0xD1FFAB1E      ; code for CORINFO_HELP_ARRADDR_ST
-       call     [rax]CORINFO_HELP_ARRADDR_ST
+       lea      rdi, bword ptr [r14+8*r13+0x10]
+       mov      rsi, rax
+       call     CORINFO_HELP_ASSIGN_REF
        inc      r13d
        cmp      r12d, r13d
        jg       SHORT G_M4053_IG03
-						;; size=48 bbWeight=4 PerfScore 37.00
+						;; size=40 bbWeight=4 PerfScore 30.00
 G_M4053_IG04:
        mov      rdi, r15
        mov      rsi, r14
        mov      rax, 0xD1FFAB1E      ; code for System.Xml.Xsl.XslTransformException:CreateMessage(System.String,System.String[]):System.String
 						;; size=16 bbWeight=1 PerfScore 0.75
 G_M4053_IG05:
        add      rsp, 8
        pop      rbx
        pop      r12
        pop      r13
        pop      r14
        pop      r15
        pop      rbp
        tail.jmp [rax]System.Xml.Xsl.XslTransformException:CreateMessage(System.String,System.String[]):System.String
 						;; size=17 bbWeight=1 PerfScore 5.25
 
-; Total bytes of code 152, prolog size 16, PerfScore 59.75, instruction count 44, allocated bytes for code 152 (MethodHash=2adff02a) for method System.Xml.Xsl.Runtime.XsltLibrary:FormatMessage(System.String,System.Collections.Generic.IList`1[System.String]):System.String:this (FullOpts)
+; Total bytes of code 144, prolog size 16, PerfScore 52.75, instruction count 42, allocated bytes for code 144 (MethodHash=2adff02a) for method System.Xml.Xsl.Runtime.XsltLibrary:FormatMessage(System.String,System.Collections.Generic.IList`1[System.String]):System.String:this (FullOpts)
 ; ============================================================

[MihuBot]

@hez2010