test: device.supportsOutput should respect `PhotoOutputOptions.cont…#1
Open
Jakef14 wants to merge 1 commit into
Open
test: device.supportsOutput should respect `PhotoOutputOptions.cont…#1Jakef14 wants to merge 1 commit into
device.supportsOutput should respect `PhotoOutputOptions.cont…#1Jakef14 wants to merge 1 commit into
Conversation
…ainerFormat`
Adds a failing harness test that pins the cross-field invariant: if
`device.supportsOutput(photoOutput)` returns `true`, then
`session.configure([{ input: device, outputs: [{ output: photoOutput }] }])`
must succeed.
Today `supportsOutput` does not consider `PhotoOutputOptions.containerFormat`.
On iOS front cameras, RAW/DNG capture is not supported, but `supportsOutput`
still returns `true` for a photo output created with `containerFormat: 'dng'`,
and the subsequent `configure(...)` throws at session-build time. High-level
APIs that probe `supportsOutput` upfront (e.g. `<Camera>`) therefore fail
to gate on an unsupported configuration.
The test soft-skips on devices where `supportsOutput` honestly returns
`false` (the fixed end state), and hard-fails on the iOS-front-DNG repro.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ainerFormat`
Adds a failing harness test that pins the cross-field invariant: if
device.supportsOutput(photoOutput)returnstrue, thensession.configure([{ input: device, outputs: [{ output: photoOutput }] }])must succeed.Today
supportsOutputdoes not considerPhotoOutputOptions.containerFormat. On iOS front cameras, RAW/DNG capture is not supported, butsupportsOutputstill returnstruefor a photo output created withcontainerFormat: 'dng', and the subsequentconfigure(...)throws at session-build time. High-level APIs that probesupportsOutputupfront (e.g.<Camera>) therefore fail to gate on an unsupported configuration.The test soft-skips on devices where
supportsOutputhonestly returnsfalse(the fixed end state), and hard-fails on the iOS-front-DNG repro.