From ec2bda84ca792aa242578c30961e896389e14778 Mon Sep 17 00:00:00 2001 From: oganigl Date: Mon, 6 Apr 2026 16:24:33 +0200 Subject: [PATCH 1/4] modified regex from cmake and Moved the enum so doesn't depend on a template --- Inc/ST-LIB_LOW/Sensors/EncoderSensor/NewEncoderSensor.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Inc/ST-LIB_LOW/Sensors/EncoderSensor/NewEncoderSensor.hpp b/Inc/ST-LIB_LOW/Sensors/EncoderSensor/NewEncoderSensor.hpp index 7bcf98eb7..243176f9a 100644 --- a/Inc/ST-LIB_LOW/Sensors/EncoderSensor/NewEncoderSensor.hpp +++ b/Inc/ST-LIB_LOW/Sensors/EncoderSensor/NewEncoderSensor.hpp @@ -9,9 +9,9 @@ #include "C++Utilities/CppUtils.hpp" namespace ST_LIB { - +enum Direction : uint8_t { FORWARD = 0, BACKWARDS = 1 }; template struct EncoderSensor { - enum Direction : uint8_t { FORWARD = 0, BACKWARDS = 1 }; + private: constexpr static size_t WINDOW_SIZE{(SAMPLES / 2) * 2}; From 77f3f1d0969caa74ba30ebf1ea72d61c5edc537e Mon Sep 17 00:00:00 2001 From: oganigl Date: Mon, 6 Apr 2026 16:37:14 +0200 Subject: [PATCH 2/4] run pre-commit --- .changesets/archive/v5.1.0/encoder-minor.md | 2 ++ Inc/ST-LIB_LOW/Sensors/EncoderSensor/NewEncoderSensor.hpp | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 .changesets/archive/v5.1.0/encoder-minor.md diff --git a/.changesets/archive/v5.1.0/encoder-minor.md b/.changesets/archive/v5.1.0/encoder-minor.md new file mode 100644 index 000000000..488ec206f --- /dev/null +++ b/.changesets/archive/v5.1.0/encoder-minor.md @@ -0,0 +1,2 @@ +release: minor +summary: Moved enum Direction to namespace ST-LIB, added more regex to cmake. diff --git a/Inc/ST-LIB_LOW/Sensors/EncoderSensor/NewEncoderSensor.hpp b/Inc/ST-LIB_LOW/Sensors/EncoderSensor/NewEncoderSensor.hpp index 243176f9a..52bc7259a 100644 --- a/Inc/ST-LIB_LOW/Sensors/EncoderSensor/NewEncoderSensor.hpp +++ b/Inc/ST-LIB_LOW/Sensors/EncoderSensor/NewEncoderSensor.hpp @@ -11,7 +11,6 @@ namespace ST_LIB { enum Direction : uint8_t { FORWARD = 0, BACKWARDS = 1 }; template struct EncoderSensor { - private: constexpr static size_t WINDOW_SIZE{(SAMPLES / 2) * 2}; From b7bf8947698c69b2f1c44c2992a97f9cd05711fe Mon Sep 17 00:00:00 2001 From: oganigl Date: Tue, 7 Apr 2026 23:27:46 +0200 Subject: [PATCH 3/4] change encoder test to pass the tests --- Tests/Time/encoder_test.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Tests/Time/encoder_test.cpp b/Tests/Time/encoder_test.cpp index eaf3b8b13..057e05e4e 100644 --- a/Tests/Time/encoder_test.cpp +++ b/Tests/Time/encoder_test.cpp @@ -103,7 +103,7 @@ TEST(EncoderSensorTest, ReadTreatsEncoderInitialCounterAsZeroPosition) { double position = -1.0; double speed = -1.0; double acceleration = -1.0; - MockSensor::Direction direction = MockSensor::BACKWARDS; + ST_LIB::Direction direction = ST_LIB::Direction::BACKWARDS; MockSensor sensor(encoder, 0.5, 0.1, &direction, &position, &speed, &acceleration); @@ -112,7 +112,7 @@ TEST(EncoderSensorTest, ReadTreatsEncoderInitialCounterAsZeroPosition) { EXPECT_DOUBLE_EQ(position, 0.0); EXPECT_DOUBLE_EQ(speed, 0.0); EXPECT_DOUBLE_EQ(acceleration, 0.0); - EXPECT_EQ(direction, MockSensor::FORWARD); + EXPECT_EQ(direction, ST_LIB::Direction::FORWARD); } TEST(EncoderSensorTest, ResetForwardsToEncoderAndClearsHistory) { @@ -122,7 +122,7 @@ TEST(EncoderSensorTest, ResetForwardsToEncoderAndClearsHistory) { double position = 0.0; double speed = 0.0; double acceleration = 0.0; - MockSensor::Direction direction = MockSensor::BACKWARDS; + ST_LIB::Direction direction = ST_LIB::Direction::BACKWARDS; MockSensor sensor(encoder, 1.0, 1.0, &direction, &position, &speed, &acceleration); From 682a399cf847bcf07b59a16f9a3c0d983930923d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jorge=20S=C3=A1ez?= Date: Tue, 14 Apr 2026 19:55:00 +0200 Subject: [PATCH 4/4] Modified changeset --- .changesets/archive/v5.1.0/encoder-minor.md | 2 -- .changesets/encoder-none.md | 4 ++++ 2 files changed, 4 insertions(+), 2 deletions(-) delete mode 100644 .changesets/archive/v5.1.0/encoder-minor.md create mode 100644 .changesets/encoder-none.md diff --git a/.changesets/archive/v5.1.0/encoder-minor.md b/.changesets/archive/v5.1.0/encoder-minor.md deleted file mode 100644 index 488ec206f..000000000 --- a/.changesets/archive/v5.1.0/encoder-minor.md +++ /dev/null @@ -1,2 +0,0 @@ -release: minor -summary: Moved enum Direction to namespace ST-LIB, added more regex to cmake. diff --git a/.changesets/encoder-none.md b/.changesets/encoder-none.md new file mode 100644 index 000000000..1a83c27ad --- /dev/null +++ b/.changesets/encoder-none.md @@ -0,0 +1,4 @@ +release: none +summary: Clean up internal encoder sensor formatting + +No public behavior or API changed in this update.