build: rename _is_trivial -> _trivial to avoid MSVC __is_trivial reserved C++ trait

Author: Berik Ashimov

src/hawkapi/app.py

@@ -565,7 +565,7 @@ async def _execute_trivial_route(
         """Minimal hot path for routes with no DI/deps/perms/bg-tasks/deprecation.
 
         Skips all bookkeeping that _execute_route does. Only safe to call when
-        route._is_trivial is True (guaranteed by _compute_is_trivial at
+        route._trivial is True (guaranteed by _compute_trivial at
         registration time). Handles Request-only and no-arg handlers via the
         pre-computed plan.kwargs_specs via ParamSource.REQUEST detection.
         """
@@ -634,7 +634,7 @@ async def _execute_trivial_route(
 
         # Minimal HEAD handling: zero out the body but keep content-length.
         # StreamingResponse is not a Response subclass — fall back to the
-        # general path if somehow one slips through (guards _is_trivial calc).
+        # general path if somehow one slips through (guards _trivial calc).
         if isinstance(response, StreamingResponse):
             await self._execute_route(scope, receive, send, route, plan, request)
             return
@@ -911,7 +911,7 @@ async def _core_handler_inner(self, scope: Scope, receive: Receive, send: Send)
         # stack, background tasks, HEAD special-case, deprecation headers,
         # permissions, timeout wrapping). The flag is computed once at
         # registration time — no per-request isinstance/attribute checks.
-        if route._is_trivial:  # pyright: ignore[reportPrivateUsage]
+        if route._trivial:  # pyright: ignore[reportPrivateUsage]
             await self._execute_trivial_route(scope, receive, send, route, plan, request)
             return
 

src/hawkapi/routing/route.py

@@ -42,4 +42,4 @@ class Route:
     # no permissions, no background tasks, is async, returns a Response
     # directly, and is not deprecated. Set once at registration time by the
     # router so the per-request hot path avoids branching on all these checks.
-    _is_trivial: bool = field(default=False, repr=False)
+    _trivial: bool = field(default=False, repr=False)

src/hawkapi/routing/router.py

@@ -33,7 +33,7 @@
 )
 
 
-def _compute_is_trivial(
+def _compute_trivial(
     plan: Any,
     response_model: type[Any] | None,
     permissions: list[str] | None,
@@ -239,7 +239,7 @@ def add_route(
             dependencies=dep_plans,
             required_scopes=required_scopes,
             _handler_plan=plan,
-            _is_trivial=_compute_is_trivial(
+            _trivial=_compute_trivial(
                 plan,
                 response_model,
                 permissions,
@@ -601,7 +601,7 @@ def include_router(self, router: Router) -> None:
                 dependencies=merged_deps,
                 required_scopes=merged_required,
                 _handler_plan=plan,
-                _is_trivial=_compute_is_trivial(
+                _trivial=_compute_trivial(
                     plan,
                     route.response_model,
                     route.permissions,

tests/unit/test_trivial_route.py

@@ -1,6 +1,6 @@
 """Unit tests for the trivial-route fast-path classification.
 
-Verifies that ``route._is_trivial`` is True for simple async handlers that
+Verifies that ``route._trivial`` is True for simple async handlers that
 return a Response directly, and False whenever any feature that requires the
 full ``_execute_route`` path is present (DI, deps, perms, bg-tasks, etc.).
 
@@ -49,7 +49,7 @@ async def handler() -> Response:
             return Response(b"pong")
 
         route = _get_route(app, "/ping")
-        assert route._is_trivial is True  # pyright: ignore[reportPrivateUsage]
+        assert route._trivial is True  # pyright: ignore[reportPrivateUsage]
 
     def test_request_only_param(self) -> None:
         """Handler that only takes Request is trivial."""
@@ -60,7 +60,7 @@ async def handler(request: Request) -> Response:
             return PlainTextResponse("hi")
 
         route = _get_route(app, "/hello")
-        assert route._is_trivial is True  # pyright: ignore[reportPrivateUsage]
+        assert route._trivial is True  # pyright: ignore[reportPrivateUsage]
 
     def test_path_param_only(self) -> None:
         """Handler with a single path param is trivial."""
@@ -71,7 +71,7 @@ async def handler(item_id: str) -> Response:
             return Response(item_id.encode())
 
         route = _get_route(app, "/items/{item_id}")
-        assert route._is_trivial is True  # pyright: ignore[reportPrivateUsage]
+        assert route._trivial is True  # pyright: ignore[reportPrivateUsage]
 
     def test_query_param_with_default(self) -> None:
         """Handler with a plain query param default is trivial."""
@@ -82,7 +82,7 @@ async def handler(q: str = "") -> Response:
             return Response(q.encode())
 
         route = _get_route(app, "/search")
-        assert route._is_trivial is True  # pyright: ignore[reportPrivateUsage]
+        assert route._trivial is True  # pyright: ignore[reportPrivateUsage]
 
     def test_json_response_return(self) -> None:
         """Handler returning JSONResponse is trivial."""
@@ -93,7 +93,7 @@ async def handler() -> JSONResponse:
             return JSONResponse({"ok": True})
 
         route = _get_route(app, "/data")
-        assert route._is_trivial is True  # pyright: ignore[reportPrivateUsage]
+        assert route._trivial is True  # pyright: ignore[reportPrivateUsage]
 
 
 # ---------------------------------------------------------------------------
@@ -111,7 +111,7 @@ def handler() -> Response:  # type: ignore[return]
             return Response(b"sync")
 
         route = _get_route(app, "/sync")
-        assert route._is_trivial is False  # pyright: ignore[reportPrivateUsage]
+        assert route._trivial is False  # pyright: ignore[reportPrivateUsage]
 
     def test_depends_callable_not_trivial(self) -> None:
         """Routes with Depends() callable injection are NOT trivial."""
@@ -125,7 +125,7 @@ async def handler(val: Annotated[str, Depends(my_dep)]) -> Response:
             return Response(val.encode())
 
         route = _get_route(app, "/dep")
-        assert route._is_trivial is False  # pyright: ignore[reportPrivateUsage]
+        assert route._trivial is False  # pyright: ignore[reportPrivateUsage]
 
     def test_permissions_not_trivial(self) -> None:
         """Routes with permissions are NOT trivial."""
@@ -136,7 +136,7 @@ async def handler() -> Response:
             return Response(b"secure")
 
         route = _get_route(app, "/secure")
-        assert route._is_trivial is False  # pyright: ignore[reportPrivateUsage]
+        assert route._trivial is False  # pyright: ignore[reportPrivateUsage]
 
     def test_route_level_dependencies_not_trivial(self) -> None:
         """Routes with side-effect dependencies=[Depends(...)] are NOT trivial."""
@@ -150,7 +150,7 @@ async def handler() -> Response:
             return Response(b"guarded")
 
         route = _get_route(app, "/guarded")
-        assert route._is_trivial is False  # pyright: ignore[reportPrivateUsage]
+        assert route._trivial is False  # pyright: ignore[reportPrivateUsage]
 
     def test_background_tasks_not_trivial(self) -> None:
         """Routes injecting BackgroundTasks are NOT trivial."""
@@ -161,7 +161,7 @@ async def handler(bg: BackgroundTasks) -> Response:
             return Response(b"bg")
 
         route = _get_route(app, "/bg")
-        assert route._is_trivial is False  # pyright: ignore[reportPrivateUsage]
+        assert route._trivial is False  # pyright: ignore[reportPrivateUsage]
 
     def test_response_model_not_trivial(self) -> None:
         """Routes with an explicit response_model are NOT trivial."""
@@ -177,7 +177,7 @@ async def handler() -> Item:
             return Item(name="x")
 
         route = _get_route(app, "/item")
-        assert route._is_trivial is False  # pyright: ignore[reportPrivateUsage]
+        assert route._trivial is False  # pyright: ignore[reportPrivateUsage]
 
     def test_deprecated_not_trivial(self) -> None:
         """Deprecated routes are NOT trivial (need deprecation headers)."""
@@ -188,7 +188,7 @@ async def handler() -> Response:
             return Response(b"old")
 
         route = _get_route(app, "/old")
-        assert route._is_trivial is False  # pyright: ignore[reportPrivateUsage]
+        assert route._trivial is False  # pyright: ignore[reportPrivateUsage]
 
     def test_exclude_none_not_trivial(self) -> None:
         """Routes with response_model_exclude_none are NOT trivial."""
@@ -199,7 +199,7 @@ async def handler() -> dict:  # type: ignore[return]
             return {"a": 1, "b": None}
 
         route = _get_route(app, "/filtered")
-        assert route._is_trivial is False  # pyright: ignore[reportPrivateUsage]
+        assert route._trivial is False  # pyright: ignore[reportPrivateUsage]
 
 
 # ---------------------------------------------------------------------------
@@ -219,7 +219,7 @@ async def handler() -> Response:
             return PlainTextResponse("Hello, World!")
 
         route = _get_route(app, "/hello")
-        assert route._is_trivial is True  # pyright: ignore[reportPrivateUsage]
+        assert route._trivial is True  # pyright: ignore[reportPrivateUsage]
 
         client = TestClient(app)
         resp = client.get("/hello")
@@ -237,7 +237,7 @@ async def handler(request: Request) -> Response:
             return PlainTextResponse(request.path)
 
         route = _get_route(app, "/echo-path")
-        assert route._is_trivial is True  # pyright: ignore[reportPrivateUsage]
+        assert route._trivial is True  # pyright: ignore[reportPrivateUsage]
 
         client = TestClient(app)
         resp = client.get("/echo-path")
@@ -254,7 +254,7 @@ async def handler(name: str = "world") -> Response:
             return PlainTextResponse(f"hello {name}")
 
         route = _get_route(app, "/greet")
-        assert route._is_trivial is True  # pyright: ignore[reportPrivateUsage]
+        assert route._trivial is True  # pyright: ignore[reportPrivateUsage]
 
         client = TestClient(app)
         assert client.get("/greet").text == "hello world"
@@ -272,7 +272,7 @@ async def handler() -> Response:
             raise HTTPException(status_code=403, detail="Forbidden")
 
         route = _get_route(app, "/fail")
-        assert route._is_trivial is True  # pyright: ignore[reportPrivateUsage]
+        assert route._trivial is True  # pyright: ignore[reportPrivateUsage]
 
         client = TestClient(app)
         resp = client.get("/fail")