Fix joining path same pt Id#3532
Fix joining path same pt Id#3532Annonnymmousss wants to merge 10 commits intoGraphiteEditor:masterfrom
Conversation
Screen.Recording.2025-12-26.at.9.08.30.PM.movthere was this issue too. |
| let start_point = resolve_id(layer1, start_point, 0); | ||
| let end_point = resolve_id(layer2, end_point, 1); |
There was a problem hiding this comment.
Only ids in layer2 will change (since the layer1 will probably have no conflicts).
Furthermore it is possible that there is no conflict, in which case the original PointId must be used (like before this PR). You therefore need to check if there was some conflict by checking all of the point ids in the first path.
I don't care if this doesn't work for tables with several vector data, since I find them annoying.
|
@Annonnymmousss The issue in your video is the exact same as described in #3519 (the conflicting |
|
working on it |
|
@0HyperCube should i close this pr as the other one is approved?? |
|
I'm not a maintainer for this project so my approval on a PR is meaningless. https://docs.github.com/en/get-started/learning-about-github/access-permissions-on-github |
|
ohh okayyy |
timon-schelling
force-pushed
the
master
branch
from
124235a to
a42cad8
Compare
|
issue fixed by PR #3534 . |
3 participants
im still not getting how to create a segment in the first cmd + J only which is merging the layer but this issue is resolved..
Screen.Recording.2025-12-26.at.9.05.20.PM.mov
solving #3519