From d79165fe61b1f9d415a6f2402e1ee3558c47229f Mon Sep 17 00:00:00 2001 From: Angel Caamal Date: Thu, 19 Mar 2026 00:09:23 +0000 Subject: [PATCH 1/2] feat(storage): introduce quickstart sample and test for migration --- storage/package.json | 30 +++++++++++ storage/quickstart.js | 51 +++++++++++++++++++ storage/resources/.gitignore | 1 + storage/resources/resourcesSub1/testSub1.txt | 2 + storage/resources/test.txt | 1 + storage/resources/test2.txt | 1 + storage/scripts/cleanup | 44 ++++++++++++++++ storage/system-test/quickstart.test.js | 36 +++++++++++++ ...t_9d800329-00da-4cdd-9a3e-7ac6743d5813.txt | 0 9 files changed, 166 insertions(+) create mode 100644 storage/package.json create mode 100644 storage/quickstart.js create mode 100644 storage/resources/.gitignore create mode 100644 storage/resources/resourcesSub1/testSub1.txt create mode 100644 storage/resources/test.txt create mode 100644 storage/resources/test2.txt create mode 100644 storage/scripts/cleanup create mode 100644 storage/system-test/quickstart.test.js create mode 100644 storage/system-test/test_9d800329-00da-4cdd-9a3e-7ac6743d5813.txt diff --git a/storage/package.json b/storage/package.json new file mode 100644 index 0000000000..71acc18ab5 --- /dev/null +++ b/storage/package.json @@ -0,0 +1,30 @@ +{ + "name": "@google-cloud/storage-samples", + "description": "Samples for the Cloud Storage Client Library for Node.js.", + "license": "Apache-2.0", + "author": "Google Inc.", + "engines": { + "node": ">=12" + }, + "repository": "googleapis/nodejs-storage", + "private": true, + "files": [ + "*.js" + ], + "scripts": { + "cleanup": "node scripts/cleanup", + "test": "mocha system-test/*.js --timeout 800000" + }, + "dependencies": { + "@google-cloud/pubsub": "^4.0.0", + "@google-cloud/storage": "^7.19.0", + "node-fetch": "^2.6.7", + "uuid": "^8.0.0", + "yargs": "^16.0.0" + }, + "devDependencies": { + "chai": "^4.2.0", + "mocha": "^8.0.0", + "p-limit": "^3.1.0" + } +} diff --git a/storage/quickstart.js b/storage/quickstart.js new file mode 100644 index 0000000000..6e329da9fa --- /dev/null +++ b/storage/quickstart.js @@ -0,0 +1,51 @@ +// Copyright 2019 Google LLC +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +'use strict'; + +function main(bucketName = 'my-new-bucket') { + // [START storage_quickstart] + // Imports the Google Cloud client library + const {Storage} = require('@google-cloud/storage'); + + // For more information on ways to initialize Storage, please see + // https://googleapis.dev/nodejs/storage/latest/Storage.html + + // Creates a client using Application Default Credentials + const storage = new Storage(); + + // Creates a client from a Google service account key + // const storage = new Storage({keyFilename: 'key.json'}); + + /** + * TODO(developer): Uncomment these variables before running the sample. + */ + // The ID of your GCS bucket + // const bucketName = 'your-unique-bucket-name'; + + async function createBucket() { + try { + // Creates the new bucket + await storage.createBucket(bucketName); + console.log(`Bucket ${bucketName} created.`); + } catch (error) { + console.error('Error executing create bucket:', error.message || error); + } + } + + createBucket(); + // [END storage_quickstart] +} + +main(...process.argv.slice(2)); diff --git a/storage/resources/.gitignore b/storage/resources/.gitignore new file mode 100644 index 0000000000..6738013702 --- /dev/null +++ b/storage/resources/.gitignore @@ -0,0 +1 @@ +downloaded.txt diff --git a/storage/resources/resourcesSub1/testSub1.txt b/storage/resources/resourcesSub1/testSub1.txt new file mode 100644 index 0000000000..51f4b307d5 --- /dev/null +++ b/storage/resources/resourcesSub1/testSub1.txt @@ -0,0 +1,2 @@ +Sub1 +Hello World! \ No newline at end of file diff --git a/storage/resources/test.txt b/storage/resources/test.txt new file mode 100644 index 0000000000..c57eff55eb --- /dev/null +++ b/storage/resources/test.txt @@ -0,0 +1 @@ +Hello World! \ No newline at end of file diff --git a/storage/resources/test2.txt b/storage/resources/test2.txt new file mode 100644 index 0000000000..010302410b --- /dev/null +++ b/storage/resources/test2.txt @@ -0,0 +1 @@ +Hello World 2! \ No newline at end of file diff --git a/storage/scripts/cleanup b/storage/scripts/cleanup new file mode 100644 index 0000000000..61bd73114f --- /dev/null +++ b/storage/scripts/cleanup @@ -0,0 +1,44 @@ +#!/usr/bin/env node + +// Copyright 2019 Google LLC +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +'use strict'; + +const {Storage} = require('@google-cloud/storage'); +const storage = new Storage(); +const NAME_REG_EXP = /^nodejs-storage-samples-[a-z0-9]{8}-[a-z0-9]{4}-[a-z0-9]{4}-[a-z0-9]{4}-[a-z0-9]{12}$/; + +storage + .getBuckets() + .then(([buckets]) => { + let promise = Promise.resolve(); + + buckets + .filter((bucket) => NAME_REG_EXP.test(bucket.name)) + .forEach((bucket) => { + promise = promise.then(() => { + return bucket.deleteFiles() + .then(() => bucket.deleteFiles(), console.error) + .then(() => { + console.log(`Deleting ${bucket.name}`); + return bucket.delete(); + }, console.error) + .catch(console.error); + }); + }); + }) + .catch((err) => { + console.error('ERROR:', err); + }); diff --git a/storage/system-test/quickstart.test.js b/storage/system-test/quickstart.test.js new file mode 100644 index 0000000000..4e3ffe0038 --- /dev/null +++ b/storage/system-test/quickstart.test.js @@ -0,0 +1,36 @@ +// Copyright 2019 Google LLC +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +'use strict'; + +const {assert} = require('chai'); +const {after, it} = require('mocha'); +const cp = require('child_process'); +const uuid = require('uuid'); +const {Storage} = require('@google-cloud/storage'); + +const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'}); + +const storage = new Storage(); +const bucketName = `nodejs-storage-samples-${uuid.v4()}`; + +after(async () => { + const bucket = storage.bucket(bucketName); + await bucket.delete().catch(console.error); +}); + +it('should run the quickstart', async () => { + const stdout = execSync(`node quickstart ${bucketName}`); + assert.match(stdout, /Bucket .* created./); +}); diff --git a/storage/system-test/test_9d800329-00da-4cdd-9a3e-7ac6743d5813.txt b/storage/system-test/test_9d800329-00da-4cdd-9a3e-7ac6743d5813.txt new file mode 100644 index 0000000000..e69de29bb2 From 60b2cb2765e3ea9c758c0f9a6856e26c7c7779ed Mon Sep 17 00:00:00 2001 From: Angel Caamal Date: Mon, 23 Mar 2026 16:30:25 +0000 Subject: [PATCH 2/2] test(storage): fix quickstart system test --- storage/system-test/quickstart.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/storage/system-test/quickstart.test.js b/storage/system-test/quickstart.test.js index 4e3ffe0038..22514a6329 100644 --- a/storage/system-test/quickstart.test.js +++ b/storage/system-test/quickstart.test.js @@ -27,7 +27,7 @@ const bucketName = `nodejs-storage-samples-${uuid.v4()}`; after(async () => { const bucket = storage.bucket(bucketName); - await bucket.delete().catch(console.error); + await bucket.delete({force: true}).catch(console.error); }); it('should run the quickstart', async () => {