Skip to content

Fix PyTorch backend quantile axis handling#2214

Merged
FlorianPfaff merged 2 commits into
mainfrom
codex/fix-pytorch-quantile-axis-20260523
May 23, 2026
Merged

Fix PyTorch backend quantile axis handling#2214
FlorianPfaff merged 2 commits into
mainfrom
codex/fix-pytorch-quantile-axis-20260523

Conversation

@FlorianPfaff
Copy link
Copy Markdown
Owner

Summary

  • wrap the exposed PyTorch backend quantile with a NumPy-compatible signature
  • support axis, keepdims, out, method, and deprecated interpolation arguments when using pyrecest.backend.quantile
  • add a PyTorch subprocess regression test for NumPy-style axis= and keepdims= usage

Rationale

joint_registration_assignment() initializes without an explicit transform via backend.quantile(..., axis=0). Under the PyTorch backend, pyrecest.backend.quantile currently exposes raw torch.quantile, which uses dim= rather than NumPy's axis=. That makes otherwise portable registration code fail only when PYRECEST_BACKEND=pytorch.

Validation

  • Syntax-compiled the modified backend file and new regression test in the execution sandbox.
  • Locally smoke-tested the corresponding torch.quantile(..., dim=..., keepdim=...) calls against installed PyTorch 2.10.0+cpu.
  • Direct repository checkout/pytest execution was not possible because the execution sandbox cannot resolve github.com; PR CI should run the focused backend-portability test and full matrix.

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) May 23, 2026 20:41
@github-actions
Copy link
Copy Markdown
Contributor

⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 43.29s
✅ JSON prettier 7 0 0 0 1.26s
✅ JSON v8r 7 0 0 4.72s
⚠️ MARKDOWN markdownlint 66 0 1 0 1.81s
✅ MARKDOWN markdown-table-formatter 66 0 0 0 0.58s
✅ PYTHON black 756 0 0 0 38.39s
✅ PYTHON isort 756 0 0 0 2.66s
✅ REPOSITORY checkov yes no no 45.5s
✅ REPOSITORY gitleaks yes no no 17.57s
✅ REPOSITORY git_diff yes no no 0.06s
✅ REPOSITORY secretlint yes no no 21.55s
✅ REPOSITORY syft yes no no 5.95s
✅ REPOSITORY trivy-sbom yes no no 6.98s
✅ REPOSITORY trufflehog yes no no 22.55s
✅ YAML prettier 10 0 0 0 0.72s
✅ YAML v8r 10 0 0 11.62s
✅ YAML yamllint 10 0 0 0.56s

Detailed Issues

⚠️ MARKDOWN / markdownlint - 1 error
.github/pull_request_template.md:1 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "## Summary"]

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff merged commit 51262fd into main May 23, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant