GH-1204 Move to paper-api, remove eternalcore-paper module and all associted classes and update material handling to use XMaterial.#1359
Conversation
…ated classes and update material handling to use `XMaterial`.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the project from Spigot API to Paper API, removing the redundant eternalcore-paper module and integrating Paper-specific features directly into the core. It also introduces XMaterial for cross-version material compatibility. While these changes modernize the codebase, several issues were identified during the review: a regression in SpawnRespawnController that ignores respawn anchors by using getBedSpawnLocation(), a potential startup crash in RandomTeleportConfig if a material is unsupported, duplicate or legacy suggestions in MaterialArgument due to XMaterial.values(), and a redundant type check in PhantomSpawnController.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
… `26.1`, `26.1.1`, and `26.1.2`.
… in `DependencyCollector`.
…d compatibility checks
Rollczi
left a comment
Rollczi
left a comment
There was a problem hiding this comment.
Dobra ogólnie to spokoczko parę minorów i trzeba jeszcze dodać Jakiś transformer R <-> L w tym okeri żeby używało MaterialX a nie Material.valueOf
vLuckyyy
changed the title
paper-api, remove eternalcore-paper module and all associted classes and update material handling to use XMaterial.paper-api, remove eternalcore-paper module and all associted classes and update material handling to use XMaterial.
2 participants
No description provided.