Additional instrumentation crd validation#4434
Merged
dsessler7 merged 2 commits intoCrunchyData:mainfrom Feb 18, 2026
Merged
Conversation
…ctor package TestEnablePostgresLogging test.
tjmoore4
approved these changes
Feb 18, 2026
Contributor
tjmoore4
left a comment
tjmoore4
left a comment
There was a problem hiding this comment.
👍 Nice tests, one non-blocking nitpick
| t.Run("Reversed", func(t *testing.T) { | ||
| for _, batches := range []string{ | ||
| `maxRecords: 99`, // default minRecords | ||
| `minRecords: 99, maxRecords: 21`, // |
Contributor
There was a problem hiding this comment.
⛏️ Missing comment info here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
No test for postgrescluster instrumentation validation. No test cases for batches or detectors with attributes in TestEnablePostgresLogging.
What is the new behavior (if this is a feature change)?
This PR adds a test for the instrumentation spec validation in PostgresClusters. It also adds tests that ensure settings for batches and detectors with attributes get set properly in the collector configuration.
Other Information: