Ads no longer grant credits

Author: jahooma

cli/src/chat.tsx

@@ -1449,8 +1449,6 @@ export const Chat = ({
           adData?.variant === 'choice' ? (
             <ChoiceAdBanner
               ads={adData.ads}
-              onDisableAds={handleDisableAds}
-              isFreeMode={IS_FREEBUFF || agentMode === 'FREE'}
               onImpression={recordImpression}
             />
           ) : (

cli/src/commands/ads.ts

@@ -16,7 +16,7 @@ export const handleAdsEnable = (): {
   return {
     postUserMessage: (messages) => [
       ...messages,
-      getSystemMessage('Ads enabled. You will see contextual ads above the input and earn credits from impressions.'),
+      getSystemMessage('Ads enabled. You will see contextual ads above the input.'),
     ],
   }
 }

cli/src/components/ad-banner.tsx

@@ -150,10 +150,7 @@ export const AdBanner: React.FC<AdBannerProps> = ({ ad, onDisableAds, isFreeMode
               {domain}
             </text>
           )}
-          <box style={{ flexGrow: 1 }} />
-          {!IS_FREEBUFF && ad.credits != null && ad.credits > 0 && (
-            <text style={{ fg: theme.muted }}>+{ad.credits} credits</text>
-          )}
+
         </box>
       </Button>
       {/* Info panel: shown when Ad label is clicked, below the ad */}
@@ -179,7 +176,7 @@ export const AdBanner: React.FC<AdBannerProps> = ({ ad, onDisableAds, isFreeMode
             <text style={{ fg: theme.muted, flexShrink: 1 }}>
               {IS_FREEBUFF
                 ? 'Ads help keep Freebuff free.'
-                : 'Ads are optional and earn you credits on each impression. Feel free to hide them anytime.'}
+                : 'Ads are optional. Feel free to hide them anytime.'}
             </text>
             <Button
               onClick={() => setShowInfoPanel(false)}

cli/src/components/choice-ad-banner.tsx

@@ -5,6 +5,7 @@ import React, { useState, useMemo, useEffect } from 'react'
 import { Button } from './button'
 import { useTerminalDimensions } from '../hooks/use-terminal-dimensions'
 import { useTheme } from '../hooks/use-theme'
+import { BORDER_CHARS } from '../utils/ui-constants'
 
 import type { AdResponse } from '../hooks/use-gravity-ad'
 
@@ -106,6 +107,7 @@ export const ChoiceAdBanner: React.FC<ChoiceAdBannerProps> = ({ ads, onImpressio
                 height: CARD_HEIGHT,
                 borderStyle: 'single',
                 borderColor: isHovered ? hoverBorderColor : theme.muted,
+                customBorderChars: BORDER_CHARS,
                 paddingLeft: 1,
                 paddingRight: 1,
                 flexDirection: 'column',

cli/src/components/usage-banner.tsx

@@ -110,7 +110,6 @@ export const UsageBanner = ({ showTime }: { showTime: number }) => {
   }
 
   const colorLevel = getBannerColorLevel(activeData.remainingBalance)
-  const adCredits = activeData.balanceBreakdown?.ad
   const renewalDate = activeData.next_quota_reset ? formatRenewalDate(activeData.next_quota_reset) : null
 
   const activeSubscription = subscriptionData?.hasSubscription ? subscriptionData : null
@@ -152,9 +151,7 @@ export const UsageBanner = ({ showTime }: { showTime: number }) => {
                   {activeData.remainingBalance?.toLocaleString() ?? '?'} credits
                 </text>
               )}
-              {adCredits != null && adCredits > 0 && (
-                <text style={{ fg: theme.muted }}>{`(${adCredits} from ads)`}</text>
-              )}
+
               {!activeSubscription && renewalDate && (
                 <>
                   <text style={{ fg: theme.muted }}>· Renews:</text>

cli/src/data/slash-commands.ts

@@ -83,12 +83,12 @@ const ALL_SLASH_COMMANDS: SlashCommand[] = [
   {
     id: 'ads:enable',
     label: 'ads:enable',
-    description: 'Enable contextual ads and earn credits',
+    description: 'Enable contextual ads',
   },
   {
     id: 'ads:disable',
     label: 'ads:disable',
-    description: 'Disable contextual ads and stop earning credits',
+    description: 'Disable contextual ads',
   },
   {
     id: 'refer-friends',

web/src/app/api/v1/ads/_post.ts

@@ -183,7 +183,7 @@ export async function postAds(params: {
       sessionId: sessionId ?? userId,
       placements,
       testAd: serverEnv.CB_ENVIRONMENT !== 'prod',
-      relevancy: 0.1,
+      relevancy: 0,
       ...(device ? { device } : {}),
       user: {
         id: userId,

web/src/app/api/v1/ads/impression/_post.ts

@@ -1,5 +1,3 @@
-import { createHash } from 'crypto'
-
 import { AnalyticsEvent } from '@codebuff/common/constants/analytics-events'
 import db from '@codebuff/internal/db'
 import * as schema from '@codebuff/internal/db/schema'
@@ -9,7 +7,6 @@ import { z } from 'zod'
 
 import { requireUserFromApiKey } from '../../_helpers'
 
-import type { processAndGrantCredit as ProcessAndGrantCreditFn } from '@codebuff/billing/grant-credits'
 import type { TrackEventFn } from '@codebuff/common/types/contracts/analytics'
 import type { GetUserInfoFromApiKeyFn } from '@codebuff/common/types/contracts/database'
 import type {
@@ -18,10 +15,6 @@ import type {
 } from '@codebuff/common/types/contracts/logger'
 import type { NextRequest } from 'next/server'
 
-// Revenue share: users get 75% of payout as credits
-const AD_REVENUE_SHARE = 0.75
-const MINIMUM_CREDITS_GRANTED = 2
-
 // Rate limiting: max impressions per user per hour
 const MAX_IMPRESSIONS_PER_HOUR = 60
 
@@ -78,22 +71,8 @@ function checkRateLimit(userId: string): boolean {
   return true
 }
 
-/**
- * Generate a deterministic operation ID for deduplication.
- * Same user + same impUrl = same operationId, preventing duplicate credits.
- */
-function generateImpressionOperationId(userId: string, impUrl: string): string {
-  const hash = createHash('sha256')
-    .update(`${userId}:${impUrl}`)
-    .digest('hex')
-    .slice(0, 16)
-  return `ad-imp-${hash}`
-}
-
 const bodySchema = z.object({
-  // Only impUrl needed - we look up the ad data from our database
   impUrl: z.url(),
-  // Mode to determine if credits should be granted (FREE mode gets no credits)
   mode: z.string().optional(),
 })
 
@@ -103,22 +82,19 @@ export async function postAdImpression(params: {
   logger: Logger
   loggerWithContext: LoggerWithContextFn
   trackEvent: TrackEventFn
-  processAndGrantCredit: typeof ProcessAndGrantCreditFn
   fetch: typeof globalThis.fetch
 }) {
   const {
     req,
     getUserInfoFromApiKey,
     loggerWithContext,
     trackEvent,
-    processAndGrantCredit,
     fetch,
   } = params
   const baseLogger = params.logger
 
   // Parse and validate request body
   let impUrl: string
-  let mode: string | undefined
   try {
     const json = await req.json()
     const parsed = bodySchema.safeParse(json)
@@ -129,7 +105,6 @@ export async function postAdImpression(params: {
       )
     }
     impUrl = parsed.data.impUrl
-    mode = parsed.data.mode
   } catch {
     return NextResponse.json(
       { error: 'Invalid JSON in request body' },
@@ -203,16 +178,10 @@ export async function postAdImpression(params: {
     )
   }
 
-  // Get payout from the trusted database record
-  const payout = parseFloat(adRecord.payout)
-
-  // Generate deterministic operation ID for deduplication
-  const operationId = generateImpressionOperationId(userId, impUrl)
-
   // Fire the impression pixel to Gravity
   try {
     await fetch(impUrl)
-    logger.info({ userId, operationId, impUrl }, '[ads] Fired impression pixel')
+    logger.info({ userId, impUrl }, '[ads] Fired impression pixel')
   } catch (error) {
     logger.warn(
       {
@@ -224,82 +193,25 @@ export async function postAdImpression(params: {
       },
       '[ads] Failed to fire impression pixel',
     )
-    // Continue anyway - we still want to grant credits
+    // Continue anyway - we still want to record the impression
   }
 
-  // Calculate credits to grant (75% of payout, converted to credits)
-  // Payout is in dollars, credits are 1:1 with cents, so multiply by 100
-  const userShareDollars = payout * AD_REVENUE_SHARE
-  const creditsToGrant = Math.max(
-    MINIMUM_CREDITS_GRANTED + Math.floor(3 * Math.random()),
-    Math.floor(userShareDollars * 100),
-  )
-
-  let creditsGranted = 0
-  // FREE mode should not grant any credits
-  if (mode !== 'FREE' && creditsToGrant > 0) {
-    try {
-      await processAndGrantCredit({
-        userId,
-        amount: creditsToGrant,
-        type: 'ad',
-        description: `Ad impression credit (${(userShareDollars * 100).toFixed(1)}¢ from $${payout.toFixed(4)} payout)`,
-        expiresAt: null, // Ad credits don't expire
-        operationId,
-        logger,
-      })
-
-      creditsGranted = creditsToGrant
-
-      logger.info(
-        {
-          userId,
-          payout,
-          creditsGranted,
-          operationId,
-        },
-        '[ads] Granted ad impression credits',
-      )
-
-      trackEvent({
-        event: AnalyticsEvent.CREDIT_GRANT,
-        userId,
-        properties: {
-          type: 'ad',
-          amount: creditsGranted,
-          payout,
-        },
-        logger,
-      })
-    } catch (error) {
-      logger.error(
-        {
-          userId,
-          payout,
-          error:
-            error instanceof Error
-              ? { name: error.name, message: error.message }
-              : error,
-        },
-        '[ads] Failed to grant ad impression credits',
-      )
-      // Don't fail the request - we still want to update the impression record
-    }
-  }
+  // No credits granted for ad impressions
+  const creditsGranted = 0
 
   // Update the ad_impression record with impression details (for ALL modes)
   try {
     await db
       .update(schema.adImpression)
       .set({
         impression_fired_at: new Date(),
-        credits_granted: creditsGranted,
-        grant_operation_id: creditsGranted > 0 ? operationId : null,
+        credits_granted: 0,
+        grant_operation_id: null,
       })
       .where(eq(schema.adImpression.id, adRecord.id))
 
     logger.info(
-      { userId, impUrl, creditsGranted, creditsToGrant },
+      { userId, impUrl },
       '[ads] Updated ad impression record',
     )
   } catch (error) {

web/src/app/api/v1/ads/impression/route.ts

@@ -1,4 +1,3 @@
-import { processAndGrantCredit } from '@codebuff/billing/grant-credits'
 import { trackEvent } from '@codebuff/common/analytics'
 
 import { postAdImpression } from './_post'
@@ -15,7 +14,6 @@ export async function POST(req: NextRequest) {
     logger,
     loggerWithContext,
     trackEvent,
-    processAndGrantCredit,
     fetch,
   })
 }