From 1924ef4d248c8fd0f9b206ea7ff3ecfa48828c25 Mon Sep 17 00:00:00 2001
From: Liban Jama <jliban756@gmail.com>
Date: Fri, 6 Mar 2026 18:54:30 +0000
Subject: [PATCH 1/8] Completed 1-get-angle-type

---
 .../implement/1-get-angle-type.js             | 26 +++++++++++++++++++
 .../1-get-angle-type.test.js                  | 24 +++++++++++++++++
 2 files changed, 50 insertions(+)

diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js b/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js
index 9e05a871e2..9a68d8c68b 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js
@@ -16,6 +16,32 @@
 
 function getAngleType(angle) {
   // TODO: Implement this function
+  // if angle is between 0 and 90 then return acute angle
+  if (angle > 0 && angle < 90) {
+    return "Acute angle";
+  }
+
+  // if it is exactly 90 return right angle
+  else if (angle === 90) {
+    return "Right angle";
+  }
+  // greater than 90 less than 180 return obtuse angle
+  else if (angle > 90 && angle < 180) {
+    return "Obtuse angle";
+  }
+  // if exactly 180 return straight angle
+  else if (angle === 180) {
+    return "Straight angle";
+  }
+  // greater than 180 less than 360 return reflex angle
+  else if (angle > 180 && angle < 360) {
+    return "Reflex angle";
+  }
+  // everything greater than 360 return invalid angle
+  else {
+    return "Invalid angle";
+  }
+  // return a string tells user which angle
 }
 
 // The line below allows us to load the getAngleType function into tests in other files.
diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js
index d777f348d3..d15ef51f71 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js
@@ -14,7 +14,31 @@ test(`should return "Acute angle" when (0 < angle < 90)`, () => {
 });
 
 // Case 2: Right angle
+test(`should return "Right angle" when (angle === 90)`, () => {
+  // Test various right angles, including boundary cases
+  expect(getAngleType(90)).toEqual("Right angle");
+});
 // Case 3: Obtuse angles
+test(`should return "Obtuse angles" when (angle > 90 && < 180)`, () => {
+  // Test various obtuse angles, including boundary cases
+  expect(getAngleType(96)).toEqual("Obtuse angle");
+  expect(getAngleType(142)).toEqual("Obtuse angle");
+  expect(getAngleType(178)).toEqual("Obtuse angle");
+});
 // Case 4: Straight angle
+test(`should return "Straight angle" when (angle === 180)`, () => {
+  // Test various straight angles, including boundary cases
+  expect(getAngleType(180)).toEqual("Straight angle");
+});
 // Case 5: Reflex angles
+test(`should return "Reflex angles" when (angle > 180 && < 360)`, () => {
+  // Test various reflex angles, including boundary cases
+  expect(getAngleType(199)).toEqual("Reflex angle");
+  expect(getAngleType(245)).toEqual("Reflex angle");
+  expect(getAngleType(306)).toEqual("Reflex angle");
+});
 // Case 6: Invalid angles
+test(`should return "Invalid angles" when (angle > 180 && < 360)`, () => {
+  // Test various invalid angles, including boundary cases
+  expect(getAngleType(360)).toEqual("Invalid angle");
+});

From a73fa1a7a97777e04952d9950b61188a3578e737 Mon Sep 17 00:00:00 2001
From: Liban Jama <jliban756@gmail.com>
Date: Fri, 6 Mar 2026 18:56:45 +0000
Subject: [PATCH 2/8] Completed 2-is-proper-fraction

---
 .../implement/2-is-proper-fraction.js             |  2 ++
 .../2-is-proper-fraction.test.js                  | 15 +++++++++++++++
 2 files changed, 17 insertions(+)

diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js b/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
index 970cb9b641..3884d6558b 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
@@ -12,6 +12,8 @@
 
 function isProperFraction(numerator, denominator) {
   // TODO: Implement this function
+  if (denominator === 0) return false;
+  return Math.abs(numerator) < Math.abs(denominator);
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.
diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
index 7f087b2ba1..7a091b0da4 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
@@ -8,3 +8,18 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 test(`should return false when denominator is zero`, () => {
   expect(isProperFraction(1, 0)).toEqual(false);
 });
+
+test(`for positive`, () => {
+  expect(isProperFraction(6, 7)).toEqual(true);
+  expect(isProperFraction(2, 4)).toEqual(true);
+});
+
+test(`should return false for improper fractions`, () => {
+  expect(isProperFraction(8, 6)).toEqual(false);
+  expect(isProperFraction(4, 2)).toEqual(false);
+});
+
+test(`negative combinations`, () => {
+  expect(isProperFraction(-5, 9)).toEqual(true);
+  expect(isProperFraction(-2, 0)).toEqual(false);
+});

From 3d438c6fe49ecdc468069f49fee0fe5af1215c98 Mon Sep 17 00:00:00 2001
From: Liban Jama <jliban756@gmail.com>
Date: Fri, 6 Mar 2026 19:02:24 +0000
Subject: [PATCH 3/8] Completed 3-get-card-value

---
 .../implement/3-get-card-value.js             | 19 ++++++++++++++-
 .../3-get-card-value.test.js                  | 24 +++++++++++++++++--
 2 files changed, 40 insertions(+), 3 deletions(-)

diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js b/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
index c7559e787e..97e6bc374c 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
@@ -23,6 +23,23 @@
 
 function getCardValue(card) {
   // TODO: Implement this function
+
+  // if card is an ace return 11
+  if (card === "A") {
+    return 11;
+  }
+
+  // if card is face "J", "Q", "K"
+  else if (card === "J" || card === "Q" || card === "K") {
+    return 10;
+  }
+
+  // if card is a number card and card is bigger than 2 and less than 10 ("2" to "10"), should return its numerical value
+  else if (Number(card) >= 2 && Number(card) <= 10) {
+    return Number(card);
+  } else {
+    throw new Error("Error invalid card");
+  }
 }
 
 // The line below allows us to load the getCardValue function into tests in other files.
@@ -39,7 +56,7 @@ function assertEquals(actualOutput, targetOutput) {
 
 // TODO: Write tests to cover all outcomes, including throwing errors for invalid cards.
 // Examples:
-assertEquals(getCardValue("9♠"), 9);
+assertEquals(getCardValue("9"), 9);
 
 // Handling invalid cards
 try {
diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
index cf7f9dae2e..f3c1ba27d3 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
@@ -6,7 +6,7 @@ const getCardValue = require("../implement/3-get-card-value");
 
 // Case 1: Ace (A)
 test(`Should return 11 when given an ace card`, () => {
-  expect(getCardValue("A♠")).toEqual(11);
+  expect(getCardValue("A")).toEqual(11);
 });
 
 // Suggestion: Group the remaining test data into these categories:
@@ -14,7 +14,27 @@ test(`Should return 11 when given an ace card`, () => {
 //   Face Cards (J, Q, K)
 //   Invalid Cards
 
+// Case 2: Face (J, Q, K)
+test(`Should return 10 when given an face card`, () => {
+  expect(getCardValue("J")).toEqual(10);
+});
+
+test(`Should return 10 when given an face card`, () => {
+  expect(getCardValue("Q")).toEqual(10);
+});
+
+test(`Should return 10 when given an face card`, () => {
+  expect(getCardValue("K")).toEqual(10);
+});
+// Case 3: Number Cards (2-10)
+test(`Should return numerical value when given an number card`, () => {
+  expect(getCardValue("5")).toEqual(5);
+});
+
+test(`Should return error if the card string is invalid`, () => {
+  expect(() => getCardValue("17")).toThrow("Error invalid card");
+});
+
 // To learn how to test whether a function throws an error as expected in Jest,
 // please refer to the Jest documentation:
 // https://jestjs.io/docs/expect#tothrowerror
-

From f6f394c8e8e3e2836a01bb98b230c42ca501379e Mon Sep 17 00:00:00 2001
From: Liban Jama <jliban756@gmail.com>
Date: Mon, 16 Mar 2026 11:03:02 +0000
Subject: [PATCH 4/8] Updated after feedback

---
 .../implement/1-get-angle-type.js             | 22 +++++++++++++-
 .../implement/3-get-card-value.js             | 14 +++++++--
 .../1-get-angle-type.test.js                  | 14 +++++++--
 .../2-is-proper-fraction.test.js              | 29 ++++++++++++++++---
 .../3-get-card-value.test.js                  |  8 ++---
 5 files changed, 72 insertions(+), 15 deletions(-)

diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js b/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js
index 9a68d8c68b..42fe7b86f9 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js
@@ -37,7 +37,12 @@ function getAngleType(angle) {
   else if (angle > 180 && angle < 360) {
     return "Reflex angle";
   }
-  // everything greater than 360 return invalid angle
+
+  // if it is 360 then it is a full rotation
+  else if (angle === 360) {
+    return "Full rotation";
+  }
+  // everything greater than 360 rand less than 0 return invalid angle
   else {
     return "Invalid angle";
   }
@@ -61,3 +66,18 @@ function assertEquals(actualOutput, targetOutput) {
 // Example: Identify Right Angles
 const right = getAngleType(90);
 assertEquals(right, "Right angle");
+
+const acute = getAngleType(45);
+assertEquals(acute, "Acute angle");
+
+const obtuse = getAngleType(120);
+assertEquals(obtuse, "Obtuse angle");
+
+const straight = getAngleType(180);
+assertEquals(straight, "Straight angle");
+
+const reflex = getAngleType(270);
+assertEquals(reflex, "Reflex angle");
+
+const invalid = getAngleType(200);
+assertEquals(invalid, "Invalid angle");
diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js b/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
index 97e6bc374c..8a43ad2b38 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
@@ -22,15 +22,23 @@
 // execute the code to ensure all tests pass.
 
 function getCardValue(card) {
+  const suits = ["♠", "♥", "♦", "♣"]; // valid card suits
+
+  const suit = card.slice(-1); // gives me the last character
+  const rank = card.slice(0, -1); // gets beginning character up to (not including) the last character
+
+  if (!suits.includes(suit)) {
+    throw new Error("Error invalid card");
+  }
   // TODO: Implement this function
 
   // if card is an ace return 11
-  if (card === "A") {
+  if (card === "A♠") {
     return 11;
   }
 
   // if card is face "J", "Q", "K"
-  else if (card === "J" || card === "Q" || card === "K") {
+  else if (card === "J♣" || card === "Q♦" || card === "K♥") {
     return 10;
   }
 
@@ -56,7 +64,7 @@ function assertEquals(actualOutput, targetOutput) {
 
 // TODO: Write tests to cover all outcomes, including throwing errors for invalid cards.
 // Examples:
-assertEquals(getCardValue("9"), 9);
+assertEquals(getCardValue("9♠"), 9);
 
 // Handling invalid cards
 try {
diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js
index d15ef51f71..2357e17d5e 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js
@@ -37,8 +37,16 @@ test(`should return "Reflex angles" when (angle > 180 && < 360)`, () => {
   expect(getAngleType(245)).toEqual("Reflex angle");
   expect(getAngleType(306)).toEqual("Reflex angle");
 });
-// Case 6: Invalid angles
-test(`should return "Invalid angles" when (angle > 180 && < 360)`, () => {
+// Case 6: Full rotation
+test("returns full rotation for 360 degrees (angle === 360))", () => {
+  expect(getAngleType(360)).toBe("Full rotation");
+});
+// Case 7: Invalid angles
+test(`should return "Invalid angles" when (angle >360)`, () => {
   // Test various invalid angles, including boundary cases
-  expect(getAngleType(360)).toEqual("Invalid angle");
+  expect(getAngleType(400)).toEqual("Invalid angle");
+});
+// Case 8: Invalid angles
+test(`should return "Invalid angles" when (angle <0)`, () => {
+  expect(getAngleType(-7)).toBe("Invalid angle");
 });
diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
index 7a091b0da4..450949f004 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
@@ -4,22 +4,43 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 
 // TODO: Write tests in Jest syntax to cover all combinations of positives, negatives, zeros, and other categories.
 
-// Special case: numerator is zero
+// Special case: denominator is zero
 test(`should return false when denominator is zero`, () => {
   expect(isProperFraction(1, 0)).toEqual(false);
 });
 
-test(`for positive`, () => {
+// Case 2: Proper fractions
+// the numerator is smaller than the denominator, so the fraction is a proper fraction
+test(`should return true when |numerator| < |denominator|`, () => {
   expect(isProperFraction(6, 7)).toEqual(true);
   expect(isProperFraction(2, 4)).toEqual(true);
 });
 
-test(`should return false for improper fractions`, () => {
+// Case 3: Improper fractions
+// numerator is bigger than denominator, so the fraction is not proper
+test("should return false when numerator is bigger than denominator", () => {
   expect(isProperFraction(8, 6)).toEqual(false);
   expect(isProperFraction(4, 2)).toEqual(false);
 });
 
-test(`negative combinations`, () => {
+// Case 4: Negative numbers
+// numerator or denominator is negative, but function compares absolute values
+test("should return correct result when numerator or denominator is negative", () => {
   expect(isProperFraction(-5, 9)).toEqual(true);
   expect(isProperFraction(-2, 0)).toEqual(false);
 });
+
+// Case 5: Numerator equals denominator fraction equals 1, so it is not proper
+test("should return false when numerator is equal to denominator", () => {
+  expect(isProperFraction(6, 6)).toEqual(false);
+});
+
+// Case 6: Numerator just less than denominator fraction is slightly below 1, so it is proper
+test("should return true when numerator is just less than denominator", () => {
+  expect(isProperFraction(2, 3)).toEqual(true);
+});
+
+// Case 7: Numerator greater than denominator fraction is slightly above 1, so it is not proper
+test("should return false when numerator is greater than denominator", () => {
+  expect(isProperFraction(6, 5)).toEqual(false);
+});
diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
index f3c1ba27d3..a17ccb5ad1 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
@@ -6,7 +6,7 @@ const getCardValue = require("../implement/3-get-card-value");
 
 // Case 1: Ace (A)
 test(`Should return 11 when given an ace card`, () => {
-  expect(getCardValue("A")).toEqual(11);
+  expect(getCardValue("A♠")).toEqual(11);
 });
 
 // Suggestion: Group the remaining test data into these categories:
@@ -16,15 +16,15 @@ test(`Should return 11 when given an ace card`, () => {
 
 // Case 2: Face (J, Q, K)
 test(`Should return 10 when given an face card`, () => {
-  expect(getCardValue("J")).toEqual(10);
+  expect(getCardValue("J♣")).toEqual(10);
 });
 
 test(`Should return 10 when given an face card`, () => {
-  expect(getCardValue("Q")).toEqual(10);
+  expect(getCardValue("Q♦")).toEqual(10);
 });
 
 test(`Should return 10 when given an face card`, () => {
-  expect(getCardValue("K")).toEqual(10);
+  expect(getCardValue("K♥")).toEqual(10);
 });
 // Case 3: Number Cards (2-10)
 test(`Should return numerical value when given an number card`, () => {

From 254abc7d4128c704a4a68aa1bf6a3c8e3df5eca9 Mon Sep 17 00:00:00 2001
From: Liban Jama <jliban756@gmail.com>
Date: Wed, 18 Mar 2026 11:14:03 +0000
Subject: [PATCH 5/8] Updated as per PR comments

---
 .../implement/1-get-angle-type.js             |  5 ----
 .../implement/3-get-card-value.js             | 23 +++++++++++--------
 .../1-get-angle-type.test.js                  | 13 ++++-------
 .../2-is-proper-fraction.test.js              |  4 ++--
 4 files changed, 19 insertions(+), 26 deletions(-)

diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js b/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js
index 42fe7b86f9..972a4a495d 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js
@@ -37,11 +37,6 @@ function getAngleType(angle) {
   else if (angle > 180 && angle < 360) {
     return "Reflex angle";
   }
-
-  // if it is 360 then it is a full rotation
-  else if (angle === 360) {
-    return "Full rotation";
-  }
   // everything greater than 360 rand less than 0 return invalid angle
   else {
     return "Invalid angle";
diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js b/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
index 8a43ad2b38..2a76c70651 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
@@ -24,30 +24,33 @@
 function getCardValue(card) {
   const suits = ["♠", "♥", "♦", "♣"]; // valid card suits
 
-  const suit = card.slice(-1); // gives me the last character
-  const rank = card.slice(0, -1); // gets beginning character up to (not including) the last character
+  let suit = "";
+  let rank = card;
 
-  if (!suits.includes(suit)) {
+  if (card.length > 1) {
+    suit = card.slice(-1); // gives me the last character and saves it in the suit variable.
+    rank = card.slice(0, -1); // gets beginning character up to (not including) the last character and saves it in the rank variable.
+  }
+
+  if (suit && !suits.includes(suit)) {
     throw new Error("Error invalid card");
   }
-  // TODO: Implement this function
 
   // if card is an ace return 11
-  if (card === "A♠") {
+  if (rank === "A") {
     return 11;
   }
 
   // if card is face "J", "Q", "K"
-  else if (card === "J♣" || card === "Q♦" || card === "K♥") {
+  else if (rank === "J" || rank === "Q" || rank === "K") {
     return 10;
   }
 
   // if card is a number card and card is bigger than 2 and less than 10 ("2" to "10"), should return its numerical value
-  else if (Number(card) >= 2 && Number(card) <= 10) {
-    return Number(card);
-  } else {
-    throw new Error("Error invalid card");
+  else if (Number(rank) >= 2 && Number(rank) <= 10) {
+    return Number(rank);
   }
+  throw new Error("Error invalid card");
 }
 
 // The line below allows us to load the getCardValue function into tests in other files.
diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js
index 2357e17d5e..7d4de90fc1 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js
@@ -37,16 +37,11 @@ test(`should return "Reflex angles" when (angle > 180 && < 360)`, () => {
   expect(getAngleType(245)).toEqual("Reflex angle");
   expect(getAngleType(306)).toEqual("Reflex angle");
 });
-// Case 6: Full rotation
-test("returns full rotation for 360 degrees (angle === 360))", () => {
-  expect(getAngleType(360)).toBe("Full rotation");
-});
-// Case 7: Invalid angles
-test(`should return "Invalid angles" when (angle >360)`, () => {
+// Case 6: Invalid angles
+test(`should return "Invalid angles" when (angle is =<0 &&>=360)`, () => {
   // Test various invalid angles, including boundary cases
   expect(getAngleType(400)).toEqual("Invalid angle");
-});
-// Case 8: Invalid angles
-test(`should return "Invalid angles" when (angle <0)`, () => {
   expect(getAngleType(-7)).toBe("Invalid angle");
+  expect(getAngleType(360)).toBe("Invalid angle");
+  expect(getAngleType(0)).toBe("Invalid angle");
 });
diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
index 450949f004..bb7e69a25b 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
@@ -11,7 +11,7 @@ test(`should return false when denominator is zero`, () => {
 
 // Case 2: Proper fractions
 // the numerator is smaller than the denominator, so the fraction is a proper fraction
-test(`should return true when |numerator| < |denominator|`, () => {
+test(`should return true when numerator < denominator`, () => {
   expect(isProperFraction(6, 7)).toEqual(true);
   expect(isProperFraction(2, 4)).toEqual(true);
 });
@@ -27,7 +27,7 @@ test("should return false when numerator is bigger than denominator", () => {
 // numerator or denominator is negative, but function compares absolute values
 test("should return correct result when numerator or denominator is negative", () => {
   expect(isProperFraction(-5, 9)).toEqual(true);
-  expect(isProperFraction(-2, 0)).toEqual(false);
+  expect(isProperFraction(7, -3)).toEqual(false);
 });
 
 // Case 5: Numerator equals denominator fraction equals 1, so it is not proper

From 1a4482e29eacc10d70d110590d3a353ff31b9526 Mon Sep 17 00:00:00 2001
From: Liban Jama <jliban756@gmail.com>
Date: Wed, 18 Mar 2026 14:43:58 +0000
Subject: [PATCH 6/8] Updated after PR comments

---
 .../implement/3-get-card-value.js             | 23 ++++++++++---------
 .../1-get-angle-type.test.js                  |  2 +-
 .../2-is-proper-fraction.test.js              |  6 +++--
 .../3-get-card-value.test.js                  |  7 ++++++
 4 files changed, 24 insertions(+), 14 deletions(-)

diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js b/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
index 2a76c70651..89e413f4c8 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
@@ -27,7 +27,7 @@ function getCardValue(card) {
   let suit = "";
   let rank = card;
 
-  if (card.length > 1) {
+  if (suits.includes(card.slice(-1))) {
     suit = card.slice(-1); // gives me the last character and saves it in the suit variable.
     rank = card.slice(0, -1); // gets beginning character up to (not including) the last character and saves it in the rank variable.
   }
@@ -42,15 +42,16 @@ function getCardValue(card) {
   }
 
   // if card is face "J", "Q", "K"
-  else if (rank === "J" || rank === "Q" || rank === "K") {
+  if (rank === "J" || rank === "Q" || rank === "K") {
     return 10;
   }
 
+  const num = Number(rank);
   // if card is a number card and card is bigger than 2 and less than 10 ("2" to "10"), should return its numerical value
-  else if (Number(rank) >= 2 && Number(rank) <= 10) {
-    return Number(rank);
+  if (rank !== String(num) || num < 2 || num > 10) {
+    throw new Error("Error invalid card");
   }
-  throw new Error("Error invalid card");
+  return num;
 }
 
 // The line below allows us to load the getCardValue function into tests in other files.
@@ -67,14 +68,14 @@ function assertEquals(actualOutput, targetOutput) {
 
 // TODO: Write tests to cover all outcomes, including throwing errors for invalid cards.
 // Examples:
-assertEquals(getCardValue("9♠"), 9);
+// assertEquals(getCardValue("9♠"), 9);
 
 // Handling invalid cards
-try {
-  getCardValue("invalid");
+// try {
+//   getCardValue("invalid");
 
-  // This line will not be reached if an error is thrown as expected
-  console.error("Error was not thrown for invalid card");
-} catch (e) {}
+//   // This line will not be reached if an error is thrown as expected
+//   console.error("Error was not thrown for invalid card");
+// } catch (e) {}
 
 // What other invalid card cases can you think of?
diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js
index 7d4de90fc1..d8ea4be721 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js
@@ -38,7 +38,7 @@ test(`should return "Reflex angles" when (angle > 180 && < 360)`, () => {
   expect(getAngleType(306)).toEqual("Reflex angle");
 });
 // Case 6: Invalid angles
-test(`should return "Invalid angles" when (angle is =<0 &&>=360)`, () => {
+test(`should return "Invalid angles" when (angle is <= 0 && >= 360)`, () => {
   // Test various invalid angles, including boundary cases
   expect(getAngleType(400)).toEqual("Invalid angle");
   expect(getAngleType(-7)).toBe("Invalid angle");
diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
index bb7e69a25b..a218edffcc 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js
@@ -25,10 +25,12 @@ test("should return false when numerator is bigger than denominator", () => {
 
 // Case 4: Negative numbers
 // numerator or denominator is negative, but function compares absolute values
-test("should return correct result when numerator or denominator is negative", () => {
-  expect(isProperFraction(-5, 9)).toEqual(true);
+test("should return false when |numerator| < |denominator| positive numerator and negative denominator)", () => {
   expect(isProperFraction(7, -3)).toEqual(false);
 });
+test("should return true when |numerator| < |denominator| negative numerator and positive denominator)", () => {
+  expect(isProperFraction(-5, 9)).toEqual(true);
+});
 
 // Case 5: Numerator equals denominator fraction equals 1, so it is not proper
 test("should return false when numerator is equal to denominator", () => {
diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
index a17ccb5ad1..b8c8731e7a 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
@@ -35,6 +35,13 @@ test(`Should return error if the card string is invalid`, () => {
   expect(() => getCardValue("17")).toThrow("Error invalid card");
 });
 
+// Case 4: Hex, Decimal Numbers
+test(`Should return error if the rank is a hex input`, () => {
+  expect(() => getCardValue("0x02♠")).toThrow("Error invalid card");
+  expect(() => getCardValue("2.1♠")).toThrow("Error invalid card");
+  expect(() => getCardValue("0002♠")).toThrow("Error invalid card");
+});
+
 // To learn how to test whether a function throws an error as expected in Jest,
 // please refer to the Jest documentation:
 // https://jestjs.io/docs/expect#tothrowerror

From aabad30f1858de08a29ddab73be6648e2bd37f3d Mon Sep 17 00:00:00 2001
From: Liban Jama <jliban756@gmail.com>
Date: Thu, 19 Mar 2026 14:20:17 +0000
Subject: [PATCH 7/8] fixed error

---
 .../1-implement-and-rewrite-tests/implement/3-get-card-value.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js b/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
index 89e413f4c8..c4ae383ec7 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
@@ -48,7 +48,7 @@ function getCardValue(card) {
 
   const num = Number(rank);
   // if card is a number card and card is bigger than 2 and less than 10 ("2" to "10"), should return its numerical value
-  if (rank !== String(num) || num < 2 || num > 10) {
+  if (!Number.isInteger(num) || rank !== String(num) || num < 2 || num > 10) {
     throw new Error("Error invalid card");
   }
   return num;

From c55583394330da39ba45515c5a50b2c731b5f05a Mon Sep 17 00:00:00 2001
From: Liban Jama <jliban756@gmail.com>
Date: Thu, 19 Mar 2026 16:25:03 +0000
Subject: [PATCH 8/8] Further updates

---
 .../implement/3-get-card-value.js                   | 13 ++++---------
 .../3-get-card-value.test.js                        |  2 +-
 2 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js b/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
index c4ae383ec7..775f9b2aa7 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
@@ -24,18 +24,13 @@
 function getCardValue(card) {
   const suits = ["♠", "♥", "♦", "♣"]; // valid card suits
 
-  let suit = "";
-  let rank = card;
-
-  if (suits.includes(card.slice(-1))) {
-    suit = card.slice(-1); // gives me the last character and saves it in the suit variable.
-    rank = card.slice(0, -1); // gets beginning character up to (not including) the last character and saves it in the rank variable.
-  }
-
-  if (suit && !suits.includes(suit)) {
+  // must have a valid suit
+  if (!suits.includes(card.slice(-1))) {
     throw new Error("Error invalid card");
   }
 
+  const rank = card.slice(0, -1); // gets beginning character up to (not including) the last character and saves it in the rank variable.
+
   // if card is an ace return 11
   if (rank === "A") {
     return 11;
diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
index b8c8731e7a..7399d2f568 100644
--- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
+++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
@@ -28,7 +28,7 @@ test(`Should return 10 when given an face card`, () => {
 });
 // Case 3: Number Cards (2-10)
 test(`Should return numerical value when given an number card`, () => {
-  expect(getCardValue("5")).toEqual(5);
+  expect(() => getCardValue("5")).toThrow("Error invalid card");
 });
 
 test(`Should return error if the card string is invalid`, () => {