Skip to content

Commit e0e964d

Browse files
Enhance isProperFraction with input validation
Added checks for finite and integer values of numerator and denominator.
1 parent 033144b commit e0e964d

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,13 @@
1111
// execute the code to ensure all tests pass.
1212

1313
function isProperFraction(numerator, denominator) {
14-
if (denominator === 0) {
14+
if (!Number.isFinite(numerator) || !Number.isFinite(denominator)) {
15+
return false;
16+
}
17+
if (!Number.isInteger(numerator) || !Number.isInteger(denominator)) {
1518
return false;
1619
}
17-
if (Number.isNaN(numerator) || Number.isNaN(denominator)) {
20+
if (denominator === 0) {
1821
return false;
1922
}
2023
return Math.abs(numerator) < Math.abs(denominator);

0 commit comments

Comments
 (0)