Skip to content

Commit 66ddc36

Browse files
authored
Fix isProperFraction logic and expand test cases
Updated the isProperFraction function to handle negative values correctly and added additional test cases for comprehensive coverage.
1 parent 390b390 commit 66ddc36

1 file changed

Lines changed: 13 additions & 1 deletion

File tree

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11

22
function isProperFraction(numerator, denominator) {
3-
return numerator < denominator;
3+
return Math.abs(numerator) < Math.abs(denominator);
44
}
55

66
function assertEquals(actualOutput, targetOutput) {
@@ -13,9 +13,21 @@ assertEquals(isProperFraction(1, 2), true);
1313
assertEquals(isProperFraction(3, 4), true);
1414
assertEquals(isProperFraction(0, 5), true);
1515

16+
assertEquals(isProperFraction(-1, 2), true);
17+
assertEquals(isProperFraction(1, -2), true);
18+
assertEquals(isProperFraction(-1, -2), true);
19+
1620
assertEquals(isProperFraction(5, 5), false);
21+
assertEquals(isProperFraction(-5, -5), false);
1722

1823
assertEquals(isProperFraction(7, 4), false);
1924
assertEquals(isProperFraction(10, 3), false);
2025

26+
assertEquals(isProperFraction(-5, 2), false);
27+
assertEquals(isProperFraction(5, -2), false);
28+
assertEquals(isProperFraction(-5, -2), false);
29+
30+
31+
32+
2133
console.log("All tests finished");

0 commit comments

Comments
 (0)